Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-26 Thread Daniel Kiper
On Mon, Mar 26, 2018 at 02:10:48PM +0100, John Lane wrote: > On 22/03/18 14:22, TJ wrote: > > On 22/03/18 12:38, Daniel Kiper wrote: > >> Hi John, > >> > >> On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: > >>> On 14/03/18 13:05, Daniel Kiper wrote: > On Wed, Mar 14, 2018 at 09:44:5

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-26 Thread John Lane
On 22/03/18 14:22, TJ wrote: > On 22/03/18 12:38, Daniel Kiper wrote: >> Hi John, >> >> On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: >>> On 14/03/18 13:05, Daniel Kiper wrote: On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > From: John Lane I have just

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-22 Thread TJ
On 22/03/18 12:38, Daniel Kiper wrote: > Hi John, > > On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: >> On 14/03/18 13:05, Daniel Kiper wrote: >>> On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: From: John Lane >>> >>> I have just skimmed through the series. First of a

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-22 Thread Daniel Kiper
Hi John, On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: > On 14/03/18 13:05, Daniel Kiper wrote: > > On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > >> From: John Lane > > > > I have just skimmed through the series. First of all, most if not > > all patches beg for full b

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-21 Thread Paul Menzel
Dear John, Am Mittwoch, den 14.03.2018, 19:00 + schrieb John Lane: > On 14/03/18 13:05, Daniel Kiper wrote: > > On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > > > From: John Lane > > > > I have just skimmed through the series. First of all, most if not > > all patches beg for

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-18 Thread John Lane
On 17/03/18 11:09, TJ wrote: > On 14/03/18 09:44, John Lane wrote: >> --- a/grub-core/disk/cryptodisk.c >> +++ b/grub-core/disk/cryptodisk.c >> @@ -880,7 +882,7 @@ grub_cryptodisk_cheat_mount (const char *sourcedev, >> const char *cheat) >> >>FOR_CRYPTODISK_DEVS (cr) >>{ >> -dev = cr

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-17 Thread TJ
On 14/03/18 09:44, John Lane wrote: > --- a/grub-core/disk/cryptodisk.c > +++ b/grub-core/disk/cryptodisk.c > @@ -880,7 +882,7 @@ grub_cryptodisk_cheat_mount (const char *sourcedev, const > char *cheat) > >FOR_CRYPTODISK_DEVS (cr) >{ > -dev = cr->scan (source, search_uuid, check_boot

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-14 Thread John Lane
? These patches provide extensions to the "cryptomount" command. There are my original five patches, plus an additional two patches from other contributors who sent pull requests. [PATCH 1/7] Cryptomount support LUKS detached header Support LUKS detached headers so that the header

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-14 Thread Daniel Kiper
On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > From: John Lane I have just skimmed through the series. First of all, most if not all patches beg for full blown commit messages. Just vague statements in the subject are insufficient for me. And please add patch 0 which introduces the

[PATCH 1/7] Cryptomount support LUKS detached header

2018-03-14 Thread John Lane
From: John Lane --- grub-core/disk/cryptodisk.c | 22 ++ grub-core/disk/geli.c | 7 +-- grub-core/disk/luks.c | 45 + include/grub/cryptodisk.h | 5 +++-- 4 files changed, 63 insertions(+), 16 deletions(-) diff