Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Daniel Kiper
On Thu, Sep 10, 2020 at 12:07:42PM +0200, Javier Martinez Canillas wrote: > On 9/10/20 12:00 AM, Alexey Makhalov wrote: > > [snip] > > > Fixes: 781b3e5efc3 ("tftp: Do not use priority queue") > > Please drop this line. > > >>> > >>> Same question here. I think is important inform

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Javier Martinez Canillas
On 9/10/20 12:00 AM, Alexey Makhalov wrote: [snip] > Fixes: 781b3e5efc3 ("tftp: Do not use priority queue") Please drop this line. >>> >>> Same question here. I think is important information, specially for >>> downstream since they could allow people to decide whether they nee

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-09 Thread Alexey Makhalov
> On Sep 9, 2020, at 4:12 AM, Daniel Kiper wrote: > > Hey Javier, > > On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> Thanks for the review. >> >> On 9/7/20 9:36 PM, Daniel Kiper wrote: >>> On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Marti

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-09 Thread Daniel Kiper
Hey Javier, On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > Thanks for the review. > > On 9/7/20 9:36 PM, Daniel Kiper wrote: > > On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: > >> Commit 781b3e5efc3 ("tftp: Do not use prior

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-09 Thread Javier Martinez Canillas
Hello Daniel, Thanks for the review. On 9/7/20 9:36 PM, Daniel Kiper wrote: > On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: >> Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression > > Please drop the quotes. > Sure, I can do that but I wonder wh

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-07 Thread Daniel Kiper
On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: > Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression Please drop the quotes. > when fetching files over TFTP whose size is bigger than 65535 * block size. > > grub> linux /images/pxeboot/vmlinuz >

[PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-01 Thread Javier Martinez Canillas
Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression when fetching files over TFTP whose size is bigger than 65535 * block size. grub> linux /images/pxeboot/vmlinuz grub> echo $? 0 grub> initrd /images/pxeboot/initrd.img error: timeout reading '/images/pxeboot/initr