Re: [PATCH] sparc64: fix OF path names for sun4v systems

2018-01-29 Thread John Paul Adrian Glaubitz
Hi! On 12/19/2017 10:36 PM, Daniel Kiper wrote: I think that change was suggested by me as the code wouldn't build with -Werror without the initialization. -Werror is the default when building GRUB, if I remember correctly. Eric, if it is true please leave the initialization otherwise drop it.

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2017-12-19 Thread Daniel Kiper
On Mon, Dec 18, 2017 at 11:58:02PM +0100, John Paul Adrian Glaubitz wrote: > On 12/18/2017 10:30 PM, Eric Snowberg wrote: [...] > >>> +static void > >>> +check_hba_identifiers (const char *sysfs_path, int *vendor, int > >>> *device_id) > >>> +{ > >>> + char *ed = strstr (sysfs_path, "host"); >

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2017-12-19 Thread Daniel Kiper
On Mon, Dec 18, 2017 at 02:30:51PM -0700, Eric Snowberg wrote: > > On Dec 18, 2017, at 8:22 AM, Daniel Kiper wrote: > > On Wed, Dec 06, 2017 at 03:53:30PM -0800, Eric Snowberg wrote: > >> Fix the Open Firmware (OF) path property for sun4v SPARC systems. > >> These platforms do not have a /sas/ wit

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2017-12-18 Thread John Paul Adrian Glaubitz
On 12/18/2017 10:30 PM, Eric Snowberg wrote: >> This is not good. It will not work if you cross compile. > > What error do you see on a cross compile? I see __sparc__ used throughout > the code. I agree. This should not cause any issues when cross-compiling, the cross-compiler targeting __$ARC

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2017-12-18 Thread Eric Snowberg
> On Dec 18, 2017, at 8:22 AM, Daniel Kiper wrote: > > On Wed, Dec 06, 2017 at 03:53:30PM -0800, Eric Snowberg wrote: >> Fix the Open Firmware (OF) path property for sun4v SPARC systems. >> These platforms do not have a /sas/ within their path. Over time >> different OF addressing schemes have

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2017-12-18 Thread Daniel Kiper
On Wed, Dec 06, 2017 at 03:53:30PM -0800, Eric Snowberg wrote: > Fix the Open Firmware (OF) path property for sun4v SPARC systems. > These platforms do not have a /sas/ within their path. Over time > different OF addressing schemes have been supported. There > is no generic addressing scheme that

[PATCH] sparc64: fix OF path names for sun4v systems

2017-12-06 Thread Eric Snowberg
Fix the Open Firmware (OF) path property for sun4v SPARC systems. These platforms do not have a /sas/ within their path. Over time different OF addressing schemes have been supported. There is no generic addressing scheme that works across every HBA. Signed-off-by: Eric Snowberg --- grub-core/o

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-17 Thread Eric Snowberg
> On Feb 16, 2016, at 11:45 PM, Seth Goldberg wrote: > > > >> On Feb 16, 2016, at 7:24 PM, Andrei Borzenkov wrote: >> >> 17.02.2016 05:02, Eric Snowberg пишет: >>> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg wro

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-17 Thread Eric Snowberg
> On Feb 16, 2016, at 11:21 PM, Andrei Borzenkov wrote: > > On Wed, Feb 17, 2016 at 6:24 AM, Andrei Borzenkov wrote: >> 17.02.2016 05:02, Eric Snowberg пишет: >>> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg wrote:

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-17 Thread Toomas Soome
> On 17. veebr 2016, at 8:45, Seth Goldberg wrote: >> >> disk0 /pci@308/pci@1/usb@0/hub@1/storage@1/disk@0 > > Devaliases are not guaranteed to be there for all devices. It is highly > dependent on the system vendor to create them and we certainly have systems > with disk drives that have no

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-16 Thread Seth Goldberg
> On Feb 16, 2016, at 7:24 PM, Andrei Borzenkov wrote: > > 17.02.2016 05:02, Eric Snowberg пишет: >> >>> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: >>> >>> On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg >>> wrote: Fix the open firmware path property for sun4v SPARC systems.

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-16 Thread Andrei Borzenkov
On Wed, Feb 17, 2016 at 6:24 AM, Andrei Borzenkov wrote: > 17.02.2016 05:02, Eric Snowberg пишет: >> >>> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: >>> >>> On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg >>> wrote: Fix the open firmware path property for sun4v SPARC systems. These

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-16 Thread Andrei Borzenkov
17.02.2016 05:02, Eric Snowberg пишет: > >> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: >> >> On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg >> wrote: >>> Fix the open firmware path property for sun4v SPARC systems. These >>> platforms do not have a /sas/ within their path. Over time

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-16 Thread Eric Snowberg
> On Feb 16, 2016, at 1:16 AM, Andrei Borzenkov wrote: > > On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg > wrote: >> Fix the open firmware path property for sun4v SPARC systems. These >> platforms do not have a /sas/ within their path. Over time >> different OF addressing schemes have been s

Re: [PATCH] sparc64: fix OF path names for sun4v systems

2016-02-16 Thread Andrei Borzenkov
On Mon, Feb 15, 2016 at 10:11 PM, Eric Snowberg wrote: > Fix the open firmware path property for sun4v SPARC systems. These > platforms do not have a /sas/ within their path. Over time > different OF addressing schemes have been supported. There > is no generic addressing scheme that works across

[PATCH] sparc64: fix OF path names for sun4v systems

2016-02-15 Thread Eric Snowberg
Fix the open firmware path property for sun4v SPARC systems. These platforms do not have a /sas/ within their path. Over time different OF addressing schemes have been supported. There is no generic addressing scheme that works across every HBA. Signed-off-by: Eric Snowberg --- grub-core/osdep/