On Mon, Dec 18, 2017 at 11:58:02PM +0100, John Paul Adrian Glaubitz wrote:
> On 12/18/2017 10:30 PM, Eric Snowberg wrote:

[...]

> >>> +static void
> >>> +check_hba_identifiers (const char *sysfs_path, int *vendor, int 
> >>> *device_id)
> >>> +{
> >>> +  char *ed = strstr (sysfs_path, "host");
> >>> +  size_t path_size;
> >>> +  char *p = NULL, *path = NULL;
> >>
> >> I think that you do not need to initialize *p here.
> >
> > I’ll remove the initialization.
>
> I think that change was suggested by me as the code wouldn't build with
> -Werror without the initialization. -Werror is the default when building
> GRUB, if I remember correctly.

Eric, if it is true please leave the initialization otherwise drop it.

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to