Re: [PATCH] ns8250: Fix incorrect usage of access_size

2023-05-09 Thread Daniel Kiper
On Tue, May 09, 2023 at 01:01:11PM +1000, Benjamin Herrenschmidt wrote: > access_size is part of a union, so doesn't technically exist for a > PIO port (ie, not MMIO), but we set it anyways. > > This doesn't cause a bug today because the other leg of the union > doesn't have anything overlapping wi

[PATCH] ns8250: Fix incorrect usage of access_size

2023-05-08 Thread Benjamin Herrenschmidt
access_size is part of a union, so doesn't technically exist for a PIO port (ie, not MMIO), but we set it anyways. This doesn't cause a bug today because the other leg of the union doesn't have anything overlapping with it now, but it's bad, I will punish myself for writing it that way :-) In the