On Tue, May 09, 2023 at 01:01:11PM +1000, Benjamin Herrenschmidt wrote:
> access_size is part of a union, so doesn't technically exist for a
> PIO port (ie, not MMIO), but we set it anyways.
>
> This doesn't cause a bug today because the other leg of the union
> doesn't have anything overlapping with it now, but it's bad, I will
> punish myself for writing it that way :-) In the meantime, fix this
> and actually name the struct inside the union for clarity of intent
> and to avoid such issue in the future.
>
> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>

Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to