Re: [PATCH] mkdevicemap for Cygwin

2008-05-05 Thread Christian Franke
Marco Gerards wrote: Christian Franke <...> writes: Marco Gerards wrote: Robert Millan <[EMAIL PROTECTED]> writes: It looks fine to me. As far as I am concerned it can be committed. We can even add Christian to savannah so he can commit it. Thanks, my sav

Re: [PATCH] mkdevicemap for Cygwin

2008-04-24 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: > >> Robert Millan <[EMAIL PROTECTED]> writes: >> >>> >>> It looks fine to me. >>> >> >> As far as I am concerned it can be committed. We can even add >> Christian to savannah so he can commit it. >> > > Thanks, my savannah accou

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Christian Franke
Marco Gerards wrote: Robert Millan <[EMAIL PROTECTED]> writes: It looks fine to me. As far as I am concerned it can be committed. We can even add Christian to savannah so he can commit it. Thanks, my savannah account is chrfranke. Christian

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 12:40:27PM +0100, Marco Gerards wrote: >> Christian Franke <[EMAIL PROTECTED]> writes: >> >> > New version of the patch is attached. >> >> [...] >> >> Robert, did you review it again? > > It looks fine to me. As far as I am co

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Robert Millan
On Wed, Jan 23, 2008 at 12:40:27PM +0100, Marco Gerards wrote: > Christian Franke <[EMAIL PROTECTED]> writes: > > > New version of the patch is attached. > > [...] > > Robert, did you review it again? It looks fine to me. -- Robert Millan I know my rights; I want my phone call! What use is

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > New version of the patch is attached. [...] Robert, did you review it again? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] mkdevicemap for Cygwin

2007-12-28 Thread Christian Franke
Robert Millan wrote: On Sun, Nov 18, 2007 at 07:40:15PM +0100, Christian Franke wrote: No, it did not work because check_device() returned 1 ("exists") on (*name == 0). This results in 8 bogus "(hd N)\t\n" lines and wrong N for the real devices. Yes, it would work now, because the patch also

Re: [PATCH] mkdevicemap for Cygwin

2007-12-06 Thread Christian Franke
Robert Millan wrote: > > ... > > Yes, it would work now, because the patch also fixes this bug :-) > > Ok, so in that case you don't need... > > > +#ifndef __CYGWIN__ > > static void > > get_ide_disk_name (char *name, int unit) > > { > > @@ -213,6 +217,7 @@ get_ide_disk_name (char *name, int uni

Re: [PATCH] mkdevicemap for Cygwin

2007-12-06 Thread Robert Millan
On Sun, Nov 18, 2007 at 07:40:15PM +0100, Christian Franke wrote: > > No, it did not work because check_device() returned 1 ("exists") on > (*name == 0). This results in 8 bogus "(hd N)\t\n" lines and wrong N for > the real devices. > > Yes, it would work now, because the patch also fixes this bug

Re: [PATCH] mkdevicemap for Cygwin

2007-11-18 Thread Christian Franke
Marco Gerards wrote: Christian Franke <[EMAIL PROTECTED]> writes: Some changes for grub-mkdevicemap on Cygwin. Christian 2007-11-13 Christian Franke <[EMAIL PROTECTED]> * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin device names. (get_ide_disk_name)

Re: [PATCH] mkdevicemap for Cygwin

2007-11-18 Thread Christian Franke
Robert Millan wrote: On Tue, Nov 13, 2007 at 09:42:26PM +0100, Christian Franke wrote: +#elif defined(__CYGWIN__) + /* Cygwin */ + sprintf (name, "/dev/fd%d", unit); Cygwin has /dev now? :-) At least since 2003. +#ifndef __CYGWIN__ static void get_ide_disk_name (char *nam

Re: [PATCH] mkdevicemap for Cygwin

2007-11-18 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Some changes for grub-mkdevicemap on Cygwin. > > Christian > > 2007-11-13 Christian Franke <[EMAIL PROTECTED]> > > * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin > device names. > (get_ide_disk_name): Disable on __CYG

Re: [PATCH] mkdevicemap for Cygwin

2007-11-17 Thread Robert Millan
On Tue, Nov 13, 2007 at 09:42:26PM +0100, Christian Franke wrote: > +#elif defined(__CYGWIN__) > + /* Cygwin */ > + sprintf (name, "/dev/fd%d", unit); Cygwin has /dev now? :-) > +#ifndef __CYGWIN__ > static void > get_ide_disk_name (char *name, int unit) > { > @@ -213,6 +217,7 @@ get_ide_di

[PATCH] mkdevicemap for Cygwin

2007-11-13 Thread Christian Franke
Some changes for grub-mkdevicemap on Cygwin. Christian 2007-11-13 Christian Franke <[EMAIL PROTECTED]> * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin device names. (get_ide_disk_name): Disable on __CYGWIN__. (get_scsi_disk_name): Add Cygwin device