On Sun, Nov 18, 2007 at 07:40:15PM +0100, Christian Franke wrote:
>
> No, it did not work because check_device() returned 1 ("exists") on
> (*name == 0). This results in 8 bogus "(hd N)\t\n" lines and wrong N for
> the real devices.
>
> Yes, it would work now, because the patch also fixes this bug :-)
Ok, so in that case you don't need...
> +#ifndef __CYGWIN__
> static void
> get_ide_disk_name (char *name, int unit)
> {
> @@ -213,6 +217,7 @@ get_ide_disk_name (char *name, int unit)
> *name = 0;
> #endif
> }
> +#endif /* __CYGWIN__ */
>
> [...]
> +#ifndef __CYGWIN__
> /* IDE disks. */
> for (i = 0; i < 8; i++)
> {
> @@ -431,6 +440,7 @@ make_device_map (const char *device_map,
> num_hd++;
> }
> }
> +#endif /* __CYGWIN__ */
...because you already fixed the problem in:
> - /* If DEVICE is empty, just return 1. */
> + /* If DEVICE is empty, just return error. */
> if (*device == 0)
> - return 1;
> -
> + return 0;
?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
