On Jan 21, 2008 6:21 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
> Hi,
>
> > i finish converting the idct and color code, now it should be ok.
>
> If you are 100% sure all code is yours and there are no legal issues,
> feel free to commit it. Your code looks g
Bean <[EMAIL PROTECTED]> writes:
Hi,
> i finish converting the idct and color code, now it should be ok.
If you are 100% sure all code is yours and there are no legal issues,
feel free to commit it. Your code looks good to me :-)
--
Marco
___
Grub
Hi,
i finish converting the idct and color code, now it should be ok.
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Software Foundation, Inc.
*
* GRUB is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as pu
On Jan 16, 2008 12:01 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> The license state that their README should be distributed together
> with GRUB 2, if I understand it correctly. As you might guess, this
> is not acceptable. Please be careful when using code from other
> projects (or even bette
Bean <[EMAIL PROTECTED]> writes:
[...]
>> Same for the other two lines. With this change, only the legal
>> question remains.
>
> oh, i see.
>
> The IJG's source code:
>
> http://www.ijg.org/files/jpegsrc.v6b.tar.gz
>
> there is a legal issue section in the README file.
The license state that t
On Jan 15, 2008 10:27 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
>
> [...]
>
> >> > for (i = 0; i < cc; i++)
> >> > {
> >> > int id, ss;
> >> >
> >> > id = grub_jpeg_get_byte (data) - 1;
> >> > if ((id < 0) || (id >= 3))
> >> > re
Bean <[EMAIL PROTECTED]> writes:
[...]
>> > for (i = 0; i < cc; i++)
>> > {
>> > int id, ss;
>> >
>> > id = grub_jpeg_get_byte (data) - 1;
>> > if ((id < 0) || (id >= 3))
>> > return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid index");
>> >
>> > ss = gr
Bean <[EMAIL PROTECTED]> writes:
> On Jan 15, 2008 8:46 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> Robert Millan <[EMAIL PROTECTED]> writes:
>>
>> > On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote:
>> >> >>
>> >> >> I do not think these algorithms can be copyrighted and are in t
On Jan 15, 2008 7:01 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> > static grub_err_t
> > grub_jpeg_decode_sof (struct grub_jpeg_data *data)
> > {
> > int i, cc;
> > grub_uint32_t next_marker;
> >
> > next_marker = data->file->offset;
> > next_marker += grub_jpeg_get_word (data);
> >
> >
On Jan 15, 2008 8:46 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Robert Millan <[EMAIL PROTECTED]> writes:
>
> > On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote:
> >> >>
> >> >> I do not think these algorithms can be copyrighted and are in the
> >> >> public domain? Can you check
Robert Millan <[EMAIL PROTECTED]> writes:
> On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote:
>> >>
>> >> I do not think these algorithms can be copyrighted and are in the
>> >> public domain? Can you check this?
>> >
>> > Only actual code can be copyrighted. Algorithms can only be
On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote:
> >>
> >> I do not think these algorithms can be copyrighted and are in the
> >> public domain? Can you check this?
> >
> > Only actual code can be copyrighted. Algorithms can only be patented.
> >
> > Copyright expires into public d
Robert Millan <[EMAIL PROTECTED]> writes:
> On Tue, Jan 15, 2008 at 12:01:47PM +0100, Marco Gerards wrote:
>> Bean <[EMAIL PROTECTED]> writes:
>>
>> > On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> >> > /*
>> >> > * GRUB -- GRand Unified Bootloader
>> >> > * Copyright
On Tue, Jan 15, 2008 at 12:01:47PM +0100, Marco Gerards wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
> > On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> >> > /*
> >> > * GRUB -- GRand Unified Bootloader
> >> > * Copyright (C) 2008 Free Software Foundation, Inc.
> >>
> >>
Bean <[EMAIL PROTECTED]> writes:
> On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> > /*
>> > * GRUB -- GRand Unified Bootloader
>> > * Copyright (C) 2008 Free Software Foundation, Inc.
>>
>> Did you write all the code yourself?
>
> yes, but i take some code segment from
On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> > /*
> > * GRUB -- GRand Unified Bootloader
> > * Copyright (C) 2008 Free Software Foundation, Inc.
>
> Did you write all the code yourself?
yes, but i take some code segment from Independent JPEG Group's
implementation, su
Bean <[EMAIL PROTECTED]> writes:
Hi,
> change the handling of width/height that's not aligned, now it use the
> exact size instead of padding.
You forgot the changelog entry.
I'll do a quick review.
Especially the longjmp stuff should be changed, IMO. Otherwise the
code is of good quality and
Hi,
change the handling of width/height that's not aligned, now it use the
exact size instead of padding.
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Software Foundation, Inc.
*
* GRUB is free software: you can redistribute it and/or modify
* it under the terms of
Hi,
changes in this new version:
handle width/height that's not multiple of 8
add support for 1:1:1 sampling
skip unrecognized marker instead of error.
verify the size of sof, sos, quantization table and huffman table.
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Softwa
On Jan 10, 2008 4:33 AM, Vesa Jääskeläinen <[EMAIL PROTECTED]> wrote:
> Nice job for implementing JPEG. This is the major reason I made the
> bitmap loader interface, to allow other people to write loaders... now
> if we would just have PNG support ;)
This is my next project.
> I know lots of JPE
Bean wrote:
Hi,
I just fix a small bug that can cause color distortion, here is the new patch.
Nice job for implementing JPEG. This is the major reason I made the
bitmap loader interface, to allow other people to write loaders... now
if we would just have PNG support ;)
I will not comment
Hi,
I just fix a small bug that can cause color distortion, here is the new patch.
diff --git a/conf/i386-pc.rmk b/conf/i386-pc.rmk
index a46bc74..4beeeff 100644
--- a/conf/i386-pc.rmk
+++ b/conf/i386-pc.rmk
@@ -136,7 +136,7 @@ pkglib_MODULES = biosdisk.mod _chain.mod
_linux.mod linux.mod normal.
Hi,
this patch handle jpeg image files.
diff --git a/conf/i386-pc.rmk b/conf/i386-pc.rmk
index a46bc74..4beeeff 100644
--- a/conf/i386-pc.rmk
+++ b/conf/i386-pc.rmk
@@ -136,7 +136,7 @@ pkglib_MODULES = biosdisk.mod _chain.mod
_linux.mod linux.mod normal.mod \
_multiboot.mod chain.mod mult
23 matches
Mail list logo
