On Jan 15, 2008 10:27 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
>
> [...]
>
> >> > for (i = 0; i < cc; i++)
> >> > {
> >> > int id, ss;
> >> >
> >> > id = grub_jpeg_get_byte (data) - 1;
> >> > if ((id < 0) || (id >= 3))
> >> > return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid index");
> >> >
> >> > ss = grub_jpeg_get_byte (data); /* sampling factor */
> >> > if (!id)
> >> > {
> >> > data->vs = ss & 0xF; /* vertical sampling */
> >> > data->hs = ss >> 4; /* horizontal sampling */
> >>
> >> Please use correct interpunction.
> >
> > I'm sorry, what do you mean by correct interpunction ?
>
> That I prefer:
>
> /* vertical sampling */ -> /* Vertical sampling. */
>
> Same for the other two lines. With this change, only the legal
> question remains.
oh, i see.
The IJG's source code:
http://www.ijg.org/files/jpegsrc.v6b.tar.gz
there is a legal issue section in the README file.
--
Bean
_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel
