committed
On Fri, Jun 19, 2009 at 8:44 PM, Vladimir 'phcoder'
Serbinenko wrote:
>
>
> On Fri, Jun 19, 2009 at 6:52 PM, Pavel Roskin wrote:
>>
>> OK, I understand you tried USB mass storage devices.
>>
>> I believe the paramount here is consistency. There are several places
>> in the code where g
On Fri, Jun 19, 2009 at 11:47 PM, Pavel Roskin wrote:
> On Fri, 2009-06-19 at 20:44 +0200, Vladimir 'phcoder' Serbinenko wrote:
>
> > I see the standard is grub_error(). Let's do it for SCSI as
> > well.
> >
> > I don't understand what do you mean. grub_error () which don't come
On Fri, 2009-06-19 at 20:44 +0200, Vladimir 'phcoder' Serbinenko wrote:
> I see the standard is grub_error(). Let's do it for SCSI as
> well.
>
> I don't understand what do you mean. grub_error () which don't come
> from previous function
You fixed some code in one place
>
>> I would check why it was needed.
>>
> It seems it's unnecessary. I removed them and it didn't generate any
> warnings. Now I followed your recommendation and they build system with my
> previous fixes picked it right
>
These definitions were used before grub-probe used grub_init_all and
grub_f
On Fri, Jun 19, 2009 at 6:52 PM, Pavel Roskin wrote:
> OK, I understand you tried USB mass storage devices.
>
> I believe the paramount here is consistency. There are several places
> in the code where grub_errno is returned. In one place, grub_error() is
> returned. It's important to fix all
On Fri, 2009-06-19 at 17:54 +0200, Vladimir 'phcoder' Serbinenko wrote:
> I thought it was clear. Here is an explanation hunk by hunk:
> diff --git a/disk/scsi.c b/disk/scsi.c
> index 046dcb8..312d58a 100644
> --- a/disk/scsi.c
> +++ b/disk/scsi.c
> @@ -246,8 +246,9 @@ grub_scsi_open (const char *
On Fri, Jun 19, 2009 at 5:20 PM, Pavel Roskin wrote:
> On Fri, 2009-06-19 at 16:58 +0200, Vladimir 'phcoder' Serbinenko wrote:
> > Hello when testing grub-emu with USB support I stumbled across several
> problems
> > 1) compile time warning of undefined grub_usb_libinit
> > 2) When launched unde
On Fri, 2009-06-19 at 16:58 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello when testing grub-emu with USB support I stumbled across several
> problems
> 1) compile time warning of undefined grub_usb_libinit
> 2) When launched under normal user it crashed
> 3) When launched as superuser it ha
Hello when testing grub-emu with USB support I stumbled across several problems
1) compile time warning of undefined grub_usb_libinit
2) When launched under normal user it crashed
3) When launched as superuser it hanged on ls
Here is the fix. Formatting omitted for readability
--
Regards
Vladimir
