On Fri, Jun 19, 2009 at 11:47 PM, Pavel Roskin <pro...@gnu.org> wrote:
> On Fri, 2009-06-19 at 20:44 +0200, Vladimir 'phcoder' Serbinenko wrote: > > > I see the standard is grub_error(). Let's do it for SCSI as > > well. > > > > I don't understand what do you mean. grub_error () which don't come > > from previous function > > You fixed some code in one place, but it's present in more than one > place in the same function. Please either do it consistently or explain > why it's needed only in one place. > Yes I know, I just haven't paid enough attention. Sorry for this > > Also, I see that .open functions in files under /disk use grub_error() > to communicate errors to the caller. Please explain why you want to do > it differently in scsi.c. > return err is used if err is an error code recieved from another function which has already called grub_error (). It's the same in whole grub > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
