Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-07-01 Thread Robert Millan
On Mon, Jun 29, 2009 at 06:59:22PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-29 at 15:49 +0200, Robert Millan wrote: > > > > Use of a nested function seems totally unwarranted. > > > > I did it to make the code more readable. Declaring functions that will > > be used locally inside their scop

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-29 Thread Pavel Roskin
On Mon, 2009-06-29 at 15:49 +0200, Robert Millan wrote: > > Use of a nested function seems totally unwarranted. > > I did it to make the code more readable. Declaring functions that will > be used locally inside their scope improves code clarity and prevents > mistakes (like attempting to run th

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-29 Thread Pavel Roskin
On Mon, 2009-06-29 at 22:18 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Jun 29, 2009 at 3:49 PM, Robert Millan wrote: > >> We actually agreed > >> a while ago that they are bad, but nobody had time to remove them. > > > > I didn't participate in that discussion. Did Marco and Okuji agree

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-29 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 29, 2009 at 3:49 PM, Robert Millan wrote: >> We actually agreed >> a while ago that they are bad, but nobody had time to remove them. > > I didn't participate in that discussion.  Did Marco and Okuji agree with this? No. It didn't really end in a clear consesus either (partially: everyb

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-29 Thread Robert Millan
On Mon, Jun 29, 2009 at 12:09:16AM -0400, Pavel Roskin wrote: > On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote: > > This patch makes GRUB gather the -boot parameter from CMOS and > > export it as a set of variables (qemu_boot{0,1,2}), which can > > be observed in grub.cfg scripts. > > I th

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-28 Thread Pavel Roskin
On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote: > This patch makes GRUB gather the -boot parameter from CMOS and > export it as a set of variables (qemu_boot{0,1,2}), which can > be observed in grub.cfg scripts. I think qemu constants belong to a separate header. Use of a nested function

[PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-06-27 Thread Robert Millan
This patch makes GRUB gather the -boot parameter from CMOS and export it as a set of variables (qemu_boot{0,1,2}), which can be observed in grub.cfg scripts. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody