Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Here's now the patch Robert requested. > grub_print_error shouldn't use stdout for the utils. > > Why? > > # grub-install /dev/sda > Unknown extra argument `Unsupported'. > > This is with Bean's or mine lastest RAID patch. > /dev/sda isn't on a raid at a

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 12.08.2008, 17:41 +0200 schrieb Robert Millan: >> On Tue, Aug 12, 2008 at 05:30:15PM +0200, Felix Zielcke wrote: >> > >> > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> >> > >> > * kern/err.c [GRUB_UTIL]: Include . >> >

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Felix Zielcke
Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke: > Here's now the patch Robert requested. > grub_print_error shouldn't use stdout for the utils. > > Why? > > # grub-install /dev/sda > Unknown extra argument `Unsupported'. > Ok this is only clear for Bean, Robert and me :) So here

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Felix Zielcke
Am Dienstag, den 12.08.2008, 17:41 +0200 schrieb Robert Millan: > On Tue, Aug 12, 2008 at 05:30:15PM +0200, Felix Zielcke wrote: > > > > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> > > > > * kern/err.c [GRUB_UTIL]: Include . > > (grub_print_error) [GRUB_UTIL]: Use fprintf (std

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Felix Zielcke
Am Dienstag, den 12.08.2008, 18:36 +0300 schrieb Vesa Jääskeläinen: > Felix Zielcke wrote: > > Here's now the patch Robert requested. > > grub_print_error shouldn't use stdout for the utils. > > > +#ifdef GRUB_UTIL > > + fprintf (stderr, "error: %s\n"); > > +#else > > grub_printf ("erro

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Robert Millan
On Tue, Aug 12, 2008 at 05:30:15PM +0200, Felix Zielcke wrote: > > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> > > * kern/err.c [GRUB_UTIL]: Include . > (grub_print_error) [GRUB_UTIL]: Use fprintf (stderr, ...) instead > of > grub_printf. IIRC we usually put the [

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Vesa Jääskeläinen
Felix Zielcke wrote: Here's now the patch Robert requested. grub_print_error shouldn't use stdout for the utils. +#ifdef GRUB_UTIL + fprintf (stderr, "error: %s\n"); +#else grub_printf ("error: %s\n", grub_errmsg); +#endif There is at least bug here _

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Felix Zielcke
Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke: > Here's now the patch Robert requested. > grub_print_error shouldn't use stdout for the utils. > Bah and I attached the broken one not the working one. So please use that one. Index: kern/err.c ===

[PATCH] change grub_print_error to use stderr for the utils

2008-08-12 Thread Felix Zielcke
Here's now the patch Robert requested. grub_print_error shouldn't use stdout for the utils. Why? # grub-install /dev/sda Unknown extra argument `Unsupported'. This is with Bean's or mine lastest RAID patch. /dev/sda isn't on a raid at all. There are 4 disks attached to the VM which have a RAID 6