Here's now the patch Robert requested.
grub_print_error shouldn't use stdout for the utils.

Why?

# grub-install /dev/sda
Unknown extra argument `Unsupported'.

This is with Bean's or mine lastest RAID patch.
/dev/sda isn't on a raid at all.
There are 4 disks attached to the VM which have a RAID 6 on it.
But the RAID 6 isn't even assembled, i.e. /proc/mdstat says nothing.

As always, the changelog isn't probable that perfect for you, so please comment 
:)

2008-08-12  Felix Zielcke <[EMAIL PROTECTED]>

        * kern/err.c [GRUB_UTIL]: Include <stdio.h>.
          (grub_print_error) [GRUB_UTIL]: Use fprintf (stderr, ...) instead of 
          grub_printf.

Index: kern/err.c
===================================================================
--- kern/err.c	(revision 1800)
+++ kern/err.c	(working copy)
@@ -21,6 +21,9 @@
 #include <grub/misc.h>
 #include <stdarg.h>
 
+#ifdef GRUB_UTIL
+#include <stdio.h>
+#endif
 #define GRUB_MAX_ERRMSG		256
 #define GRUB_ERROR_STACK_SIZE	10
 
@@ -121,7 +124,11 @@
   do
     {
       if (grub_errno != GRUB_ERR_NONE)
+#ifdef GRUB_UTIL
+	fprintf (stderr, "error: %s\n");
+#else
         grub_printf ("error: %s\n", grub_errmsg);
+#endif
     } 
   while (grub_error_pop ());
   
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to