Re: [PATCH] add clear screen command

2009-04-09 Thread Manoel Rebelo Abranches
On Thu, 2009-04-09 at 15:44 +0200, phcoder wrote: > Carlos Roberto do Nascimento Costa wrote: > > Hello phcoder. thank you for reviewing this patch. > You're welcome > > > > phcoder wrote: > >> Perhaps putting it into normal.mod instead of separate module is a good > >> idea > > > > When I did th

Re: [PATCH] add clear screen command

2009-04-09 Thread phcoder
Carlos Roberto do Nascimento Costa wrote: Hello phcoder. thank you for reviewing this patch. You're welcome phcoder wrote: Perhaps putting it into normal.mod instead of separate module is a good idea When I did this patch, I was thinking: clear is a command like ls, lspci, reboot, sleep, su

Re: [PATCH] add clear screen command

2009-04-08 Thread Carlos Roberto do Nascimento Costa
Hello phcoder. thank you for reviewing this patch. phcoder wrote: > Perhaps putting it into normal.mod instead of separate module is a good > idea When I did this patch, I was thinking: clear is a command like ls, lspci, reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at commands

Re: [PATCH] add clear screen command

2009-04-08 Thread phcoder
Carlos Roberto do Nascimento Costa wrote: + (void)mod; /* To stop warning. */ + cmd = grub_register_command ("clear", grub_cmd_clear, + 0, "Clear the terminal screen."); I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'. Yes, you are right. gru

Re: [PATCH] add clear screen command

2009-04-08 Thread Carlos Roberto do Nascimento Costa
Hi Felix, thank you for reviewing this patch. Felix Zielcke wrote: > Hello, > > + * Copyright (C) 2003,2007 Free Software Foundation, Inc. > + * Copyright (C) 2003 NIIBE Yutaka > > This should be just `Copyright (C) 2009 Free Software Foundation, Inc.', > because it's a new file from this

Re: [PATCH] add clear screen command

2009-04-08 Thread phcoder
Perhaps putting it into normal.mod instead of separate module is a good idea Felix Zielcke wrote: Am Mittwoch, den 08.04.2009, 16:04 -0300 schrieb Carlos Roberto do Nascimento Costa: Hello, This simple patch will add a new command to clear the terminal screen. Very useful on the command-line.

Re: [PATCH] add clear screen command

2009-04-08 Thread Felix Zielcke
Am Mittwoch, den 08.04.2009, 16:04 -0300 schrieb Carlos Roberto do Nascimento Costa: > Hello, > > This simple patch will add a new command to clear the terminal screen. Very > useful on the command-line. > Hello, + * Copyright (C) 2003,2007 Free Software Foundation, Inc. + * Copyright (C) 20

[PATCH] add clear screen command

2009-04-08 Thread Carlos Roberto do Nascimento Costa
Hello, This simple patch will add a new command to clear the terminal screen. Very useful on the command-line. Best Regards, -- Carlos Roberto do Nascimento Costa e-mail: crnco...@linux.vnet.ibm.com IBM - Linux Technology Center Brasil Index: conf/common.rmk