Carlos Roberto do Nascimento Costa wrote:
Hello phcoder. thank you for reviewing this patch.
You're welcome

phcoder wrote:
Perhaps putting it into normal.mod instead of separate module is a good
idea

When I did this patch, I was thinking: clear is a command like ls, lspci,
reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at commands/
dir and follows the same ideas behind other commands.

Is there any reason to not follows this idea?

With your patch the created elf contains much more overhead then code. While it isn't really a problem it's still a thing about which some thinking is needed
Best regards,



--

Regards
Vladimir 'phcoder' Serbinenko


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to