Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-26 Thread Pavel Roskin
On Sat, 2009-06-27 at 11:44 +0800, Bean wrote: > Oh, actually aa: aa.o is already a ruby generated rule, it doesn't > exist in rmk file. The original line from rmk would be something like > this: > > aa_SOURCES += aa.c I see. Sorry for the noise. -- Regards, Pavel Roskin ___

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-26 Thread Bean
On Sat, Jun 27, 2009 at 6:32 AM, Pavel Roskin wrote: > On Fri, 2009-06-26 at 11:13 +0800, Bean wrote: >> On Fri, Jun 26, 2009 at 3:31 AM, Pavel Roskin wrote: > >> > While at that, it would be nice to use a special notation for the >> > partial dependencies. >> > >> > Something like: >> > >> > aa:+

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-26 Thread Pavel Roskin
On Fri, 2009-06-26 at 11:13 +0800, Bean wrote: > On Fri, Jun 26, 2009 at 3:31 AM, Pavel Roskin wrote: > > While at that, it would be nice to use a special notation for the > > partial dependencies. > > > > Something like: > > > > aa:+ aa.o > > aa:+ bb.o > > Hi, > > Is this new syntax for GNU mak

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-25 Thread Bean
On Fri, Jun 26, 2009 at 3:31 AM, Pavel Roskin wrote: > On Wed, 2009-06-24 at 20:13 +0800, Bean wrote: > >> You can use = or +=, actually the macro is used by genmk.rb to >> generate the rules, it's not used by Makefile itself, so no problem >> overriding it. > > While at that, it would be nice to u

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-25 Thread Pavel Roskin
On Wed, 2009-06-24 at 20:13 +0800, Bean wrote: > You can use = or +=, actually the macro is used by genmk.rb to > generate the rules, it's not used by Makefile itself, so no problem > overriding it. While at that, it would be nice to use a special notation for the partial dependencies. Something

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
On Thu, Jun 25, 2009 at 4:07 AM, Vladimir 'phcoder' Serbinenko wrote: > Sory for not being present last few days - I split my time between non-grub > things and making zfs work welll in grub2 (I'm already able to boot FreeBSD > off ZFS with branch I have in my personal repo) >> >> Hi, >> >> You can

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 08:13:35PM +0800, Bean wrote: > >> +bin_UTILITIES += grub-mkelfimage > >> +grub_mkelfimage_SOURCES = util/resolve.c > >> + > >>  pkglib_MODULES += cpuid.mod > >>  cpuid_mod_SOURCES = commands/i386/cpuid.c > >>  cpuid_mod_CFLAGS = $(COMMON_CFLAGS) > > > > This looks very conf

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Vladimir 'phcoder' Serbinenko
Sory for not being present last few days - I split my time between non-grub things and making zfs work welll in grub2 (I'm already able to boot FreeBSD off ZFS with branch I have in my personal repo) > > Hi, > > You can use = or +=, actually the macro is used by genmk.rb to > generate the rules, i

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
On Wed, Jun 24, 2009 at 8:06 PM, Robert Millan wrote: > On Wed, Jun 24, 2009 at 04:52:26PM +0800, Bean wrote: >> diff --git a/conf/common.rmk b/conf/common.rmk >> index dc78df9..3402faf 100644 >> --- a/conf/common.rmk >> +++ b/conf/common.rmk >> @@ -2,8 +2,9 @@ >> >>  # For grub-mkelfimage. >>  bin

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 04:52:26PM +0800, Bean wrote: > diff --git a/conf/common.rmk b/conf/common.rmk > index dc78df9..3402faf 100644 > --- a/conf/common.rmk > +++ b/conf/common.rmk > @@ -2,8 +2,9 @@ > > # For grub-mkelfimage. > bin_UTILITIES += grub-mkelfimage > -grub_mkelfimage_SOURCES = util

[PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
Hi, In the current build system, all source files to build an executable must reside in a single rmk file, this makes it difficult to break down the build system in more logical blocks. This patch fixes this by utilizing some tricks of GNU make. First, you can specify the dependence of target in