Re: [PATCH] Support for OSX (replace the old one)

2009-07-20 Thread Pavel Roskin
On Sun, 2009-07-19 at 12:46 +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > > The only problem remaining is trampoline (nested functions), because > OSX don't want > to execute code in the heap. > > This patch is a rewriting of the last

[PATCH] Support for OSX (replace the old one)

2009-07-19 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. This patch is a rewriting of the last patch with good identation and no misleading variables. Best Regards

[PATCH] Support for OSX (replace the old one)

2009-07-19 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. This patch is a rewriting of the last patch with good identation and no misleading variables. Best Regards

Re: [PATCH] Support for OSX

2009-07-18 Thread Robert Millan
On Thu, Jul 16, 2009 at 07:45:44PM +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > > The only problem remaining is trampoline (nested functions), because OSX > don't want > to execute code in the heap. Hi, I have some comments (some of the

Re: [PATCH] Support for OSX

2009-07-16 Thread Yves Blusseau
Le 16 juil. 09 à 21:19, Pavel Roskin a écrit : On Thu, 2009-07-16 at 19:45 +0200, Yves Blusseau wrote: Hi, here's a patch so grub-setup can be compiled and work on MacOSX. # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) if (ioctl (fd, DIOCGMEDIASIZE, &nr)) +# elif defined(__AP

Re: [PATCH] Support for OSX

2009-07-16 Thread Pavel Roskin
On Thu, 2009-07-16 at 19:45 +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > if (ioctl (fd, DIOCGMEDIASIZE, &nr)) > +# elif defined(__APPLE__) > + if (ioctl (fd, DKIOCGET

Re: [PATCH] Support for OSX

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
Hello On Thu, Jul 16, 2009 at 7:45 PM, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > There are stylistic problems with your patch. For the overview of our style see http://www.gnu.org/prep/standards/ Your tabulations are wrong. Use emacs (recomme

[PATCH] Support for OSX

2009-07-16 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. Best Regards Yves Blusseau osx_support.diff Description: Binary data __