Re: [PATCH] Split of raid scan code

2008-08-23 Thread Bean
On Tue, Aug 19, 2008 at 1:20 AM, Bean <[EMAIL PROTECTED]> wrote: > Hi, > > This patch fix a bug in total_devs and grub_raid_memberlist, it also > resolve the conflict with current svn head. Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gn

Re: [PATCH] Split of raid scan code

2008-08-17 Thread Robert Millan
On Sun, Aug 17, 2008 at 11:08:07PM +0800, Bean wrote: > >> > >> grub-probe don't use the recover module, so if it have problem at > >> install time, user would know about it (error message would be > >> "raid5rec not loaded"). > > > > Sounds fine to me. But the error message is too cryptic IMHO.

Re: [PATCH] Split of raid scan code

2008-08-17 Thread Bean
On Sun, Aug 17, 2008 at 10:52 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Aug 16, 2008 at 11:20:04PM +0800, Bean wrote: >> On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: >> >> Hi, >> >> >> >> This new p

Re: [PATCH] Split of raid scan code

2008-08-17 Thread Robert Millan
On Sat, Aug 16, 2008 at 11:20:04PM +0800, Bean wrote: > On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: > >> Hi, > >> > >> This new patch seperates raid5 and raid6 recover code from raid.c, and > >> place them in mo

Re: [PATCH] Split of raid scan code

2008-08-16 Thread Bean
On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: >> Hi, >> >> This new patch seperates raid5 and raid6 recover code from raid.c, and >> place them in module raid5rec.mod and raid6rec.mod. The recover code >> is only ne

Re: [PATCH] Split of raid scan code

2008-08-16 Thread Robert Millan
On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: > Hi, > > This new patch seperates raid5 and raid6 recover code from raid.c, and > place them in module raid5rec.mod and raid6rec.mod. The recover code > is only needed when some of the disk are missing or corrupted, which > is not common. But

Re: [PATCH] Split of raid scan code

2008-08-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 4:30 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> On Tue, Aug 12, 2008 at 04:24:26AM +0800, Bean wrote: >>> - disk/lvm.c disk/raid.c grub_probe_init.c >>> + disk/lvm.c disk/raid.c disk/mdraid_linux.c grub_probe_init.c >> >> Hi,

Re: [PATCH] Split of raid scan code

2008-08-12 Thread Robert Millan
On Tue, Aug 12, 2008 at 07:49:19PM +0800, Bean wrote: > > Ok, I make some adjustment, now grub-install & update-grub works for > raid device. > [...] > --- a/util/grub-probe.c > +++ b/util/grub-probe.c > @@ -142,7 +142,7 @@ probe (const char *path, char *device_name) > abstraction_name = "

Re: [PATCH] Split of raid scan code

2008-08-12 Thread Felix Zielcke
Am Dienstag, den 12.08.2008, 19:49 +0800 schrieb Bean: > Hi, > > Ok, I make some adjustment, now grub-install & update-grub works for > raid device. > > If no one objects, I'd commit this soon. > Before your mail came in, I just talked with Robert about the fixes which I'd like to have in lenny

Re: [PATCH] Split of raid scan code

2008-08-11 Thread Robert Millan
On Tue, Aug 12, 2008 at 04:24:26AM +0800, Bean wrote: > - disk/lvm.c disk/raid.c grub_probe_init.c > + disk/lvm.c disk/raid.c disk/mdraid_linux.c grub_probe_init.c Hi, I haven't tried, but I think this module split would break grub-install & update-grub. Please check those out before com

Re: [PATCH] Split of raid scan code

2008-08-10 Thread Bean
On Sun, Aug 10, 2008 at 10:29 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sun, Aug 10, 2008 at 07:52:22PM +0800, Bean wrote: >> kern/partition.c partmap/pc.c partmap/apple.c partmap/gpt.c \ >> kern/fs.c kern/env.c fs/fshelp.c disk/lvm.c disk/raid.c \ >> + disk/mdraid.c \ >

Re: [PATCH] Split of raid scan code

2008-08-10 Thread Robert Millan
On Sun, Aug 10, 2008 at 07:52:22PM +0800, Bean wrote: > kern/partition.c partmap/pc.c partmap/apple.c partmap/gpt.c \ > kern/fs.c kern/env.c fs/fshelp.c disk/lvm.c disk/raid.c \ > + disk/mdraid.c \ Perhaps it'd be a good idea to take the opportunity to add a "linux" prefix ther

Re: [PATCH] Split of raid scan code

2008-08-10 Thread Felix Zielcke
Am Sonntag, den 10.08.2008, 19:52 +0800 schrieb Bean: > Hi, > > This patch seperate the scan code from raid.c, and move it to > mdraid.c. raid.c only contain generic raid handling code now. This > make it much easier to extend to other raid layout, like various > fakeraids. > Really great that y

[PATCH] Split of raid scan code

2008-08-10 Thread Bean
Hi, This patch seperate the scan code from raid.c, and move it to mdraid.c. raid.c only contain generic raid handling code now. This make it much easier to extend to other raid layout, like various fakeraids. I also extend the function of grub-fstest so that it can be used to debug raid, for exam