On Sun, Aug 17, 2008 at 10:52 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Aug 16, 2008 at 11:20:04PM +0800, Bean wrote: >> On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: >> >> Hi, >> >> >> >> This new patch seperates raid5 and raid6 recover code from raid.c, and >> >> place them in module raid5rec.mod and raid6rec.mod. The recover code >> >> is only needed when some of the disk are missing or corrupted, which >> >> is not common. But raid.c is installed to mbr, so size is important. >> >> If there is enough room in mbr for the extra module, they can use >> >> --modules option in grub-install to add these modules. >> > >> > I find this scary in the sense that users need to know about these modules >> > to get the benefit of recovery, and even then, they also need to know they >> > are affected by this problem when they install GRUB (since otherwise they >> > won't be able to bootstrap). >> > >> > Is it possible to detect whether recover code will be needed when >> > grub-install >> > is run, and then either add the extra modules or abort with an error? >> >> Hi, >> >> grub-probe don't use the recover module, so if it have problem at >> install time, user would know about it (error message would be >> "raid5rec not loaded"). > > Sounds fine to me. But the error message is too cryptic IMHO. Consider the > situation in which user was running grub-install and sees this error. > Shouldn't we tell her to fix the RAID instead?
Hi, How about "please load raid5rec.mod to enable raid5 recovery" ? -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
