Re: [PATCH] Remove root drive support

2009-06-19 Thread Robert Millan
On Tue, Jun 16, 2009 at 01:41:18AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Fri, Jun 12, 2009 at 10:45 PM, Pavel Roskin wrote: > > Root drive support is not actually used by the installer.  Root drive is > > superseded by grub_prefix with UUID, which is much more flexible, is > > already us

Re: [PATCH] Remove root drive support

2009-06-18 Thread Pavel Roskin
On Thu, 2009-06-18 at 18:57 +0200, Vladimir 'phcoder' Serbinenko wrote: > Update copyright year. Done. > I suggest putting new id in grub_disk_dev_id to the end. Done. Actually, using modules compiled from different sources is asking for trouble, but it's not like this list is well sorted now.

Re: [PATCH] Remove root drive support

2009-06-18 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 16, 2009 at 8:09 PM, Pavel Roskin wrote: > On Tue, 2009-06-16 at 12:30 +0200, Vladimir 'phcoder' Serbinenko wrote: > > > I think we could implement partition addressing by a contained > > filename. > > As long as GRUB can read the filesystem at all, it should b

Re: [PATCH] Remove root drive support

2009-06-16 Thread Pavel Roskin
On Tue, 2009-06-16 at 12:30 +0200, Vladimir 'phcoder' Serbinenko wrote: > I think we could implement partition addressing by a contained > filename. > As long as GRUB can read the filesystem at all, it should be > able to > read filenames. > Otherwise the fi

Re: [PATCH] Remove root drive support

2009-06-16 Thread Vladimir 'phcoder' Serbinenko
Hello On Tue, Jun 16, 2009 at 2:15 AM, Pavel Roskin wrote: > On Tue, 2009-06-16 at 01:41 +0200, Vladimir 'phcoder' Serbinenko wrote: > > > I successfully tested this patch in qemu with both grub-mkrescue and > > multiboot load grub2-by-grub2. As I see root drive was always set to > > 0xFF and so

Re: [PATCH] Remove root drive support

2009-06-15 Thread Pavel Roskin
On Tue, 2009-06-16 at 01:41 +0200, Vladimir 'phcoder' Serbinenko wrote: > I successfully tested this patch in qemu with both grub-mkrescue and > multiboot load grub2-by-grub2. As I see root drive was always set to > 0xFF and so this field is useless and as it's in size-critical part. > However rea

Re: [PATCH] Remove root drive support

2009-06-15 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jun 12, 2009 at 10:45 PM, Pavel Roskin wrote: > Root drive support is not actually used by the installer.  Root drive is > superseded by grub_prefix with UUID, which is much more flexible, is > already used by grub-setup for cross-drive installs and doesn't require > a single byte in the bo

[PATCH] Remove root drive support

2009-06-12 Thread Pavel Roskin
Root drive support is not actually used by the installer. Root drive is superseded by grub_prefix with UUID, which is much more flexible, is already used by grub-setup for cross-drive installs and doesn't require a single byte in the boot sector. ChangeLog: * boot/i386/pc/boot.S: Remove r