On Thu, 2009-06-18 at 18:57 +0200, Vladimir 'phcoder' Serbinenko wrote: > Update copyright year.
Done. > I suggest putting new id in grub_disk_dev_id to the end. Done. Actually, using modules compiled from different sources is asking for trouble, but it's not like this list is well sorted now. > You also forgot to add it to grub-emu. Actually, I didn't add it because fs_uuid.c is not compiled for grub-emu. If you want, you can add them both. > Under qemu it worked well except that it wasn't autoloaded but I > looked and seen that we have no module autoloading for device drivers, > perhaps because some of them don't coexist well. We'll need a list of drive names with corresponding modules, something like: hd: biosdisk fd: biosdisk FILE=: fs_file UUID=: fs_uuid ata: ata It's true that autoloading of ata may break biosdisk. But nobody is forces to use ata devices on the command line. but it is becomes an issue, ata could be excluded from that list. > Except issues mentioned patch looks fine and I think you can commit it > even if we don't have userspace part yet Committed. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
