On 10/19/2010 11:17 AM, BVK Chaitanya wrote:
> How about the attached patch?
>
> It introduces new library libemu.a (in addition to libgrub.a) with
> sources that need gnulib headers. IMO correct thing to do is, fixing
> stdio.in.h to make getline a function instead of a macro, if everybody
> agre
On 10/19/2010 11:17, BVK Chaitanya wrote:
How about the attached patch?
The patch fixes the problem. With the patch, grub trunk builds fine
on NetBSD 5.
Thanks,
Grégoire
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/li
How about the attached patch?
It introduces new library libemu.a (in addition to libgrub.a) with
sources that need gnulib headers. IMO correct thing to do is, fixing
stdio.in.h to make getline a function instead of a macro, if everybody
agrees, I will raise a bug report to gnulib project?
bvk
On 09/24/2010 12:18, Colin Watson wrote:
This looks good to me as far as it goes, but doesn't it need a bit more?
I guess we should not rename the actual calls to the getline() library
function (otherwise gnulib's replacement won't help). And I personally
don't mind if function arguments and
On Thu, Sep 23, 2010 at 01:36:48PM +0200, Grégoire Sutre wrote:
> The attached patch simply renames this field by `getnewline'.
This looks good to me as far as it goes, but doesn't it need a bit more?
grub-core/commands/legacycfg.c:44: auto grub_err_t getline (char **line, int
cont);
grub-core/
Hi,
On NetBSD 5, the latest trunk does not build:
$ ./autogen.sh ; ./configure CFLAGS='-std=gnu99' ; gmake
[...]
gcc -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\"/usr/local/lib/grub\"
-DLOCALEDIR=\"/usr/local/share/locale\" -DGRUB_MACHINE_PCBIOS=1
-DGRUB_MACHINE=I3