On 09/24/2010 12:18, Colin Watson wrote:

This looks good to me as far as it goes, but doesn't it need a bit more?

I guess we should not rename the actual calls to the getline() library
function (otherwise gnulib's replacement won't help).  And I personally
don't mind if function arguments and local variables are substituted.

But I agree that, in general, it would be safer to avoid names that
might be inadvertently replaced by gnulib's #defines.

Grégoire


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to