Re: [PATCH] Environment block support for grub2

2008-06-14 Thread Bean
On Sun, Jun 15, 2008 at 2:32 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jun 14, 2008 at 11:41:18AM +0800, Bean wrote: >> >> Hi, >> >> No problem, I can find another name. > > Sorry, my mistake. I complained about $root being inappropiate for early > stage use, but after that I noticed

Re: [PATCH] Environment block support for grub2

2008-06-14 Thread Robert Millan
On Sat, Jun 14, 2008 at 11:41:18AM +0800, Bean wrote: > > Hi, > > No problem, I can find another name. Sorry, my mistake. I complained about $root being inappropiate for early stage use, but after that I noticed that $root is used in every stage to refer to "whatever drive we're currently acces

Re: [PATCH] Environment block support for grub2

2008-06-13 Thread Bean
On Sat, Jun 14, 2008 at 6:48 AM, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > On Saturday 31 May 2008 17:21:25 Robert Millan wrote: >> On Sat, May 31, 2008 at 08:09:50PM +0800, Bean wrote: >> > On Sat, May 31, 2008 at 7:39 PM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > > I think the method is

Re: [PATCH] Environment block support for grub2

2008-06-13 Thread Yoshinori K. Okuji
On Saturday 31 May 2008 17:21:25 Robert Millan wrote: > On Sat, May 31, 2008 at 08:09:50PM +0800, Bean wrote: > > On Sat, May 31, 2008 at 7:39 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > I think the method is sound; what I'm complaining about (and it's not > > > something specific to your p

Re: UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-08 Thread Robert Millan
On Sat, Jun 07, 2008 at 12:33:47PM +0800, Bean wrote: > > Hi, > > I find the post: > > http://lists.gnu.org/archive/html/grub-devel/2008-02/msg00542.html I completely agree. The patch I sent makes it rely on UUIDs unconditionaly because it was just a proof of concept, but my intention is to on

Re: [PATCH] ntfs UUIDs (Re: UUID-based boot (Re: [PATCH] Environment block support for grub2))

2008-06-08 Thread Robert Millan
On Sat, Jun 07, 2008 at 11:34:39PM -0400, Pavel Roskin wrote: > On Sat, 2008-06-07 at 07:44 +0200, Tomáš Ebenlendr wrote: > > Dne 7 Červen 2008, 01:31, Robert Millan napsal(a): > > > This patch adds the 64-bit serial number as UUID. But I'm not sure what > > > is the "standard" method to stringify

Re: [PATCH] ntfs UUIDs (Re: UUID-based boot (Re: [PATCH] Environment block support for grub2))

2008-06-07 Thread Pavel Roskin
On Sat, 2008-06-07 at 07:44 +0200, Tomáš Ebenlendr wrote: > Dne 7 Červen 2008, 01:31, Robert Millan napsal(a): > > This patch adds the 64-bit serial number as UUID. But I'm not sure what > > is the "standard" method to stringify this number. Apparently, Windows > > only prints half of it in the d

Re: UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-07 Thread Vesa Jääskeläinen
Robert Millan wrote: On Sat, Jun 07, 2008 at 01:22:23AM +0800, Bean wrote: On Sat, Jun 7, 2008 at 12:43 AM, Robert Millan <[EMAIL PROTECTED]> wrote: Sorry for the delay; it was quite a bit of work as I got hit by a number of bugs here and there :-) Considering that the problem was quite simila

Re: [PATCH] ntfs UUIDs (Re: UUID-based boot (Re: [PATCH] Environment block support for grub2))

2008-06-06 Thread Tomáš Ebenlendr
Dne 7 Červen 2008, 01:31, Robert Millan napsal(a): > This patch adds the 64-bit serial number as UUID. But I'm not sure what > is the "standard" method to stringify this number. Apparently, Windows > only prints half of it in the dir command. That seems to me as some backward (pronounce: awkwar

Re: UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-06 Thread Bean
On Sat, Jun 7, 2008 at 6:03 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jun 07, 2008 at 01:22:23AM +0800, Bean wrote: >> On Sat, Jun 7, 2008 at 12:43 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > Sorry for the delay; it was quite a bit of work as I got hit by a number of >> > bugs he

[PATCH] ntfs UUIDs (Re: UUID-based boot (Re: [PATCH] Environment block support for grub2))

2008-06-06 Thread Robert Millan
On Sat, Jun 07, 2008 at 01:22:23AM +0800, Bean wrote: > > Then for the Vista use case, I suppose the remaining questions are if NTFS > > supports UUIDs (or otherwise we have to ressort to labels?), and if we can > > extract filesystem metadata from Windows (if possible without requiring that > > a

Re: UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-06 Thread Robert Millan
On Sat, Jun 07, 2008 at 01:22:23AM +0800, Bean wrote: > On Sat, Jun 7, 2008 at 12:43 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > Sorry for the delay; it was quite a bit of work as I got hit by a number of > > bugs here and there :-) > > > > Considering that the problem was quite similar to the

Re: UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-06 Thread Bean
On Sat, Jun 7, 2008 at 12:43 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > Sorry for the delay; it was quite a bit of work as I got hit by a number of > bugs here and there :-) > > Considering that the problem was quite similar to the "boot from LVM" issue > we already knew about, I thought it'd b

UUID-based boot (Re: [PATCH] Environment block support for grub2)

2008-06-06 Thread Robert Millan
On Wed, Jun 04, 2008 at 11:49:14AM +0800, Bean wrote: > On Wed, Jun 4, 2008 at 5:09 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > > I've been thinking a bit more about this, and I think it should be > > possible to solve the problem at hand without extending the existing > > framework. I'm co

Re: [PATCH] Environment block support for grub2

2008-06-03 Thread Bean
On Wed, Jun 4, 2008 at 5:09 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > I've been thinking a bit more about this, and I think it should be > possible to solve the problem at hand without extending the existing > framework. I'm concerned about finding a solution that is as simple > (and small)

Re: [PATCH] Environment block support for grub2

2008-06-03 Thread Robert Millan
I've been thinking a bit more about this, and I think it should be possible to solve the problem at hand without extending the existing framework. I'm concerned about finding a solution that is as simple (and small) as possible. Do you mind waiting a few days? I'll send a proposal tomorrow or s

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Robert Millan
On Sat, May 31, 2008 at 08:09:50PM +0800, Bean wrote: > On Sat, May 31, 2008 at 7:39 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > > I think the method is sound; what I'm complaining about (and it's not > > something specific to your patch) is that we're referring to two different > > things

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Bean
Hi, This is the new patch, it contain the following changes: 1. command edit -> set in grub-editenv, as it seems more natural. grub-editenv FILE set name=value ... 2. findroot can locate the root device using filename. To use it, just set idfile to any file inside the directory, For example: i

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Bean
On Sat, May 31, 2008 at 7:39 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > I think the method is sound; what I'm complaining about (and it's not > something specific to your patch) is that we're referring to two different > things by the same name ("root"), and even put them in the same variabl

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Robert Millan
On Sat, May 31, 2008 at 06:54:43PM +0800, Bean wrote: > > The root is assigned in the initialization phraze. Currently, it's > done this way: > > machine_machine_init -> calculate root device, then set variable > prefix using root and grub_prefix. > > modules initialization > > grub_set_root_de

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Bean
On Sat, May 31, 2008 at 6:10 PM, Robert Millan <[EMAIL PROTECTED]> wrote: >> Different platform use grub_machine_get_envblk to return a pointer to >> the name=value area of environment block. In main.c, it uses >> grub_parse_envblk to walk through the list and assign values to >> variables. >> >> I

Re: [PATCH] Environment block support for grub2

2008-05-31 Thread Robert Millan
On Sat, May 31, 2008 at 04:27:31AM +0800, Bean wrote: > Hi, > > This patch add environment block support, which can be used to locate > root device using uuid or label. Nice :-) > The previous prefix is stored in variable rdir. Do we need this? > Different platform use grub_machine_get_envblk

[PATCH] Environment block support for grub2

2008-05-30 Thread Bean
Hi, This patch add environment block support, which can be used to locate root device using uuid or label. The environment block occupied the space previously used to store prefix. The structure is like this: Magic numbe: "EvbK" (4 bytes) Length of environment block (2 bytes) null-ended name=val