Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-26 Thread 段亚勇 via Grub-devel
ed, Feb 26, 2025, 21:39 Subject: Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc To: "段亚勇" Cc: , , < jinke@bytedance.com>, , < likunkun@bytedance.com>, "Li Yongqiang", "Sun Ming" On Tue, Feb 25, 2025 at 07:19:58PM -0800

Re: [PATCH] Bugfix: grub menu gets stuck

2025-02-26 Thread Daniel Kiper
On Thu, Nov 28, 2024 at 11:48:26AM +0800, Duan Yayong via Grub-devel wrote: > Adding "if (grub_tsc_rate == 0)" judgement just in case other unknown > instruction exception, so that > "grub_tsc_calibrate_from_pit||grub_tsc_calibrate_from_efi" getting > "grub_tsc_rate" methods have a opportunity to b

Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-26 Thread Daniel Kiper
On Tue, Feb 25, 2025 at 07:19:58PM -0800, 段亚勇 via Grub-devel wrote: > Hi,  > > That's alright! > May I know if the first patch is allowed to be merged? And how long will it be > merged approximately? > So that I can track it after that time! Thanks! Sorry, I thought the first patch is earlier vers

Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-25 Thread 段亚勇 via Grub-devel
, T2B, Xinjiangwan Square, Yangpu District, Shanghai --- From: "Daniel Kiper" Date: Tue, Feb 25, 2025, 23:35 Subject: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc To: "段亚勇" Cc: , ,

Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-25 Thread Daniel Kiper
Hi, On Mon, Feb 24, 2025 at 10:41:38PM -0800, 段亚勇 wrote: > Hello Daniel, > May I know the Merge Plan of Grub Master branch?  > From this time, we almost check grub master changes every day > and take enough patience to wait for the bugfix to be merged. > But we found the recent update of master br

Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-24 Thread 段亚勇 via Grub-devel
-- Best Regards, 段亚勇 Data-SYS-STE-操作系统 上海市杨浦区抖音新江湾广场 T2B 3F --- From: "Daniel Kiper" Date: Fri, Dec 20, 2024, 03:49 Subject: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc T

Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-01-07 Thread 段亚勇 via Grub-devel
--- Best Regards, 段亚勇 Data-SYS-STE-操作系统 上海市杨浦区抖音新江湾广场 T2B 3F --- From: "Daniel Kiper" Date: Fri, Dec 20, 2024, 03:49 Subject: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc To:

Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2024-12-20 Thread 段亚勇 via Grub-devel
49 Subject: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc To: "Duan Yayong" Cc: , , < jinke@bytedance.com>, , < likunkun@bytedance.com>, "Li Yongqiang", "Sun Ming" On Mon, Dec 09, 2024 at 02:48:32PM +0800, Duan Yayong wrote:

Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2024-12-19 Thread Daniel Kiper
On Mon, Dec 09, 2024 at 02:48:32PM +0800, Duan Yayong wrote: > This patch is used to fix grub menu gets stuck in server > AC poweron/poweroff stress test of x86_64, which is reproduced with 1/200 > ratio. The root cause analysis as below: > > Q: > What's the code logic? > A: > "grub_tsc_init" funct

[PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2024-12-08 Thread Duan Yayong via Grub-devel
This patch is used to fix grub menu gets stuck in server AC poweron/poweroff stress test of x86_64, which is reproduced with 1/200 ratio. The root cause analysis as below: Q: What's the code logic? A: "grub_tsc_init" function will init tsc by setting grub_tsc_rate, which call stack is: grub_tsc

Re: [External] Re: [PATCH] BugFix: grub menu gets stuck due to unreliable rdtsc instruction.

2024-11-27 Thread 段亚勇 via Grub-devel
- Wrong coding style. - *The sent patch was fixed before this mail.* - *The upcoming patch about serialization instruction* *adjustment will fix it also.* If there are any other problems, please feel free to let me know. Thanks for your time again. --------------- Best Regards, 段亚勇 Data-SYS-STE

[PATCH] Bugfix: grub menu gets stuck

2024-11-27 Thread Duan Yayong via Grub-devel
Adding "if (grub_tsc_rate == 0)" judgement just in case other unknown instruction exception, so that "grub_tsc_calibrate_from_pit||grub_tsc_calibrate_from_efi" getting "grub_tsc_rate" methods have a opportunity to be performed but causing grub menu stucking. Signed-off-by: Duan Yayong Signed-off-

Re: [PATCH] BugFix: grub menu gets stuck due to unreliable rdtsc instruction.

2024-11-26 Thread Daniel Kiper
On Mon, Nov 11, 2024 at 02:17:19PM +0800, Duan Yayong via Grub-devel wrote: > This patch is used to fix grub menu gets stuck in server > AC poweron/poweroff stress test of x86_64, which is reproduced with 1/200 > ratio. The root cause analysis as below: > > Q. What's the code logic? > A. "grub_tsc_

[PATCH] BugFix: grub menu gets stuck due to unreliable rdtsc instruction.

2024-11-10 Thread Duan Yayong via Grub-devel
This patch is used to fix grub menu gets stuck in server AC poweron/poweroff stress test of x86_64, which is reproduced with 1/200 ratio. The root cause analysis as below: Q. What's the code logic? A. "grub_tsc_init" function will init tsc by setting grub_tsc_rate, which call stack is: grub_ts