Re: "arm_coreboot: Support DMA" breaks arm64

2017-06-05 Thread Leif Lindholm
On Tue, May 30, 2017 at 04:06:52PM +, Vladimir 'phcoder' Serbinenko wrote: > LGTM Thanks - so am I OK to push the following?: >From bb9aa73e172ee284d9b41a0a4657154c355d6f63 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Mon, 5 Jun 2017 10:47:35 +0100 Subject: [PATCH] arm64: don't export

Re: "arm_coreboot: Support DMA" breaks arm64

2017-05-30 Thread Vladimir 'phcoder' Serbinenko
LGTM On Wed, May 24, 2017, 13:36 Leif Lindholm wrote: > Apologies for delay, got knocked out by a bad cold. > > On Thu, May 11, 2017 at 06:33:34PM +, Vladimir 'phcoder' Serbinenko > wrote: > > > Thoughts? > > > > > I don't think that functions in cache.h are used outside of kernel on > arm64

Re: "arm_coreboot: Support DMA" breaks arm64

2017-05-30 Thread Leif Lindholm
On Wed, May 24, 2017 at 12:35:51PM +0100, Leif Lindholm wrote: > Apologies for delay, got knocked out by a bad cold. > > On Thu, May 11, 2017 at 06:33:34PM +, Vladimir 'phcoder' Serbinenko wrote: > > > Thoughts? > > > > > I don't think that functions in cache.h are used outside of kernel on ar

Re: "arm_coreboot: Support DMA" breaks arm64

2017-05-24 Thread Leif Lindholm
Apologies for delay, got knocked out by a bad cold. On Thu, May 11, 2017 at 06:33:34PM +, Vladimir 'phcoder' Serbinenko wrote: > > Thoughts? > > > I don't think that functions in cache.h are used outside of kernel on arm64 > currently. We can just remove cache.h from the list of exported heade

Re: "arm_coreboot: Support DMA" breaks arm64

2017-05-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, May 11, 2017, 17:35 Leif Lindholm wrote: > Commit 265292f ("arm_coreboot: Support DMA") breaks arm64 grub-mkimage > with: > /work/local/bin/grub-mkimage: error: undefined symbol > grub_arch_sync_dma_caches. > > This appears to be caused purely by the false sy

"arm_coreboot: Support DMA" breaks arm64

2017-05-11 Thread Leif Lindholm
Commit 265292f ("arm_coreboot: Support DMA") breaks arm64 grub-mkimage with: /work/local/bin/grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. This appears to be caused purely by the false symbol dependency created by the non-x86 version being an EXPORT_FUNC, in order to