LGTM

On Wed, May 24, 2017, 13:36 Leif Lindholm <leif.lindh...@linaro.org> wrote:

> Apologies for delay, got knocked out by a bad cold.
>
> On Thu, May 11, 2017 at 06:33:34PM +0000, Vladimir 'phcoder' Serbinenko
> wrote:
> > > Thoughts?
> > >
> > I don't think that functions in cache.h are used outside of kernel on
> arm64
> > currently. We can just remove cache.h from the list of exported headers
>
> That's true. So, would something like the below be acceptable?
>
> /
>     Leif
>
> diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
> index 1045138..622f946 100644
> --- a/grub-core/Makefile.am
> +++ b/grub-core/Makefile.am
> @@ -66,7 +66,9 @@ CLEANFILES += grub_script.yy.c grub_script.yy.h
>
>  include $(srcdir)/Makefile.core.am
>
> +if !COND_arm64
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/cache.h
> +endif
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/command.h
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/device.h
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/disk.h
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to