[PATCH] fs/erofs: Fix EROFS label tests in grub-fs-tester

2024-06-12 Thread Yifan Zhao
mkfs.erofs with version < 1.6 does not support the -L option. Let's detect the version of mkfs.erofs and skip the label tests if it is not supported. Signed-off-by: Yifan Zhao --- tests/util/grub-fs-tester.in | 36 ++-- 1 file changed, 30 insertio

Re: [PATCH v15 3/3] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-06-09 Thread Yifan Zhao
Hi Glenn, erofs-utils supports this -L flag since version 1.6. Do you think removing the label-related tests to maintain compatibility with the older versions of erofs-utils is a good idea? Thanks, Yifan Zhao On 2024/6/10 3:33, Glenn Washburn wrote: I am not running this test and it is

Re: [PATCH v14 0/3] Introduce EROFS support

2024-05-17 Thread Yifan Zhao
Reran v14, and it still correctly passes the fs-tester and correctly boots the EROFS kernel image. Thanks, Yifan Zhao On 2024/5/17 20:56, Gao Xiang wrote: [ This is a RESEND version of v13 due to a mis-fix. ] Hi folks, EROFS [1] is a lightweight read-only filesystem designed for

[PATCH v10 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-05-02 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washburn --- Reviewed-by Link: https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html .gitignore

[PATCH v10 1/2] fs/erofs: Add support for EROFS

2024-05-02 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao Tested-by: Daniel Axtens # fuzz testing only --- Tested-by Link:

[PATCH v10 0/2] Introduce EROFS support

2024-05-02 Thread Yifan Zhao
ng to Serbinenko's review comments - add a upper bound for symlink length according to Daniel's advice Tested-by Link (Commit 1): https://lists.gnu.org/archive/html/grub-devel/2024-05/msg1.html Reviewed-by Link (Commit 2): https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html

Re: [PATCH v8 0/2] Introduce EROFS support

2024-05-01 Thread Yifan Zhao
anything will pop up. Congratulations, as far as I can tell, your filesystem implementation is one of the most safe against arbitrary input in all of grub. Thank you once again for your time and contribution! Kind regards, Yifan Zhao For this series: Tested-by: Daniel Axtens # fuzz test

Re: [PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-05-01 Thread Yifan Zhao
On 4/29/24 10:15 PM, Vladimir 'phcoder' Serbinenko wrote: Generally looks good. Few comments. I have missed part of discussion, so point me to relevant parts of it if I miss something that's already been discussed Le mer. 24 avr. 2024, 14:31, Yifan Zhao a écrit : De qq,

Re: [PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-04-30 Thread Yifan Zhao
bsequent emails. Thanks, Yifan Zhao ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v9 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-04-29 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washburn --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20

[PATCH v9 1/2] fs/erofs: Add support for EROFS

2024-04-29 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao --- INSTALL | 8 +- Makefile.uti

[PATCH v9 0/2] Introduce EROFS support

2024-04-29 Thread Yifan Zhao
n and move it to grub-core/fs/erofs.c Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests for EROFS in grub-fs-tester .gitignore | 1 + INSTALL | 8 +- Makefile.util.def| 7 + docs/grub.texi | 3 +- grub

[PATCH v8 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-04-24 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washburn --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20

[PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-04-24 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao --- INSTALL | 8 +- Makefile.uti

[PATCH v8 0/2] Introduce EROFS support

2024-04-24 Thread Yifan Zhao
mount() - handle bondary case and memleak in erofs_iterate_dir() - fix incorrect grub_strnlen() implementation Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests for EROFS in grub-fs-tester .gitignore | 1 + INSTALL

Re: [PATCH v7 1/2] fs/erofs: Add support for EROFS

2024-04-23 Thread Yifan Zhao
Thanks! I will deal with it ASAP. Yifan Zhao On 2024/4/23 23:08, Daniel Axtens wrote: Hi, EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as Android system

[PATCH v7 0/2] Introduce EROFS support

2024-04-21 Thread Yifan Zhao
uncompressed support together with related tests. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org changelog since v6: - fix more char* => grub_uint8_t* issue

[PATCH v7 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-04-21 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washburn --- RVB Link: https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html .gitignore | 1

[PATCH v7 1/2] fs/erofs: Add support for EROFS

2024-04-21 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao --- INSTALL | 8 +- Makefile.uti

Re: [PATCH v5 1/2] fs/erofs: Add support for EROFS

2024-04-21 Thread Yifan Zhao
On 2024/4/22 11:15, Glenn Washburn wrote: On Fri, 19 Apr 2024 01:12:40 +0800 Yifan Zhao wrote: On 2024/4/18 16:16, Glenn Washburn wrote: On Mon, 4 Mar 2024 01:15:54 +0800 Yifan Zhao wrote: EROFS [1] is a lightweight read-only filesystem designed for performance which has already been

Re: [PATCH v5 1/2] fs/erofs: Add support for EROFS

2024-04-21 Thread Yifan Zhao
On 2024/4/22 11:15, Glenn Washburn wrote: On Fri, 19 Apr 2024 01:12:40 +0800 Yifan Zhao wrote: On 2024/4/18 16:16, Glenn Washburn wrote: On Mon, 4 Mar 2024 01:15:54 +0800 Yifan Zhao wrote: EROFS [1] is a lightweight read-only filesystem designed for performance which has already been

[PATCH v6 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-04-18 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests

[PATCH v6 0/2] Introduce EROFS support

2024-04-18 Thread Yifan Zhao
ds in `grub_erofs_map_blocks` - fix buggy code which does not consider endianness - use grub_uint8_t* instead of char* for pointer casting in `erofs_read_inode` - other style and readability improvements according to Glenn's review Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests fo

[PATCH v6 1/2] fs/erofs: Add support for EROFS

2024-04-18 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao --- INSTALL | 8 +- Makefile.uti

Re: [PATCH v5 1/2] fs/erofs: Add support for EROFS

2024-04-18 Thread Yifan Zhao
On 2024/4/18 16:16, Glenn Washburn wrote: On Mon, 4 Mar 2024 01:15:54 +0800 Yifan Zhao wrote: EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as Android

[PATCH v4~v2 Interdiff] Introduce EROFS support

2024-03-03 Thread Yifan Zhao
This interdiff shows the slight change between v4 and v2 for reference. Interdiff against v2: diff --git a/INSTALL b/INSTALL index eb81314d1..545015ba2 100644 --- a/INSTALL +++ b/INSTALL @@ -83,7 +83,7 @@ Prerequisites for make-check: exfat FUSE filesystem * The following are Debian named pa

[PATCH v5 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-03-03 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests

[PATCH v5 1/2] fs/erofs: Add support for EROFS

2024-03-03 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Signed-off-by: Yifan Zhao --- INSTALL | 8 +- Makefile.uti

[PATCH v5 0/2] Introduce EROFS support

2024-03-03 Thread Yifan Zhao
iew. In addition, another interdiff between v4 and v2 (previous RVB version) is provided to Glenn for reference. Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests for EROFS in grub-fs-tester .gitignore | 1 + INSTALL | 8 +-

Re: [PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-03-01 Thread Yifan Zhao
On 2024/3/1 1:59, Daniel Kiper wrote: On Mon, Feb 19, 2024 at 02:22:23PM +0800, Yifan Zhao wrote: EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as Android

[PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-02-19 Thread Yifan Zhao
uncompressed support. Now, it's possible to boot directly through GRUB with an EROFS rootfs. EROFS compressed files will be supported later since it has more work to polish. [1] https://erofs.docs.kernel.org Reviewed-by: Glenn Washburn Reviewed-by: Gao Xiang Signed-off-by: Yifan Zhao --- Res

[PATCH v4 rebased 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-02-19 Thread Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests

[PATCH v4 1/2] fs/erofs: Add support for EROFS

2023-07-20 Thread Yifan Zhao
ectly through GRUB with an EROFS rootfs. EROFS compressed support will be developed later since it has more work to polish. Reviewed-by: Glenn Washburn Reviewed-by: Gao Xiang Signed-off-by: Yifan Zhao --- The link here shows how to boot the kernel from the EROFS partition with this patch.

[PATCH v4 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2023-07-20 Thread Yifan Zhao
: Yifan Zhao --- .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests/util/grub-fs-tester.in | 32 +--- 4 files changed, 52 insertions(+), 7 deletions(-) create mode 100644 tests

[PATCH v4 0/2] fs/erofs: Add support for EROFS

2023-07-20 Thread Yifan Zhao
changes since v3: - Fix according to Xiang's comments. - Append RVB tags. Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests for EROFS in grub-fs-tester .gitignore | 1 + INSTALL | 8 +- Makefile.util.def

[PATCH v3 1/2] fs/erofs: Add support for EROFS

2023-07-20 Thread Yifan Zhao
ectly through GRUB with an EROFS rootfs. EROFS compressed support will be developed later since it has more work to polish. Signed-off-by: Yifan Zhao --- The link here shows how to boot the kernel from the EROFS partition with this patch. https://precious-celery-715.notion.site/Demo-of-booting-kern

[PATCH v2 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2023-07-20 Thread Yifan Zhao
: Yifan Zhao --- To test erofs, run `make TESTS=erofs_test check` (maybe need sudo). .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests/util/grub-fs-tester.in | 32 +--- 4 files

[PATCH v2 1/2] fs/erofs: Add support for EROFS

2023-07-20 Thread Yifan Zhao
ectly through GRUB with an EROFS rootfs. EROFS compressed support will be developed later since it has more work to polish. Signed-off-by: Yifan Zhao --- The link here shows how to boot the kernel from the EROFS partition with this patch. https://precious-celery-715.notion.site/Demo-of-booting-kern

[PATCH v2 0/2] fs/erofs: Add support for EROFS

2023-07-20 Thread Yifan Zhao
changes since v1: - Rename some fields and fix format issues according to reviewer's comment Note that all 8 spaces are replaced with tabs, which is not shown in the interdiff below. Yifan Zhao (2): fs/erofs: Add support for EROFS fs/erofs: Add tests for EROFS in grub-fs-t

[PATCH 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2023-07-16 Thread Yifan Zhao
: Yifan Zhao --- To test erofs, run `make TESTS=erofs_test check` (maybe need sudo). .gitignore | 1 + Makefile.util.def| 6 ++ tests/erofs_test.in | 20 tests/util/grub-fs-tester.in | 32 +--- 4 files

[PATCH 1/2] fs/erofs: Add support for EROFS

2023-07-16 Thread Yifan Zhao
ectly through GRUB with an EROFS rootfs. EROFS compressed support will be developed later since it has more work to polish. Signed-off-by: Yifan Zhao --- The link here shows how to boot the kernel from the EROFS partition with this patch. https://precious-celery-715.notion.site/Demo-of-booting-kern