+ err = grub_disk_read (disk, EROFS_SUPER_OFFSET >>
GRUB_DISK_SECTOR_BITS, 0,
+ sizeof (sb), &sb);
+ if (grub_errno == GRUB_ERR_OUT_OF_RANGE)
+ grub_error (GRUB_ERR_BAD_FS, "not a valid erofs filesystem");
OUT_OF_RANGE is already treated the same asBAD_FS in context of
opening a file
Sorry, I didn't fully understand that. I copied similar logic from the
ext2 driver (fs/ext2.c).
Are you suggesting that I should remove the error code conversion here?
All the other suggestions are great, I will reply in subsequent emails.
Thanks,
Yifan Zhao
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel