Re: [PATCH] lib/LzmaEnc: Validate 'len' before subtracting

On 6/10/25 10:47 AM, Lidong Chen wrote: In LzmaEnc_CodeOneBlock(), both GetOptimumFast() and GetOptimum() returns a value of greater or equal to 1, which is assigned to 'len'. But since LZMA_MATCH_LEN_MIN == 2, 'len' should be validated before performing "len - LZMA_MATCH_LEN_MIN" to avoid underf

Re: [PATCH v2 0/1] loader/efi/chainloader: Enhance error message of chainloader

On 5/7/25 9:21 AM, khaliid caliy wrote: This patch addresses some undescriptive error messages that grub chainloader command returns when issue encountered, specifically during the loading of the uefi image or starting the image. As per uefi UEFI specification (2.11) boot service functions `Star

Re: [PATCH v2] fs/ntfs: Check at->attr_cur after calling next_attribute()

.gnu.org/bugs/?66855__;!!ACWV5N9M2RV99hQ!MlJos-JMiQzMR6XYrdHvoK1BCnCXRxxGUcBEZNXYJRmSe_ADsCWVO0Yzdk8RkShkoHuN6MBOT4mvwvWNMvBT$ Reviewed-by: Ross Philipson Co-authored-by: B Horn Co-authored-by: Andrew Hamilton Signed-off-by: Andrew Hamilton --- grub-core/fs/ntfs.c | 3 ++- 1 file changed,

Re: [RFC] Rust in GRUB

On 3/21/25 5:19 PM, Andrew Hamilton wrote: Hello, Personally, I really like this idea. I second that. One of the areas I think (I am not a Rust programmer) Rust could really help GRUB is in the many large and imposing parsing routines in modules. From what I have read and heard, Rust could i

Re: [PATCH] tss2: restore buffer offset on tpm2_submit_command retry

s the issues occurring during TPM_CC_Load command on the integrated TPM 2.0 in Intel Elkhart Lake chip. Signed-off-by: Diorcet Yann Reviewed-by: Ross Philipson --- grub-core/lib/tss2/tpm2_cmd.c | 4 1 file changed, 4 insertions(+) diff --git a/grub-core/lib/tss2/tpm2_cmd.c b/grub-cor

Re: [PATCH 1/1] lib: Fix clang Build - Remove Duplicate Typedef in TSS

TPMS_SCHEME_KDF1_SP800_108_t; /* TPMS_SCHEME_HMAC Type */ Yes I can see why that would cause problems... Reviewed-by: Ross Philipson ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 3/3] blsuki: Add uki command to load Unified Kernel Image entries

On 2/14/25 8:40 AM, Alec Brown wrote: A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot stub, a Linux kernel image, an initrd, and further resources. The uki command will locate where the uki file is and create a GRUB menu entry to load it. I chatted with Alec yesterday

Re: [PATCH 3/3] blsuki: Add uki command to load Unified Kernel Image entries

On 2/14/25 8:40 AM, Alec Brown wrote: A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot stub, a Linux kernel image, an initrd, and further resources. The uki command will locate where the uki file is and create a GRUB menu entry to load it. Signed-off-by: Alec Brown ---

Re: [PATCH 2/3] blsuki: Check for mounted /boot in emu

On 2/14/25 8:40 AM, Alec Brown wrote: Irritatingly, BLS defines paths relatives to the mountpoint of the filesystem which contains its snippets, not / or any other fixed location. So grub2-emu needs to know whether /boot is a separate filesysem from / and conditionally prepend a path. Signed-of

Re: [PATCH 1/3] blsuki: Add blscfg command to parse Boot Loader Specification snippets

On 2/14/25 8:40 AM, Alec Brown wrote: The BootLoaderSpec (BLS) defines a scheme where different bootloaders can share a format for boot items and a configuration directory that accepts these common configurations as drop-in files. I have looked over this patch carefully (esp. the parsing routin

Re: [PATCH 1/1] gdb: typo hueristic

true in QEMU on Good catch Reviewed-by: Ross Philipson ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] commands/file: Fix null dereference in the knetbsd tests

places in the switch check if elf == NULL. Reviewed-by: Ross Philipson Fixes: https://urldefense.com/v3/__https://savannah.gnu.org/bugs/?61960__;!!ACWV5N9M2RV99hQ!L8SmY4a1GhbF_jVSw1PgVVFTw85_c8-DzevGhhPXEAKZLBZhWQ7SbtR_O2rbR-lveEUY8m7Cws9K8J_FRnsDwnLMzXoo$ Signed-off-by: Lukas Fink Signed-off

Re: [PATCH] nx: Rename GRUB_DL_ALIGN to DL_ALIGN

On 10/16/24 6:04 AM, Daniel Kiper wrote: Rename has been skipped by mistake in the original commit. Fixes: 94649c026 (nx: Set page permissions for loaded modules) Signed-off-by: Daniel Kiper Reviewed-by: Ross Philipson --- grub-core/kern/dl.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

On 10/15/24 10:20 PM, Benjamin Herrenschmidt wrote: The calculation of the size of the table was incorrect (copy/pasta from grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long. Yup that is correct for XSDT entries, the are 64b each. Reviewed-by: Ross Philipson This

Re: [PATCH v1 37/37] chainloader: Use grub_efi_...() memory helpers where reasonable.

On 10/7/24 11:21 AM, Leo Sandoval wrote: From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. While the idea of putting wrappers around the EFI pool allocation c

Re: [PATCH v1 25/37] grub.texi: Make our info pages say "grub2" where appropriate.

On 10/7/24 11:20 AM, Leo Sandoval wrote: From: Peter Jones This needs to be hooked up to --program-transform=, but I haven't had time. Can you explain/expand on this? It is not clear (to me) what that means. Is something missing from this patch? Thanks Ross Signed-off-by: Peter Jones -

Re: [PATCH v2 09/17] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

On 10/7/24 11:18 AM, Leo Sandoval wrote: From: Peter Jones Don't munge raw spaces when we're doing our cmdline escaping (#923374) Signed-off-by: Peter Jones --- grub-core/commands/wildcard.c | 16 - grub-core/lib/cmdline.c | 25 ++-- grub-core/script/exec

Re: [PATCH] lvm: allocate metadata buffer from raw contents

On 10/3/24 8:40 PM, Michael Chang via Grub-devel wrote: On Thu, Oct 03, 2024 at 10:30:15AM GMT, ross.philip...@oracle.com wrote: On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: Previously, the buffer for LVM metadata parsing was set to twice the size of the metadata area, which caused

Re: [PATCH] lvm: allocate metadata buffer from raw contents

On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: Previously, the buffer for LVM metadata parsing was set to twice the size of the metadata area, which caused excessive memory use. This patch changes the allocation to read the actual raw metadata blocks directly from the metadata area. In

Re: small mkconfig patch

On 9/25/24 11:45 AM, gabriel.barros wrote: Hi. With most every project using .conf nowadays, i happened to waste some time when I had to install grub without my automation scripts yesterday. I think this would help new users coming from the new-conf world. --- util/grub-mkconfig.in

Re: [PATCH v3 7/8] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core/mmap/mmap.c | 83 +++ include/grub/memory.h | 3 ++ 2 files changed, 86 insertions(+) diff --git a/grub-core/mmap/mmap.c b/grub-core/mmap/mmap.c index c8c8312c5..80d6c60b8

Re: [PATCH v3 6/8] i386/memory: Define GRUB_PAGE_MASK and GRUB_PAGE_{UP,DOWN} macros

On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel GRUB_PAGE_MASK is intentionally signed to make use of sign extension. Subsequent patches will use them. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- include/grub/i386

Re: [PATCH v3 5/8] i386/memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Daniel Kiper Subsequent patches will use that constant. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core/loader/i386/xen.c | 35 +-- include/grub/i386

Re: [PATCH v3 4/8] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Daniel Kiper This fixes naming inconsistency that goes against coding style as well as helps to avoid potential conflicts and confusion. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub

Re: [PATCH v2 7/8] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

On 9/19/24 3:02 PM, Sergii Dmytruk wrote: From: Daniel Kiper The functions calculate lowest and highest available RAM addresses respectively. It seems that the functions do a bit more than this. They find the lowest and highest values wrt to the limit you pass in. In the case of passing a l

Re: [PATCH v2 8/8] i386: Add CRx, MMIO, MSR and extend CPUID definitions

On 9/19/24 3:02 PM, Sergii Dmytruk wrote: From: Ross Philipson I can't really give an R-b on this once since it originated with me. I think it looks fine though perhaps adding something of a commit message might be desirable, maybe just listing what was added here. Thanks Ross S

Re: [PATCH v2 3/8] i386/msr: Extract and improve MSR support detection code

the way, improve a code a bit. Additionally, use GRUB_ERR_BAD_DEVICE instead of GRUB_ERR_BUG to signal an error because errors encountered by this new routine are not bugs. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core/commands/i386

Re: [PATCH v2 2/8] i386/msr: Rename grub_msr_read() and grub_msr_write()

On 9/19/24 3:02 PM, Sergii Dmytruk wrote: From: Daniel Kiper Use more obvious names which match corresponding instructions: * grub_msr_read() => grub_rdmsr() * grub_msr_write() => grub_wrmsr() Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Phi

Re: [PATCH v2 1/8] i386/msr: Merge rdmsr.h and wrmsr.h into msr.h

Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core/commands/i386/rdmsr.c | 2 +- grub-core/commands/i386/wrmsr.c | 2 +- include/grub/i386/{wrmsr.h => msr.h} | 16 +--- include/grub/i386/rdmsr.h| 37

Re: [PATCH 07/24] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

Regards, Sergii On Tue, Sep 17, 2024 at 11:06:51AM -0700, Ross Philipson via Grub-devel wrote: On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper The functions calculate lowest and highest available RAM addresses respectively. Both functions are needed to calculate PMR boundaries

Re: [PATCH 10/24] include/grub: Introduce Secure Launch Resource Table (SLRT)

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Provide definitions of structures and basic functions for constructing and parsing of SLRT. I looked this all over and it is inline with the layout of the tables (ABI) of the most recent SLRT (both in the v11 release code and

Re: [PATCH 11/24] i386/slaunch: Add basic platform support for secure launch

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Some of the commands declared in header files will be implemented in the follow-up commits. Oh and in the split out patch, can you fix the commit message to just indicate this is generic x86 bits? Ross Signed-off-by: Ross

Re: [PATCH 11/24] i386/slaunch: Add basic platform support for secure launch

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Some of the commands declared in header files will be implemented in the follow-up commits. In addition to submitting the first seven patches standalone, if you split this patch up and remove the slaunch.h changes, you can then

Re: [PATCH 07/24] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper The functions calculate lowest and highest available RAM addresses respectively. Both functions are needed to calculate PMR boundaries for Intel TXT secure launcher introduced by subsequent patches. After discussing this we think t

Re: [PATCH 04/24] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper ...to avoid potential conflicts and confusion. Please fix these commit messages to be complete and not use the ellipsis to reference the short description. Thanks Ross Signed-off-by: Daniel Kiper --- grub-core/lib/i386/xen/

Re: [PATCH 03/24] i386/msr: Extract and improve MSR support detection code

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper Currently rdmsr and wrmsr commands have own MSR support detection code. This code is the same. So, it is duplicated. Additionally, this code cannot be reused by others. Hence, extract this code to a function and make it public. By the

Re: [PATCH 02/24] i386/msr: Rename grub_msr_read() and grub_msr_write()

On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper ... to grub_rdmsr() and grub_wrmsr() respectively. New names are more obvious than older ones. This patch needs its commit message fixed to remove the ellipsis and just make it a complete sentence. Also since you are not the auth

Re: [PATCH 0/2] Fixes for CIDs 86750 and 396931

On 10/17/22 10:04, Jagannathan Raman wrote: Hi, This series provides fixes for CIDs 86750 and 396931. Kindly share your feedback. Thank you very much! These LGTM Reviewed-by: Ross Philipson -- Jag Jagannathan Raman (2): zfs: dnode_get_path(): update dangling dn_new pointer kern

[PATCH] Initialize BSD relocator state variables

-off-by: Ross Philipson --- grub-core/loader/i386/bsd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c index 5838fc8f4..1f9128f6f 100644 --- a/grub-core/loader/i386/bsd.c +++ b/grub-core/loader/i386/bsd.c @@ -728,7

[PATCH] Initialize local relocator subchunk struct to all zeros

The way the code is written the tofree variable would never be passed to the free_subchunk() function uninitialized. Coverity cannot determine this and flags the situation as "Using uninitialized value...". The fix is just to initialize the local struct. Fixes: CID 314016 Signed-of

Re: [GRUB PATCH RFC 00/18] i386: Intel TXT secure launcher

On 6/1/20 1:56 PM, Daniel P. Smith wrote: > On 6/1/20 12:51 PM, Andy Lutomirski wrote: >> On Mon, Jun 1, 2020 at 8:33 AM Daniel P. Smith >> wrote: >>> >>> On 5/7/20 7:06 AM, Daniel Kiper wrote: Hi Łukasz, On Tue, May 05, 2020 at 04:38:02PM +0200, Lukasz Hawrylko wrote: > On Tue,

Re: [GRUB PATCH RFC 15/18] i386/txt: Add Intel TXT core implementation

On 5/22/20 9:24 AM, Krystian Hebel wrote: > > On 05.05.2020 01:21, Daniel Kiper wrote: >> +static grub_err_t >> +init_txt_heap (struct grub_slaunch_params *slparams, struct >> grub_txt_acm_header *sinit) >> +{ >> +  grub_uint8_t *txt_heap; >> +  grub_uint32_t os_sinit_data_ver, sinit_caps; >> +  g

Re: [GRUB PATCH 1/1] loader/i386/linux: Fix an underflow in the setup_header length calculation

ooks correct. The length should be based off the jmp offset byte and not the size of the structure defined in GRUB. Reviewed-by: Ross Philipson > --- > grub-core/loader/i386/linux.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/grub-core

Re: [PATCH] loader/i386/linux: Calculate the setup_header length

On 04/01/2019 07:10 AM, Daniel Kiper wrote: > On Fri, Mar 29, 2019 at 11:55:12AM -0400, Ross Philipson wrote: >> On 03/29/2019 11:09 AM, Daniel Kiper wrote: >>> From: Andrew Jeddeloh >>> >>> Previously the setup_header length was just assumed to be the size o

Re: [PATCH] loader/i386/linux: Calculate the setup_header length

On 03/29/2019 11:09 AM, Daniel Kiper wrote: > From: Andrew Jeddeloh > > Previously the setup_header length was just assumed to be the size of the > linux_kernel_params struct. The linux x86 32-bit boot protocol says that > the size of the linux_i386_kernel_header is 0x202 + the byte value at 0x20

Re: [PATCH 0/5] Various GRUB build fixes

have prevented compiling. I guess it was not tried on these platforms? > verifiers: PowerPC fallout cleanup > verifiers: MIPS fallout cleanup> mips: Enable __clzsi2() > sparc: Enable __clzsi2() and __clzdi2() > Anyway, LGTM Reviewed-by: Ross Philipson _

Re: [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

On 12/06/2018 10:40 AM, Daniel Kiper wrote: > On Thu, Dec 06, 2018 at 10:37:43AM -0500, Ross Philipson wrote: >> On 12/06/2018 08:40 AM, Daniel Kiper wrote: >>> Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for >>> fine-grained signature-verification c

Re: [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

On 12/06/2018 08:40 AM, Daniel Kiper wrote: > Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > fine-grained signature-verification controlling). > > Signed-off-by: Daniel Kiper > --- > grub-core/loader/i386/xen.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 del

Re: [GRUB PATCH 2/2] verifiers: ARM Xen fallout cleanup

On 12/06/2018 08:40 AM, Daniel Kiper wrote: > ARM Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > fine-grained signature-verification controlling). > > Signed-off-by: Daniel Kiper > --- > grub-core/loader/arm64/xen_boot.c | 8 > include/grub/file.h |

Re: [PATCH v4 0/9] verifiers: Framework and EFI shim lock verifier

tion to other verifiers > verifiers: Rename verify module to pgp module > dl: Add support for persistent modules > efi: Add EFI shim lock verifier > > Vladimir Serbinenko (4): > verifiers: File type for fine-grained signature-verification controlling >

Re: [PATCH v3 6/8] verifiers: Add the documentation

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > From: Vladimir Serbinenko > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Daniel Kiper > --- > v3 - suggestions/fixes: >- improve the documentation. > --- > docs/grub-dev.texi | 57 > ++

Re: [PATCH v3 6/8] verifiers: Add the documentation

On 10/09/2018 10:26 AM, Daniel Kiper wrote: > On Fri, Oct 05, 2018 at 12:43:08PM -0400, Ross Philipson wrote: >> On 10/03/2018 05:36 AM, Daniel Kiper wrote: >>> From: Vladimir Serbinenko >>> >>> Signed-off-by: Vladimir Serbinenko >>> Signed-off-b

Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

On 10/09/2018 10:20 AM, Michel Hermier wrote: > That said maybe it's better for readability to do it in 2 patch, one for > moving the file and one for the renaming. I did a test and I thought format generated something more sane but maybe I only ended up doing "git show". Maybe just put a note und

Re: [PATCH v3 6/8] verifiers: Add the documentation

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > From: Vladimir Serbinenko > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Daniel Kiper > --- > v3 - suggestions/fixes: >- improve the documentation. > --- > docs/grub-dev.texi | 57 > ++

Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > Just for clarity. No functional change. > > Signed-off-by: Daniel Kiper > --- > grub-core/Makefile.core.def |4 +- > grub-core/commands/pgp.c| 1018 > +++ > grub-core/commands/verify.c | 1018 > --

Re: [PATCH v3 4/8] verifiers: Add possibility to defer verification to other verifiers

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > This way if a verifier requires verification of a given file it can > defer task to other verifier if it is not able to do it itself. E.g. > shim_lock verifier, posted as a subsequent patch, is able to verify > only PE files. This means that it is not a

Re: [PATCH v3 2/8] verifiers: Framework core

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > From: Vladimir Serbinenko > > Verifiers framework provides core file verification functionality which > can be used by various security mechanisms, e.g., UEFI secure boot, TPM, > PGP signature verification, etc. > > The patch contains PGP code change

Re: [PATCH v3 1/8] verifiers: File type for fine-grained signature-verification controlling

On 10/03/2018 05:36 AM, Daniel Kiper wrote: > From: Vladimir Serbinenko > > Let's provide file type info to the I/O layer. This way verifiers > framework and its users will be able to differentiate files and verify > only required ones. > > This is preparatory patch. > > Signed-off-by: Vladimir