Re: x86: Apply microcode updates in GRUB?

2023-08-24 Thread Paul Menzel
Dear Dimitri, Thank you for your answer. Am 08.08.23 um 17:25 schrieb Dimitri John Ledkov: On Sat, 29 Jul 2023 at 06:54, Paul Menzel wrote: On x86 microcode updates often are recommended to be applied to fix bugs. Just recently new microcode updates where published for AMD Zen 2 processors

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-16 Thread Paul Menzel
Dear Glenn, Am 16.08.23 um 21:33 schrieb Glenn Washburn: There's an extra 'd' in read in the subject line. I think it’s supposed to be “re-add”, that means to add it back. Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https:

Re: [PATCH 1/1] configure.ac: Fix SDL2 typo by referencing value

2023-08-12 Thread Paul Menzel
yes && test x"$grub_emu_sdl2_excuse" != x ; then + if test x"$enable_grub_emu_sdl2" = xyes && test x"$grub_emu_sdl2_excuse" != x ; then AC_MSG_ERROR([SDL2 support for grub-emu was explicitly requested but can't be compiled ($grub_emu_sdl

Red Hat job offer: Principal Software Engineer for bootloader

2023-08-10 Thread Paul Menzel
Dear GRUB folks, I just read on Phoronix [1], that Red Hat published a job offer for a Principal Software Engineer working on the “Linux bootloader” [2]. One of the tasks: Contribute to feature enhancements and bug fixes in projects including the Linux kernel, grub2, shim, and associated to

grub-core/lib/gnulib/argp.h:529:6: error: ‘_GL_ATTRIBUTE_SPEC_PRINTF_SYSTEM’ is an unrecognized format function type [-Werror=format=]

2023-08-07 Thread Paul Menzel
Dear GRUB folks, On Debian sid/unstable with *gcc-12* 12.3.0-7, *gcc-13* 13.2.0-1, and *clang* 1:14.0-55.7, since commit 2b7902459803 (gnulib: Update gnulib version and drop most gnulib patches), I am unable to build GRUB for the platform *coreboot* [1]: ``` $ git clean -dfx && ./configure

x86: Apply microcode updates in GRUB?

2023-07-28 Thread Paul Menzel
Dear GRUB folks, On x86 microcode updates often are recommended to be applied to fix bugs. Just recently new microcode updates where published for AMD Zen 2 processors to fix “Zenbleed” [1]. Currently, these updates are shipped and applied by the firmware, and – mainly due to the proprietar

Re: [PATCH] docs: Improve initrd documentation

2023-07-28 Thread Paul Menzel
ls. -This command is only available on x86 systems. +This command is only available on the pc platform for x86 systems. @end deffn Reviewed-by: Paul Menzel Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

All Systems Go! 2023 (Berlin, 13/14. 09. 23): Call for Participation ends July 7th

2023-07-05 Thread Paul Menzel
Dear GRUB folks, All Systems Go! 2023 Call for Proposals The Call for Participation (CFP) for All Systems Go! 2023 is now open! Please submit your proposals for consideration. The CFP will close on July 7th, 2023. A response will be sent to all submitters on or before July 14th, 2023. The con

[PATCH] docs: Consistently spell *boot loader* with space in paragraph

2022-11-20 Thread Paul Menzel
Signed-off-by: Paul Menzel --- docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 50c811a88..1c94cf192 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -925,7 +925,7 @@ magic. GRUB has three distinct boot methods

Lagging cursor in GRUB menu with HiDPI display

2022-08-23 Thread Paul Menzel
Dear GRUB folks, Trying to navigate the GRUB menu on a HiDPI display (GOP driver), in this case a Dell XPS 13 9370, the cursor response is quite lagging. Especially in the edit mode (c) moving around a line is quite slow. Each step takes, I’d say, half a second. Using a font with a bigger s

Re: [PATCH RESEND v3 2/2] term/gfxterm: Preliminary HiDPI support

2022-08-23 Thread Paul Menzel
Dear Zhang, Thank you for your patches for a much needed feature. Maybe make the commit message summary/title a statement: term/gfxterm: Add preliminary HiDPI support Am 27.06.22 um 11:35 schrieb Zhang Boyang: Currently GRUB's default font is too small to see on a HiDPI monitor. This patch a

Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-12 Thread Paul Menzel
Dear Glenn, Am 13.05.22 um 00:46 schrieb Glenn Washburn: On Thu, 12 May 2022 08:08:32 +0200 Paul Menzel wrote: […] Am 12.05.22 um 05:07 schrieb Glenn Washburn: Signed-off-by: Glenn Washburn *Add documentation for …* could be abbreviated to *Document …* in the git commit message summary

Re: [PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-12 Thread Paul Menzel
Dear Glenn, Am 12.05.22 um 20:29 schrieb Glenn Washburn: On Thu, 12 May 2022 08:10:56 +0200 Paul Menzel wrote: Am 12.05.22 um 05:07 schrieb Glenn Washburn: This command is meant to behave similarly to the 'mode' command of the EFI Shell application. One difference is that to se

Re: [PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-11 Thread Paul Menzel
Dear Glenn, Thank you for the patch. Am 12.05.22 um 05:07 schrieb Glenn Washburn: This command is meant to behave similarly to the 'mode' command of the EFI Shell application. One difference is that to set the mode the mode number is given, not the rows and columns of the desired mode. Also su

Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-11 Thread Paul Menzel
Dear Glenn, Thank you for the patch. Two small nits. Am 12.05.22 um 05:07 schrieb Glenn Washburn: Signed-off-by: Glenn Washburn *Add documentation for …* could be abbreviated to *Document …* in the git commit message summary. --- docs/grub.texi | 23 +++ 1 file ch

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Paul Menzel
Dear Mathieu, Am 03.05.22 um 16:42 schrieb Mathieu Desnoyers: - On May 3, 2022, at 4:47 AM, Paul Menzel pmen...@molgen.mpg.de wrote: Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: The current implementation of the 10_linux script implements its menu items sorting in bash with a

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Paul Menzel
Dear Mathieu, Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: The current implementation of the 10_linux script implements its menu items sorting in bash with a quadratic algorithm, calling "sed", "sort", head, and grep to compare versions between individual lines, which is annoyingly slow for

Re: [PATCH RFC 1/3] efi: provide definitions of DXE services table

2022-04-11 Thread Paul Menzel
Dear Baskov, Thank you for your patches. Am 07.04.22 um 05:32 schrieb Baskov Evgeniy: DXE services can be used to change memory attributes on systems where EFI use stricter policies about memory access rights and sets NX flag on some pages required by grub to executable. If you resend, plea

clang build fails with `../grub-core/lib/gnulib/regex.h:682:20: error: variable length array used [-Werror,-Wvla]`

2022-03-25 Thread Paul Menzel
Dear GRUB folks, On Debian sid/unstable clang 13.0.1 fails to build GRUB due to a problem in Gnulib: ``` $ git log --oneline -1 --no-decorate 7c316e183 term/efi/console: Do not set cursor until the first text output $ ./configure --with-platform=coreboot CC=clang && make […] clang -DHAVE_CONF

Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set

2022-03-24 Thread Paul Menzel
d-aux]) + # Checks for build, host and target systems. AC_CANONICAL_BUILD AC_CANONICAL_HOST Tested-by: Paul Menzel $ git am … && ./autogen.sh && ./configure --with-platform=coreboot $ grep '^CFLAGS=' config.log CFLAGS='' Kind regards, Paul _

Re: [PATCH 2/6] loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta()

2022-03-18 Thread Paul Menzel
Dear Daniel, Am 11.03.22 um 00:35 schrieb Daniel Kiper: Latest GCC may complain in that way: Just for the record, what is the latest GCC for you? 12? In file included from ../include/grub/disk.h:31, from ../include/grub/file.h:26, from ../include/g

Re: [PATCH 3/3] reed_solomon: Fix array subscript 0 is outside array bounds

2022-03-17 Thread Paul Menzel
Dear Michael, Thank you for working on that. Am 17.03.22 um 07:43 schrieb Michael Chang via Grub-devel: The grub_absolute_pointer() is a compound expression that can only work within a function. We are out of luck here when the pointer variables require global definition due to ATTRIBUTE_TEXT

Re: [PATCH 6/6] INSTALL: Add more cross-compiling Debian packages

2022-03-16 Thread Paul Menzel
-mipsel-linux-gnu, and mingw-w64. +gcc-mips-linux-gnu, gcc-mipsel-linux-gnu, gcc-powerpc64-linux-gnu, +gcc-riscv64-linux-gnu, gcc-sparc64-linux-gnu, mingw-w64 and mingw-w64-tools. More cross compiling toolchains can be found at the following trusted sites: Acked-by: Paul Menzel Kind regards

Re: [PATCH v2] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2022-01-18 Thread Paul Menzel
Dear Javier, Peter, Am 29.05.20 um 12:08 schrieb Javier Martinez Canillas: From: Peter Jones On my laptop running at 2.4GHz, if I run a VM where tsc calibration using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds to do so (as measured with the stopwatch on my phone), with

Re: [PATCH 08/10] grub-shell: Boot PowerPC using PMU instead of CUDA for power management

2021-09-21 Thread Paul Menzel
netbootext=elf trim=1 + qemuopts="-M mac99,via=pmu $qemuopts" ;; sparc64-ieee1275) Reviewed-by: Paul Menzel Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] templates: Add GRUB_CMDLINE_LINUX_RECOVERY

2021-09-15 Thread Paul Menzel
[Cc: +Kyle] Am 14.09.21 um 21:25 schrieb ch...@z9.de: From: Chris Vogel When generating grub.cfg using grub-mkconfig and the scripts 10_linux and 20_linux_xen there is no way to add kernel command line parameters _only_ to the recovery entries generated. This is needed to e.g. start a debug s

Re: feature request + patch: GRUB_CMDLINE_LINUX_RECOVERY

2021-09-14 Thread Paul Menzel
Dear Chris, Am 11.09.21 um 19:23 schrieb Chris Vogel: I'd like to propose a patch to add a configuration parameter called GRUB_CMDLINE_LINUX_RECOVERY. All credits for the initial idea and first implementation (as far as I know) go to Kyle Rankin at Purism. I used his improvement without bei

Re: Resurrecting the UEFI Watchdog

2021-08-30 Thread Paul Menzel
Dear Erwan, Am 30.08.21 um 11:14 schrieb Erwan Velu: As per Paul Menzel email, I'm adding the 4 maintainers in CC of this original email. I am sorry for the misunderstanding. *it* referred to the patch. I can offer to refresh & resent this patch to the mailing list if this

Re: Resurrecting the UEFI Watchdog

2021-08-30 Thread Paul Menzel
Dear Erwan, Am 27.08.21 um 17:23 schrieb Erwan Velu: I'd like to share again a patch that got posted a long while ago here and never seen to get attention on it: https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html I found this patch useful as it allows my servers to reboot aut

Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no]) Acked-by: Paul Menzel Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}

2021-08-23 Thread Paul Menzel
]) - if test "x$grub_cv_cc_falign_loop" = xyes; then TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1" - elif test "x$grub_cv_cc_malign_loop" = xyes; then -TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=

Re: [PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
Dear Fāng-ruì, Am 24.08.21 um 07:53 schrieb Fangrui Song via Grub-devel: Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jump

Re: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
Dear Fangrui, Am 16.08.21 um 21:06 schrieb Fangrui Song via Grub-devel: Clang 14.0.0 has implemented -falign-loops=1 but -falign-jumps=1 is still unsupported. The check should test all flags which may be added “alignment” flags? into CFLAGS. Signed-off-by: Fangrui Song --- configure.ac

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Paul Menzel
Dear Petr, dear Jeff, Am 08.07.21 um 17:55 schrieb Petr Vorel: From: Jeff Mahoney sysfs_partition_path calls udevadm to resolve the sysfs path for a block device. That can be accomplished by stating the device node and using the major/minor to follow the symlinks in /sys/dev/block/. This cut

Re: [PATCH 2/2] efi: Print an error if boot to firmware setup is not supported

2021-07-13 Thread Paul Menzel
Dear Javier, Thank you for this patch. Am 06.07.21 um 11:02 schrieb Javier Martinez Canillas: The "fwsetup" command is only registered if the firmware supports booting to the firmware setup UI. But it could be possible that the GRUB config already contains a "fwsetup" entry, because it was ge

Re: [SECURITY PATCH 100/117] kern/parser: Fix a stack buffer overflow

2021-06-28 Thread Paul Menzel
Dear Daniel, dear Chris, Am 10.06.21 um 13:55 schrieb Paul Menzel: Am 02.03.21 um 19:01 schrieb Daniel Kiper: From: Chris Coulson grub_parser_split_cmdline() expands variable names present in the supplied command line in to their corresponding variable contents and uses a 1 kiB stack

Re: [SECURITY PATCH 100/117] kern/parser: Fix a stack buffer overflow

2021-06-10 Thread Paul Menzel
Dear Daniel, dear Chris, Am 02.03.21 um 19:01 schrieb Daniel Kiper: From: Chris Coulson grub_parser_split_cmdline() expands variable names present in the supplied command line in to their corresponding variable contents and uses a 1 kiB stack buffer for temporary storage without sufficient bo

Re: [PATCH v2 1/2] MAINTAINERS: Add MAINTAINERS file

2021-06-07 Thread Paul Menzel
MAINTAINERS file in the README file (suggested by Paul Menzel), - s/http/https/ (suggested by Paul Menzel). --- MAINTAINERS | 31 +++ README | 2 ++ 2 files changed, 33 insertions(+) create mode 100644 MAINTAINERS diff --git a/MAINTAINERS b

Re: [PATCH 2/2] SECURITY: Add SECURITY file

2021-06-02 Thread Paul Menzel
Dear Daniel, Am 01.06.21 um 18:13 schrieb Daniel Kiper: The SECURITY file describes the GRUB project security policy. It is based on https://github.com/wireapp/wire/blob/master/SECURITY.md Signed-off-by: Alex Burmashev Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- MA

Re: [PATCH 1/2] MAINTAINERS: Add MAINTAINERS file

2021-06-02 Thread Paul Menzel
Dear Daniel, Thank you for creating this Am 01.06.21 um 18:13 schrieb Daniel Kiper: The MAINTAINERS file provides basic information about the GRUB project and its maintainers. Signed-off-by: Alex Burmashev Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- MAINTAINERS | 3

Re: [SECURITY PATCH 000/117] Multiple GRUB2 vulnerabilities - 2021/03/02 round

2021-03-18 Thread Paul Menzel
Dear Darren, dear Darren, Am 02.03.21 um 19:00 schrieb Daniel Kiper: Thank you very much for finding and fixing all these issues, and coordinating the publication. […] .../lib/gnulib-patches/fix-null-state-deref.patch | 12 + .../gnulib-patches/fix-regcomp-uninit-token.patch | 15 +

Re: [SECURITY PATCH 029/117] zstd: Initialize seq_t structure fully

2021-03-18 Thread Paul Menzel
Dear Darren, dear Daniel, Am 02.03.21 um 19:00 schrieb Daniel Kiper: From: Darren Kenny While many compilers will initialize this to zero, not all will, Which ones do not? so it is better to be sure that fields not being explicitly set are at known values, and there is code that checks th

Re: [PATCH v2 1/8] linux/arm: fix ARM Linux header layout

2021-03-11 Thread Paul Menzel
Dear Dimitri, Am 11.03.21 um 12:44 schrieb Dimitri John Ledkov: The patch from https://lists.gnu.org/archive/html/grub-devel/2020-10/msg00122.html Is still not applied, and yet it is required to boot armhf linux kernel in qemu OVMF with grub. Please give the example command line, and maybe

Threading of patch series (was: [PATCH v6 00/14] error: Do compile-time format string checking on grub>)

2021-03-05 Thread Paul Menzel
Dear Glenn, Am 06.03.21 um 00:15 schrieb Glenn Washburn: On Fri, 5 Mar 2021 17:27:01 +0100 Daniel Kiper wrote: […] By the way, my I ask you once again to send each patch series as separate thread. Now you are attaching all patch sets to one cover letter which is confusing. Please stop doing

Re: [PATCH] disk/pata: Suppress error message "no device connected"

2021-03-02 Thread Paul Menzel
b_error_pop(); +} + (The indentation looks wrong in Mozilla Thunderbird, but applying the patch, everything is fine. The non-changed lines are indented by two spaces too much.) if (err) grub_print_error (); Acked-by: Paul Menzel Kind regards, Paul __

[PATCH] disk/pata: Prepend log message with PATA

2021-03-01 Thread Paul Menzel
Seeing no device connected it’s not clear, what component this belongs to. So prepend it to log: PATA: no device connected Signed-off-by: Paul Menzel --- grub-core/disk/pata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/disk/pata.c b/grub-core/disk

Re: [PATCH v2 2/2] efi: SPI NOR flash command line

2021-02-16 Thread Paul Menzel
Dear Michael, Am 12.02.21 um 10:20 schrieb Michael Lawnick: Note: There is a bug in code below which will let this code fail on BIOS-UEFI and requires a v3 as soon as basic discussion whether this sort of functionality is accepted at all is done. I don't want to disturb thread by a v3 thread.

Re: Re: [PATCH v2 1/2] efi: SPI NOR flash support

2021-02-10 Thread Paul Menzel
Sehr geehrte Damen und Herren, vielen Dank für Ihre Nachricht, die ich nach dem 12. Februar 2021 lesen werde. Freundliche Grüße Paul Menzel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-03 Thread Paul Menzel
key derival function is supported, as Argon2 is not yet supported. Either way: Acked-by: Paul Menzel Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [RFC] efi spi flash support - where to place

2021-02-03 Thread Paul Menzel
Dear Michael, Am 01.02.21 um 10:46 schrieb Michael Lawnick: Am 22.01.2021 um 16:58 schrieb Paul Menzel: I'm not (yet) in sync with grub timeline, when is next release planned (last commit date)? March *last* year sometime? ;-) I think the current date is March, though re-reading the

Re: [RFC] efi spi flash support - where to place

2021-01-22 Thread Paul Menzel
Dear Michael, Am 22.01.21 um 10:42 schrieb Michael Lawnick: Am 22.01.2021 um 07:51 schrieb Paul Menzel: Am 19.01.21 um 11:38 schrieb Michael Lawnick: Q: where to place the efi driver, where to place the command line handler. Currently I'd say - create grub-core/flash/efispinor.c fo

Re: [RFC] efi spi flash support - where to place

2021-01-21 Thread Paul Menzel
Dear Michael, Am 19.01.21 um 11:38 schrieb Michael Lawnick: first of all, I am new to this group/grub. So please be patient if I violate some group internal rules, just point it out. Formerly I worked many years on U-Boot. Welcome to GRUB, and no worries. Plain text emails, and polite. What

Re: [PATCH] Make EFI minimum heap size configurable via --enable-efi-min-heap-mb

2021-01-05 Thread Paul Menzel
Dear Hanson, Am 04.01.21 um 20:34 schrieb Char, Hanson via Grub-devel: When booted in UEFI mode, Grub would fail to load a ramdisk of size larger than "(total_pages >> 2)" with "error: out of memory" (https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/kern/efi/mm.c#n616) This pr

Interrupt boot and display menu with `GRUB_TIMEOUT=0`?

2020-12-06 Thread Paul Menzel
Dear GRUB folks, Setting the GRUB timeout to 0 `GRUB_TIMEOUT=0` is it possible to interrupt the boot somehow for example by holding a key done? There are some posts on the WWW claiming it was once possible using the shift key [1], but it didn’t work in my tests with Debian bullseye/test

Re: [SPECIFICATION RFC] The firmware and bootloader log specification

2020-12-04 Thread Paul Menzel
Dear Wim, dear Daniel, First, thank you for including all parties in the discussion. Am 04.12.20 um 13:52 schrieb Wim Vervoorn: I agree with you. Using an existing standard is better than inventing a new one in this case. I think using the coreboot logging is a good idea as there is indeed a l

Fwd: [coreboot] Upcoming virtual OSFC 2020

2020-12-01 Thread Paul Menzel
Dear GRUB folks, Maybe some of you are interested in Open Source Firmware Conference. Kind regards, Paul --- Begin Message --- Hello people, This is a last reminder on the upcoming OSFC 2020 (www.osfc.io) which will start tomorrow noon CET. If you are interested in attending the conference,

Universal Payload Project

2020-10-29 Thread Paul Menzel
Dear coreboot, GRUB, and SeaBIOS folks, In #coreb...@irc.freenode.net somebody mentioned the Universal Payload Project [1]. The goal of this project is to define an interface between a first stage platform initialization bootloader and a second stage payload. As there also is a specification

Funding for OSS security improvements by Google

2020-10-15 Thread Paul Menzel
Dear GRUB folks, From *Announcing updates to our Patch Rewards program in 2020 * [1]: Projects in scope Any open source project can be nominated for support. When selecting projects, the panel will put an emphasis on projects that either are vital to the health of the Internet or are end-user

Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

2020-09-18 Thread Paul Menzel
CES[0]}" ;; + "mkfs.f2fs" -l "$FSLABEL" -q "${MOUNTDEVICE}" ;; xnilfs2) "mkfs.nilfs2" -L "$FSLABEL" -b $BLKSIZE -q "${MOUNTDEVICE}" ;; xext2_old) Tested-by: Paul Men

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-17 Thread Paul Menzel
Dear Tianjia, Thank you for your patch and your reply. Am 18.09.20 um 07:08 schrieb Tianjia Zhang: On 9/17/20 10:58 PM, Daniel Kiper wrote: On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote: Like tpm, the module is only enabled for x86_64, but there's nothing specific to x86_64

Quoting issues in Bash script `grub-fs-tester` causes F2FS test failure

2020-08-28 Thread Paul Menzel
Dear GRUB folks, Running `sudo env make -e check VERBOSE=yes SUBDIRS=` the F2FS is one of the two tests failing. It returns 255. Running only the specific test sudo env TESTS=f2fs_test make -e check VERBOSE=yes SUBDIRS= which runs sudo ./grub-fs-tester f2fs and using `set -ex` in

Clear background in GNU/Linux (was: Request for a feature)

2020-06-13 Thread Paul Menzel
Dear Brian, Am 12.06.20 um 02:33 schrieb Brian Kaye: I have been able to have grub2 display a background image on my fedora linux system. It works as long as I don't use secure boot. After I have my selection the image remains on the screen until the boot is complete and I see a login screen. F

[PATCH] docs/grub: Fix typo in *preferred*

2020-04-08 Thread Paul Menzel
--- docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 8e6f9acec..ba1169487 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4729,7 +4729,7 @@ be reloaded after using this command (@pxref{module}). Some kernels have known p

[PATCH v2] docs/grub: Fix typo in *preferred*

2020-04-08 Thread Paul Menzel
Signed-off-by: Paul Menzel --- Add Signed-off-by line. docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 8e6f9acec..ba1169487 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4729,7 +4729,7 @@ be reloaded after using

Re: [PATCHv2] multiboot2: enable quirk-modules-after-kernel

2020-04-06 Thread Paul Menzel
multiboot2_highest_load; #endif /* ! GRUB_MULTIBOOT_HEADER */ Does this need to be documented somewhere? (Multiboot 2 does not seem to be separately documented in `docs/grub.texi`, so maybe not. It’d be great if you added a separate second patch on top, adding a Multiboot 2 example with

Re: Patch to add newer i386 modinfo types

2020-04-05 Thread Paul Menzel
Dear Eric, Am 05.04.20 um 03:54 schrieb Eric McCorkle: Here's a first attempt at a patch that adds the code necessary to pass the EFI framebuffer info into the FreeBSD kernel. I have tested this successfully on real hardware. Nice. Great work. What hardware (also firmware version) did you te

Re: [PATCH] multiboot2: enable quirk-modules-after-kernel

2020-04-02 Thread Paul Menzel
Dear Zide, Thank you very much for your patch. Am 26.03.20 um 23:46 schrieb Zide Chen: In multiboot2, currently there is no way to control where to load the modules. In case of user wants to reserve low address for specific usage, this quirk is useful. It’d be great if you elaborated, where

Re: Native NVMe driver

2020-03-31 Thread Paul Menzel
Dear Christian, Am 31.03.20 um 00:40 schrieb Christian E. Jørgensen: Am I correct in assuming that GRUB relies on something like a BIOS for support of NVMe devices? I'm running coreboot with GRUB as the payload (on amd64 hardware) and GRUB does not seem to detect my NVMe device. If I use SeaBI

Re: [PATCH] version: add a module to get GRUB version

2020-03-30 Thread Paul Menzel
Dear Flavio, Thanks a lot for the patch. Am 30.03.20 um 17:02 schrieb Flavio Suligoi: Sometimes, writing a custom grub.cfg configuration file, especially with embedded systems, it is indispensable to know the version of the running GRUB. This is essential for every automatic sw update procedur

Re: fs/ntfscomp.c:82:11: error: ‘flg’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

2020-03-26 Thread Paul Menzel
Dear PGNet Dev, Thank you for your report. Am 26.03.20 um 04:50 schrieb PGNet Dev: building cd grub git log | head -n5 commit 552c9fd08122a3036c724ce96dfe68aa2f75705f Author: Patrick Steinhardt Date: Sat Mar 7 17:29:09 2020 +

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:54 schrieb PGNet Dev: On 3/25/20 8:52 AM, Paul Menzel wrote: Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread Yes, the question was, if the reported(?) build issues were fixed, and

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:35 schrieb PGNet Dev: […] with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... […] Thanks, but please follow the mailing list netiquette, and start a new discussion thread with a descriptive subject line.

Re: grub/head build with pre-release GCC10 ; fail @ "grub-core/disk/mdraid1x_linux.c:181:15: error: ..."

2020-03-24 Thread Paul Menzel
Dear PGNet Dev, Already reported and analyzed [1]. It’d be nice, if you could verify Thomas’ analysis. Kind regards, Paul [1]: https://lists.gnu.org/archive/html/grub-devel/2020-03/msg00206.html ___ Grub-devel mailing list Grub-devel@gnu.org ht

Re: [PATCH] grub.d: Use linuxefi and initrdefi commands if platform is efi

2020-03-23 Thread Paul Menzel
Dear Tianjia, Am 23.03.20 um 12:53 schrieb Tianjia Zhang: When the platform is EFI platform, use 'linuxefi' and 'initrdefi' commands instead of 'linux' and 'initrd'. Signed-off-by: Jia Zhang Signed-off-by: Tianjia Zhang --- util/grub.d/10_linux.in | 11 +-- 1 file changed, 9 inser

disk/mdraid1x_linux.c:181:15: warning: array subscript is outside array bounds of ‘grub_uint16_t[0]’ {aka ‘short unsigned int[0]’} [-Warray-bounds]

2020-03-20 Thread Paul Menzel
Dear GRUB folks, Using Debian Sid/unstable with gcc (Debian 10-20200312-2) 10.0.1 20200312 (experimental) [master revision c56871dd15a:7ba6e7f0f21:daf2852b883762d921361462dad1f99320faca2a] building GRUB fails with the error below due to treating warnings as errors. gcc -DHAVE_CONFIG_H

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Paul Menzel
]), > - [AC_DEFINE([MM_DEBUG], [1], > - [Define to 1 if you enable memory manager > debugging.])]) > + [include memory manager debugging])) > +if test x$enable_mm_debug = xyes; then > +AC_DEFINE([MM_DEBUG], [1], > +[Define to 1 if you ena

Re: master fails to create moddep.lst, related to luks2 changes

2020-03-03 Thread Paul Menzel
Dear Olaf, On 2020-03-03 09:48, Olaf Hering wrote: > After upgrade from > 4e75b2ae313b13b5bfb54cc5e5c53368d6eb2a08..d5a32255de0e073881980fca0262000c865b30dd > I get this compile error: > > env CFLAGS=-Wall CXXFLAGS=-Wall FFLAGS=-Wall ../grub2-src/configure > --target=i386-suse-linux --with-pl

Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed

2020-02-25 Thread Paul Menzel
Dear Matt, Thank you for upstreaming the patches. On 2020-02-20 07:51, Matt Turner wrote: > From: Mike Gilbert > > PIE should be disabled in assembly sources as well, or else grub will > fail to boot. Could you please extend this with the list, on what architectures it fails to boot? It seems

Re: Anyone tried hooking up Link Time Optimization (LTO)

2020-02-24 Thread Paul Menzel
Dear GRUB folks, Am 24.02.20 um 12:57 schrieb Paul Menzel: Dear GRUB folks, Jacob integrated support for LTO (Link Time Optimization) to coreboot [1], libpayload [2], and the payload *coreinfo* [3] resulting in a noticeable reduction in the size. So maybe GRUB would benefit too. Has anyone

Anyone tried hooking up Link Time Optimization (LTO)

2020-02-24 Thread Paul Menzel
Dear GRUB folks, Jacob integrated support for LTO (Link Time Optimization) to coreboot [1], libpayload [2], and the payload *coreinfo* [3] resulting in a noticeable reduction in the size. So maybe GRUB would benefit too. Has anyone looked into this already? Kind regards, Paul [1]: https://r

[PATCH] docs: Export `superusers` to apply to submenus

2019-12-10 Thread Paul Menzel
Date: Tue, 10 Dec 2019 12:52:22 +0100 Subject: [PATCH] docs: Export `superusers` to apply to submenus Signed-off-by: Paul Menzel --- docs/grub.texi | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index c25ab7a5f..615c32d99 100644 --- a

Re: Disable CLI in submenu but allow users to access it

2019-12-03 Thread Paul Menzel
Dear Vladimir, On 2019-11-29 16:34, Vladimir 'phcoder' Serbinenko wrote: > On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: >> Is it possible to allow unprivileged users to access a submenu but >> not enter the command-line interface? >> >> Reading the docum

Disable CLI in submenu but allow users to access it

2019-11-29 Thread Paul Menzel
Dear GRUB folks, Is it possible to allow unprivileged users to access a submenu but not enter the command-line interface? Reading the documentation [1] it’s not clear to me how to do that, and my tests to do that also failed. The warning in [2] also hints that it’s not possible. > Warning — Ad

error: the initrd is too big

2019-11-15 Thread Paul Menzel
Dear GRUB folks, I built Linux 5.4-rc7 with an initrd and additional options like KASAN selected. When starting the 9.8 MB LZ4 compressed initrd on a Dell Latitude E7250 with 16 GB RAM GRUB shows: error: the initrd is too big UEFI is used and GRUB 2.04 from Debian Sid/unstable. Any idea, h

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-05 Thread Paul Menzel
Dear Michael, Thank you for your patch. On 2019-11-05 10:19, Michael Chang wrote: > The zstd support in btrfs has dependenciy to zstd module and core.img dependency > grows its size significantly to 75KB on my system. The resulted image > cannot be installed into btrfs bootloader area in the s

Re: Patch that fixes an 'at_keyboard' module issue (unreliable key presses)

2019-09-03 Thread Paul Menzel
Dear Michael, I am sorry for the late reply. On 2019-08-29 00:24, Michael Bideau wrote: > Le mardi 27 août 2019 à 11:57 +0200, Paul Menzel a écrit : >> On 8/24/19 9:09 PM, Michael Bideau wrote: >> >>> This patch fixes an issue that prevented the 'at_keyboar

Re: Error in docs

2019-09-03 Thread Paul Menzel
Dear Clayton, On 2019-08-30 23:03, Clayton Voges wrote: > I found a type error in grub's manual/document on section 16.3.19. What > action should I take to fix this? Please check out the source code, make the change, create the commit, and send that to this mailing list. Kind regards, Paul

Re: Patch that fixes an 'at_keyboard' module issue (unreliable key presses)

2019-08-27 Thread Paul Menzel
Dear Michael, On 8/24/19 9:09 PM, Michael Bideau wrote: > This patch fixes an issue that prevented the 'at_keyboard' module to > work (for me). > > The cause is a bad/wrong return value in the function > 'grub_at_keyboard_getkey()' in file > 'grub-core/term/at_keyboard.c' at line 234. > > >

Re: [PATCH v7] probe: Support probing for partition UUID with --part-uuid

2019-05-20 Thread Paul Menzel
Dear Daniel, On 20.05.19 13:39, Daniel Kiper wrote: CC-ing Paul. On Wed, May 15, 2019 at 09:04:43PM +0200, Jacob Kroon wrote: Linux supports root=PARTUUID= boot argument, so add support for probing it. Compared to the fs UUID, the partition UUID does not change when reformatting a partition.

Re: [PATCH v6] probe: Support probing for partition UUID with --part-uuid

2019-05-15 Thread Paul Menzel
s since v5: > * Remove short option > * partition UUID is not necessarily restricted to GPT, so clarify that >in the help text and commit message Thank you very much for going through the reviews so quickly. This looks good to me, and the support can be extended later on. Re

Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q

2019-05-13 Thread Paul Menzel
Dear Jacob, On 10.05.19 14:05, Jacob Kroon wrote: Linux supports root=PARTUUID= boot argument, so add support for probing it. Compared to the fs UUID, the partition UUID does not change when reformatting a partition. How did you choose the switch name `-q`? Are other tools using this already

Re: Detect combined bzImage and UEFI binary

2019-04-02 Thread Paul Menzel
Dear jame88fane, On 03/30/19 17:45, jame88f...@gmx.de wrote: […] > I have here a combined bzImage and UEFI binary and wanted to start it with > the linux/linuxefi command, but unfortunately GRUB2 does not recognize the > integrated UEFI binary and tries to start the bzImage. > > Could someone

Re: [PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-07 Thread Paul Menzel
Dear Daniel, On 07.03.19 20:37, Daniel Kiper wrote: On Thu, Mar 07, 2019 at 12:16:06PM +0100, Paul Menzel wrote: Date: Wed Mar 6 08:14:28 2019 +0100 By default all file system modules are added to the GRUB coreboot payload `default_payload.elf`. This makes the image quite big, especially as

[PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-07 Thread Paul Menzel
efault_payload.elf -rw-rw 1 joey joey 832976 Mar 7 12:13 default_payload.elf So, the resulting payload size is around 370 kB smaller. (Adding it to the CBFS, it will be compressed, so the effective size difference will be smaller.) Signed-off-by: Paul Menzel --- Makefile.am | 3 ++- 1 file c

[PATCH] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-06 Thread Paul Menzel
3728 Mar 6 15:20 default_payload.elf So, the resulting payload size is around 360 kB smaller. (Adding it to the CBFS, it will be compressed, so the effective size difference will be smaller.) Signed-off-by: Paul Menzel --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Paul Menzel
Dear Daniel, On 18.02.19 13:58, Daniel Kiper wrote: On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: Let me start of by saying that I am a contributor and do not have any authority to approve or deny patches to GRUB. That said I do have a few comments below that I would like for

Re: [PATCH 1/1] Add new module msr

2019-02-18 Thread Paul Menzel
Dear Jesus, Thank you very much for your contribution. On 02/16/19 18:29, JesusDF wrote: > Add a new grub module called msr that registers two commands (rdmsr and wrmsr) > to be able to read and write to the model-specific registers. It is i386 > specific, as the cpuid module. The name of the

[PATCH] Add knobs to allow non-initrd boot config

2019-02-15 Thread Paul Menzel
https://code.launchpad.net/ubuntu/+source/grub2 2. Fix typo s/Then/When/] Signed-off-by: Paul Menzel --- docs/grub.texi | 13 + util/grub-mkconfig.in | 4 +++- util/grub.d/10_linux.in | 11 +-- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/docs

Re: [PATCH] Add travis-ci config file

2019-02-13 Thread Paul Menzel
Dear Alexander, On 02/12/19 18:00, Alexander Graf wrote: > There is a really convenient service for open source project from Travis > CI: They allow for free CI testing using their infrastructure. > > Grub has had issues with broken builds for various targets for a long time > already. The main

clang 7.0.1 build fails with `error: argument unused during compilation: '-Qn'`

2019-02-05 Thread Paul Menzel
Dear GRUB folks, Building GRUB from the master branch fails with clang 7.0.1 fails with the error below. The error is not shown with clang 6.0.1. ``` $ ./autogen.sh $ ./configure CC=clang $ make -j`nproc` […] clang -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I386_

  1   2   >