Dear Fāng-ruì,

Am 24.08.21 um 08:18 schrieb Fangrui Song via Grub-devel:
GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`.
Clang silently ignores -malign-{jumps,loops,functions}.

The preferred -falign-* forms have been supported since GCC 3.2, so just
remove -malign-{jumps,loops,functions}.

In `INSTALL` under *The Requirements* at least GCC 5.1 is required.

* GCC 5.1.0 or later
  Experimental support for clang 3.8.0 or later (results in much bigger 
binaries)
  for i386, x86_64, arm (including thumb), arm64, mips(el), powerpc, sparc64

So, this works.

Signed-off-by: Fangrui Song <mask...@google.com>
---
  configure.ac | 9 ---------
  1 file changed, 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index bee28dbeb..9a12151bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -805,17 +805,8 @@ if test "x$target_cpu" = xi386; then
        [grub_cv_cc_falign_loop=no])
    ])
- AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [
-    CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror"
-    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
-        [grub_cv_cc_malign_loop=yes],
-       [grub_cv_cc_malign_loop=no])
-  ])
-
    if test "x$grub_cv_cc_falign_loop" = xyes; then
      TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 
-falign-functions=1"
-  elif test "x$grub_cv_cc_malign_loop" = xyes; then
-    TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 
-malign-functions=1"
    fi
  fi

Acked-by: Paul Menzel <pmen...@molgen.mpg.de>


Kind regards,

Paul

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to