Re: [PATCH 01/17] configure: Add Ubuntu dejavu font path.

2020-07-29 Thread David Michael
On Wed, Jul 29, 2020 at 5:52 PM wrote: > From: Glenn Washburn > > Signed-off-by: Glenn Washburn > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 7c10a4db7..c6b0ef499 100644 > --- a/configure.ac > +++ b/configure.ac

Re: [PATCH v3 2/2] fat: Support file modification times

2020-03-09 Thread David Michael
On Mon, Mar 9, 2020 at 7:33 AM Daniel Kiper wrote: > On Sat, Mar 07, 2020 at 12:59:52AM -0500, David Michael wrote: > > This allows comparing file ages on EFI system partitions. > > > > Signed-off-by: David Michael > > Reviewed-by: Daniel Kiper > > ...except..

[PATCH v3 2/2] fat: Support file modification times

2020-03-06 Thread David Michael
This allows comparing file ages on EFI system partitions. Signed-off-by: David Michael --- Changes since v2: * Added comments referencing the specs * Set errno when the timestamp is invalid I set errno rather than print to the console since it looks like most other file systems don't

[PATCH v3 1/2] exfat: Save the matching directory entry struct when searching

2020-03-06 Thread David Michael
This provides the node's attributes outside the iterator function so the file modification time can be accessed and reported. Signed-off-by: David Michael --- Changes since v2: * Updated commit message grub-core/fs/fat.c | 31 --- 1 file changed, 16 inser

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread David Michael
On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: > Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > > If we go that way then we have to care about them by the end of the > > universe. And this means more and more issues like [1]. If somebody > > wants to use new GRUB then he/she have to reinstal

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread David Michael
On Fri, Mar 6, 2020 at 7:19 AM Daniel Kiper wrote: > On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > > This allows comparing file ages on EFI system partitions. > > > > Signed-off-by: David Michael > > --- > > > > Changes since v1: &

[PATCH v2 2/2] fat: Support file modification times

2020-03-03 Thread David Michael
This allows comparing file ages on EFI system partitions. Signed-off-by: David Michael --- Changes since v1: - Added the previous patch to help support exfat - Added exfat timestamp conversion + setting - Switched to datetime variable name for consistency with the header - Switched to

[PATCH v2 1/2] exfat: Save the matching directory entry when iterating

2020-03-03 Thread David Michael
This provides the node's attributes outside the search function. Signed-off-by: David Michael --- I had to copy an extra struct to support exfat mtimes, so I put it in a separate patch for readability. grub-core/fs/fat.c | 31 --- 1 file changed, 16 inser

[PATCH] fat: Support file modification times

2020-02-28 Thread David Michael
E.g. this allows comparing file ages on EFI system partitions. Signed-off-by: David Michael --- Hi, I tried to make a quick patch for #57621 based on the FAT timestamp format as described on Wikipedia. Is there still a chance to fix this issue for 2.06? Thanks. David P.S. I also made a

Re: [PATCH] generic/blocklist: Fix flag name

2019-07-05 Thread David Michael
On Fri, Jul 5, 2019 at 6:03 PM Daniel Kiper wrote: > > On Fri, Jul 05, 2019 at 07:45:59AM -0400, David Michael wrote: > > Signed-off-by: David Michael > > --- > > > > Hi, > > > > I tried to test the new release and hit this build failure: > &

[PATCH v7 1/2] Define SMBIOS3 entry point structures for EFI

2019-07-05 Thread David Michael
This adds the GUID, and includes it in lsefisystab output. Signed-off-by: David Michael --- No changes since v6, just rebased onto 2.04 grub-core/commands/efi/lsefisystab.c | 1 + include/grub/efi/api.h | 5 + 2 files changed, 6 insertions(+) diff --git a/grub-core/commands

[PATCH v7 2/2] Add a module for retrieving SMBIOS information

2019-07-05 Thread David Michael
n the DMI / SMBIOS tables. 2) We may have a USB stick that can go into multiple boards, and the exact kernel to be loaded depends on the machine information (PRODUCT_NAME etc) passed via the DMI. Signed-off-by: David Michael --- No changes since v6, just rebased onto 2.04 Fixes: https://savann

[PATCH] generic/blocklist: Fix flag name

2019-07-05 Thread David Michael
Signed-off-by: David Michael --- Hi, I tried to test the new release and hit this build failure: In file included from ../grub-core/osdep/blocklist.c:6:0: ../grub-core/osdep/generic/blocklist.c: In function ‘grub_install_get_blocklist’: ../grub-core/osdep/generic/blocklist.c:62:67: error

Re: [PATCH v6 2/2] Add a module for retrieving SMBIOS information

2017-05-09 Thread David Michael
Hi, Bumping this thread, since it looks like new features are being applied again, and the patch still seems to apply cleanly. Is there still interest in this module? I didn't see any changes requested with v6, but let me know if you'd like me to resend it (or the small patch 1/2 for defining th

Re: State of SMBIOS patches

2016-08-11 Thread David Michael
On Thu, Aug 11, 2016 at 3:37 AM, Ioan-Adrian Ratiu wrote: > What's the status of these patches? Do they need more work? I believe I've addressed all the comments the patches received with v6. Last I've heard, the maintainer wants to wait until version 2.03 to merge new features. Hopefully someo

[PATCH v6 2/2] Add a module for retrieving SMBIOS information

2016-03-08 Thread David Michael
The following are two use cases from Rajat Jain : 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information that is passed by the bios in the DMI / SMBI

[PATCH v6 1/2] Define SMBIOS3 entry point structures for EFI

2016-03-08 Thread David Michael
This adds the GUID, and includes it in lsefisystab output. --- No changes since v5 grub-core/commands/efi/lsefisystab.c | 1 + include/grub/efi/api.h | 5 + 2 files changed, 6 insertions(+) diff --git a/grub-core/commands/efi/lsefisystab.c b/grub-core/commands/efi/lsefisystab

Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information

2016-03-02 Thread David Michael
On Wed, Mar 2, 2016 at 2:08 PM, Andrei Borzenkov wrote: > Two nitpicks otherwise looks good. Thanks! Thanks for reviewing these again. I agree with your suggestions, but do they warrant another updated patch, or can those changes just be squashed onto this commit? Also, since sending this, Leif

Re: [PATCH v5 1/2] Define the SMBIOS3 entry point structure on EFI

2016-02-29 Thread David Michael
On Sat, Feb 20, 2016 at 2:12 PM, David Michael wrote: > This adds the GUID and includes it in the lsefisystab module. Pinging to check if these two can make it into 2.02. Side note: I was trying a CoreOS snapshot the other day and noticed they've applied these patches, so here is ano

[PATCH v5 2/2] Add a module for retrieving SMBIOS information

2016-02-20 Thread David Michael
The following are two use cases from Rajat Jain : 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information that is passed by the bios in the DMI / SMBI

[PATCH v5 1/2] Define the SMBIOS3 entry point structure on EFI

2016-02-20 Thread David Michael
This adds the GUID and includes it in the lsefisystab module. --- Changes since v4: To address points suggested by Andrei Borzenkov: * Dropped SMBIOS3 support for cfgtables and loadbios. grub-core/commands/efi/lsefisystab.c | 1 + include/grub/efi/api.h | 5 + 2 files changed

Re: [PATCH v4 1/2] Add support for SMBIOS3 entry point structures

2015-08-26 Thread David Michael
On Fri, Aug 21, 2015 at 8:12 AM, Andrei Borzenkov wrote: > On Sun, Aug 16, 2015 at 5:26 AM, David Michael wrote: >> grub-core/commands/efi/loadbios.c| 18 ++--- > > I am not sure we want to touch it. From what I could gather it had > been used as workaround for

Re: [PATCH v4 1/2] Add support for SMBIOS3 entry point structures

2015-08-26 Thread David Michael
On Mon, Aug 17, 2015 at 3:31 PM, Leif Lindholm wrote: > I can confirm that with these patches, and a recent EDK2 build of > "ArmVirtPkg" for arm64, your example command line works: > grub> smbios --type 1 --get-string 4 > QEMU > grub> > > GRUB also finds both the SMBIOS and SMBIOS3 entry points.

[PATCH v4 2/2] Add a module for retrieving SMBIOS information

2015-08-15 Thread David Michael
The following are two use cases from Rajat Jain : 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information that is passed by the bios in the DMI / SMBI

[PATCH v4 1/2] Add support for SMBIOS3 entry point structures

2015-08-15 Thread David Michael
If both SMBIOS v2 and v3 entry point structures are found, both are registered instead of preferring one version since they can point to different tables at different memory locations. This also modifies the fakebios command so that the entire SMBIOS (v2) EPS is copied instead of just the intermed

Re: [PATCH v3] Add a module for retrieving SMBIOS information

2015-03-29 Thread David Michael
On Fri, Mar 27, 2015 at 12:46 PM, Rajat Jain wrote: > [+Arthur] > > Hello Folks, > > I'm trying to get a binary / raw copy of this patch but could not find one. > David, is it possible to please send us a binary / raw copy of this patch? I've attached a bare patch file. For any future revisions

[PATCH v3] Add a module for retrieving SMBIOS information

2015-03-22 Thread David Michael
The following are two use cases from Rajat Jain : 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information that is passed by the bios in the DMI / SMBI

Re: [PATCH v2] Add a module for retrieving SMBIOS information

2015-03-17 Thread David Michael
On Mon, Mar 16, 2015 at 2:26 PM, Rajat Jain wrote: > Hello, > > Just wanted to check on the status of this patch. Has it been accepted / > merged? No, sorry, I lost track of it. There are still a few points I need to change from Andrei's review before sending a new revision. David ___

Re: [PATCH v2] Add a module for retrieving SMBIOS information

2015-02-15 Thread David Michael
On Wed, Feb 11, 2015 at 6:34 AM, Andrei Borzenkov wrote: > В Sun, 08 Feb 2015 13:54:46 -0500 > David Michael пишет: >> +@item >> +Specifying @option{-t} will only print entries with a matching @var{type}. >> The >> +type can be any value from 0 to 255. Specify

[PATCH v2] Add a module for retrieving SMBIOS information

2015-02-08 Thread David Michael
The following are two use cases from Rajat Jain : 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information that is passed by the bios in the DMI / SMBI

Re: [PATCH] Add a module for retrieving SMBIOS information

2015-02-03 Thread David Michael
On Mon, Feb 2, 2015 at 5:48 PM, Leif Lindholm wrote: > On Mon, Feb 02, 2015 at 05:01:32PM -0500, David Michael wrote: >> >> There was some interest on help-grub about supporting SMBIOS access >> >> upstream. I've updated the module I wrote a while ago to work w

Re: [PATCH] Add a module for retrieving SMBIOS information

2015-02-03 Thread David Michael
On Tue, Feb 3, 2015 at 10:04 AM, Prarit Bhargava wrote: > On 02/02/2015 02:26 PM, Prarit Bhargava wrote: >> >> >> On 02/02/2015 12:09 PM, David Michael wrote: >>> On Mon, Feb 2, 2015 at 6:20 AM, Prarit Bhargava wrote: >>>> On 02/01/2015 09:05 PM, David

Re: [PATCH] Add a module for retrieving SMBIOS information

2015-02-02 Thread David Michael
On Mon, Feb 2, 2015 at 3:06 PM, Leif Lindholm wrote: > On Sun, Feb 01, 2015 at 09:05:24PM -0500, David Michael wrote: >> * grub-core/commands/i386/smbios.c: New file. >> * grub-core/Makefile.core.def (smbios): New module. >> * docs/grub.texi (smbios): New node. >> (

Re: [PATCH] Add a module for retrieving SMBIOS information

2015-02-02 Thread David Michael
On Mon, Feb 2, 2015 at 6:20 AM, Prarit Bhargava wrote: > On 02/01/2015 09:05 PM, David Michael wrote: >> * grub-core/commands/i386/smbios.c: New file. >> * grub-core/Makefile.core.def (smbios): New module. >> * docs/grub.texi (smbios): New node. >> (Command-line and

[PATCH] Add a module for retrieving SMBIOS information

2015-02-01 Thread David Michael
* grub-core/commands/i386/smbios.c: New file. * grub-core/Makefile.core.def (smbios): New module. * docs/grub.texi (smbios): New node. (Command-line and menu entry commands): Add a menu entry for smbios. --- Hi, There was some interest on help-grub about supporting SMBIOS access upstream. I've u

Re: Obtaining the UUID of the system for a PXE boot

2013-07-19 Thread David Michael
Hi, On Fri, Jul 19, 2013 at 10:24 AM, Holger Goetz wrote: > Yes it's towards the right direction. But it is 32bit only if i understand > correctly, and it basically is a memory access to fixed/hardcoded MEMORY > address (0x8001). to pick the veondor id and machine info. It's true that I've

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-11 Thread David Michael
-06-11 16:28:03 + @@ -1,3 +1,8 @@ +2013-06-11 David Michael + + * configure.ac (FREETYPE): Change AC_CHECK_PROGS to AC_CHECK_TOOLS. + (freetype_cflags,freetype_libs): Change freetype-config to $FREETYPE. + 2013-06-07 Andrey Borzenkov * grub-core/s

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-11 Thread David Michael
Hi, On Tue, Jun 11, 2013 at 10:48 AM, Andrey Borzenkov wrote: > Does it also work for non-cross build? AFAIK it should, but just to > confirm? Yes, I did a native build and verified its grub-mkfont still runs, and its output files match sha1sums of fonts from my distro's theme packages. Thanks.

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-11 Thread David Michael
Hi, Upon further consideration, I modified my cross-freetype package to also install a host-prefixed freetype-config in the system path. I probably should have been doing this all along to mimic the equivalent pkg-config commands... I would therefore suggest changing AC_CHECK_PROGS to AC_CHECK_T

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-10 Thread David Michael
Hi, On Sat, Jun 8, 2013 at 12:00 AM, Andrey Borzenkov wrote: >> In my case, I noticed this issue while attempting to cross-compile >> GRUB for another system. It needs to use the cross-compiled freetype >> configuration, but the build system has its native freetype-config >> installed as well. U

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-07 Thread David Michael
Hi, On Fri, Jun 7, 2013 at 2:20 PM, Andrey Borzenkov wrote: > But FREETYPE cannot be anything than freetype-config, can it? Do you > actually have situation when AC_CHECK_PROGS([FREETYPE], > [freetype-config]) succeeds but call to freetype-config fails? In my case, I noticed this issue while att

[BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-07 Thread David Michael
Hi, It seems that the configure script detects freetype-config in the usual manner, but when this command is needed, it will only call a hard-coded freetype-config. Can something like this fix be applied to call the configured program? Thanks. David === modified file 'configure.ac' --- config

Re: [PATCH/RFC] cpuid.c: Provide CPU model information

2013-04-15 Thread David Michael
Hi, On Wed, Apr 3, 2013 at 5:19 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > You should probably rather parse smbios tables I couldn't find a way to access SMBIOS information with configuration files, so about a week ago I made a module for this purpose. I've been toying with it since, an

[PATCH/RFC] cpuid.c: Provide CPU model information

2013-01-30 Thread David Michael
Hi, I have some disks that can be booted both physically and virtually, and it is helpful to have different options depending on the type of platform being used. It's fine having different menu entries to select at boot time, but I wanted to automate this in the configuration. I didn't find a so