On Mon, Feb 2, 2015 at 5:48 PM, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Feb 02, 2015 at 05:01:32PM -0500, David Michael wrote: >> >> There was some interest on help-grub about supporting SMBIOS access >> >> upstream. I've updated the module I wrote a while ago to work with >> >> current GRUB and added documentation. Is this acceptable to be applied? >> >> Are there any comments or suggestions for improvement? >> > >> > Any particular reason for making it x86-only? >> > Since the code correctly does _not_ scan memory for the tables on any >> > EFI system, this should work without modification on arm/arm64 too. >> >> It's marked as x86-only mostly because that's all I've tried, and I >> didn't want to accidentally break builds for other configurations. I >> don't have any ARM hardware for testing the module. Maybe an emulator >> would suffice; I'll have to look into it. >> >> Are you able to try the module with an ARM system? I'd be happy to >> update the patch with your suggested changes if it works. > > I have a software model with some dummy tables, and with one > modification (below - one I think will be necessary for amd64 too), > the command seems to be functional.
Okay, thanks, I'll send an updated patch in the near future with your suggested changes. > I'm hoping we'll get around to implementing SMBIOS support for arm64 > QEMU shortly, so that these things will be easier for others to > test. Or if you'd be interested, I could show you how to test it on > the ARM Foundation Model. I can check out the ARM Foundation Model until QEMU is ready. I haven't used it before, so if you've already got a working setup, I'd be interested in seeing your testing instructions to get started. Thanks. David _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
