Re: [PATCH] tests: Add test ISO files to Dist Package

2025-09-02 Thread Daniel Kiper via Grub-devel
On Sun, Aug 31, 2025 at 09:40:49PM -0500, Andrew Hamilton wrote: > Add test ISO files to dist package to allow ISO test to > pass. > > Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [PATCH] libgcrypt: Allow GRUB to Build With Clang

2025-09-02 Thread Daniel Kiper via Grub-devel
On Sat, Aug 30, 2025 at 10:32:39PM -0500, Andrew Hamilton wrote: > Attempts to build GRUB with Clang were failing due to errors > such as: > error: redefinition of typedef 'gcry_md_hd_t' is a C11 feature > > Correct this by adding a compiler pramga to disable the > Clang "typedef-redefinition" warn

Re: [PATCH v6 0/2] Support dates outside of 1901..2038 range

2025-08-28 Thread Daniel Kiper via Grub-devel
On Wed, Aug 27, 2025 at 05:32:12PM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > Add tests for dates outside this range. > Vast majority of the work was done by Vladimir Serbinenko > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301

Re: [PATCH v5 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-27 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 09:11:10PM -0500, Andrew Hamilton wrote: > Add tests outside the date range possible with 32-bit time > calculation. Also add a few more nominal date/time test values > to the 32-bit "tests" array. Add min / max tests for years 0001 > and . > > Signed-off-by: Vladimir Se

Re: [PATCH v5 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-27 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 09:11:09PM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v4 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 10:28:08AM -0500, Andrew Hamilton wrote: > I will make the requested changes tonight in a v5. > > Just so I understand, is there some coding standard for preferring ternary > operators and comparing bools to true? No, I have not seen one but I think if we have defined const

Re: [PATCH v4 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Mon, Aug 25, 2025 at 10:17:38PM -0500, Andrew Hamilton wrote: > Add tests outside the date range possible with 32-bit time > calculation. > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > tests/date_unit_test.c | 44 +- > 1

Re: [PATCH v4 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Mon, Aug 25, 2025 at 10:17:37PM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v3 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:54:00AM -0500, Andrew Hamilton wrote: > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > static void [...] > date_test_iter (void) > { > - grub_int32_t tests[] = { -1, 0, +1, -2133156255, GRUB_INT32_MIN, > + grub_int32_t tests[] = { -1, 0, +1

Re: [PATCH v3 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:54:00AM -0500, Andrew Hamilton wrote: > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > tests/date_unit_test.c | 35 ++- > 1 file changed, 26 insertions(+), 9 deletions(-) > > diff --git a/tests/date_unit_test

Re: [PATCH v3 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:53:59AM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v2 1/1] bootstrap: Ensure shallow GNULIB clone Works on Newer GIT

2025-08-25 Thread Daniel Kiper via Grub-devel
On Sun, Aug 24, 2025 at 08:38:41PM -0500, Andrew Hamilton wrote: > Update the bootstrap script to be compatible with newer versions > of GIT that changed the git clone -h output from containing: > "--depth" > to: > "--[no-]depth" > This bootstrap script is pulled the latest GNULIB version > from GN

Re: [PATCH 0/4] Several GRUB documentation improvements

2025-08-25 Thread Daniel Kiper via Grub-devel
On Sun, Aug 24, 2025 at 09:50:10PM -0500, Andrew Hamilton wrote: > 1. Several minor documentation improvements. > 2. Document new libgcrypt modules. > 3. Correct / update several URLs in the documentation. > > Andrew Hamilton (4): > docs: Clarify Section Heading and Fix Wording > docs: Document

Re: [PATCH 0/2] Document grub-protect Dependency and Cleanup

2025-08-25 Thread Daniel Kiper via Grub-devel
On Sat, Aug 23, 2025 at 06:09:16PM -0500, Andrew Hamilton wrote: > Update the INSTALL file to note that Libtasn1 (and provide name of > the needed package on Debian) to build grub-protect. Also cleanup > the BUGS file to just point to the bug tracking system. > > Andrew Hamilton (2): > INSTALL: D

Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Aug 22, 2025 at 10:43:17PM -0500, Andrew Hamilton wrote: > Gettext 0.26 validates format strings. In some cases before > the GRUB build process was converting newlines sequences (\n) > to (\) which is invalid. Update the impacted > language SED script files to ensure newlines use the correc

GRUB 2.14 release

2025-08-22 Thread Daniel Kiper via Grub-devel
Hi, It is time to start planning 2.14 release. Sadly once again we are behind the schedule mostly due to lack of resources. I do not like it but it is what it is. I am working on improving situation but it goes slow. Though there is a chance for some improvements after 2.14 release... Anyway, at

Re: [PATCH v6 0/5] Add commands to load BLS and UKI files

2025-08-18 Thread Daniel Kiper via Grub-devel
On Tue, Aug 12, 2025 at 03:45:31AM +, Alec Brown wrote: > v6: > - Documented blsuki_save_default environmental variable. > - Commented on artificial limits. > - Added additional ifdefs for the EFI platforms. > - Fixed various nits. > > This patch set is introducing BootLoaderSpec support to ups

Re: [PATCH v6 1/5] kern/misc: Implement grub_strtok()

2025-08-14 Thread Daniel Kiper via Grub-devel
On Tue, Aug 12, 2025 at 03:45:32AM +, Alec Brown wrote: > Add the functions grub_strtok() and grub_strtok_r() to help parse strings into > tokens separated by characters in the 'delim' parameter. These functions are > present in gnulib but calling them directly from the gnulib code is quite > c

Re: [PATCH v5 5/5] blsuki: Add uki command to load Unified Kernel Image entries

2025-08-05 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:36AM +, Alec Brown wrote: > A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot > stub, > a Linux kernel image, an initrd, and further resources. The uki command will > locate where the UKI file is and create a GRUB menu entry to load it. > >

Re: [PATCH v5 4/5] blsuki: Check for mounted /boot in emu

2025-08-04 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:35AM +, Alec Brown wrote: > From: Robbie Harwood > > Irritatingly, BLS defines paths relative to the mountpoint of the > filesystem which contains its snippets, not / or any other fixed > location. So grub2-emu needs to know whether /boot is a separate > filesyste

Re: [PATCH v5 3/5] util/misc.c: Change offset type for grub_util_write_image_at()

2025-08-04 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:34AM +, Alec Brown wrote: > Adding filevercmp support to grub-core/commands/blsuki.c from gnulib will > cause > issues with the type of the offset parameter for grub_util_write_image_at() > for > EMU builds. To fix this issue, we can change the type from off_t to

Re: [PATCH v5 2/5] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-08-04 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:33AM +, Alec Brown wrote: > From: Peter Jones > > The BootLoaderSpec (BLS) defines a scheme where different bootloaders can > share a format for boot items and a configuration directory that accepts > these common configurations as drop-in files. > > The BLS Speci

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-04 Thread Daniel Kiper via Grub-devel
On Fri, Aug 01, 2025 at 04:51:54PM +0300, Vladimir 'phcoder' Serbinenko wrote: > Please don't put it into kernel unless it's used by the kernel. lib/ would be > a > better fit Whole family of grub_str*() functions live in grub-core/kern/misc.c. So, I am not sure why we should make an exception he

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-01 Thread Daniel Kiper via Grub-devel
On Mon, Jul 28, 2025 at 02:21:50PM +0100, Frediano Ziglio wrote: > On Sun, Jul 27, 2025 at 2:57 AM Alec Brown via Grub-devel > wrote: > > > > Add the functions grub_strtok() and grub_strtok_r() to help parse strings > > into > > tokens separated by characters in the 'delim' parameter. These func

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-01 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:32AM +, Alec Brown wrote: > Add the functions grub_strtok() and grub_strtok_r() to help parse strings into > tokens separated by characters in the 'delim' parameter. These functions are > present in gnulib but calling them directly from the gnulib code is quite > c

Re: [PATCH] dl: fix grub_dl_is_persistent() for EMU

2025-07-04 Thread Daniel Kiper via Grub-devel
On Thu, Jul 03, 2025 at 12:41:26PM +0530, Sudhakar Kuppusamy wrote: > Reviewed-by: Sudhakar Kuppusamy Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] loader/i386/pc/linux: Fix resource leak

2025-06-26 Thread Daniel Kiper via Grub-devel
On Tue, Jun 24, 2025 at 12:27:17AM +0530, sudhakar wrote: > On 2025-06-23 23:16, Lidong Chen via Grub-devel wrote: > > In grub_cmd_initrd(), memory is allocated for variable initrd_ctx > > before calling grub_relocator_alloc_chunk_align_safe(). When the > > function call fails, initrd_ctx should be

Re: [PATCH] Revert "lzma: Make sure we don't dereference past array"

2025-06-23 Thread Daniel Kiper via Grub-devel
On Mon, Jun 23, 2025 at 05:42:32PM +, Lidong Chen wrote: > Commit 40e261b89b71 ensures that the variable len is at least 2. > As a result, GetLenToPosState(len) never returns a value greater > than or equal to kNumLenToPosStates, making the changes introduced > in the commit 16c0dbf4bc6a unreac

Re: [PATCH 1/2] gnulib: Bring back the fix for resolving unused variable

2025-06-23 Thread Daniel Kiper via Grub-devel
On Wed, Jun 18, 2025 at 07:12:15PM +, Lidong Chen wrote: > This patch resolved a minor issue spotted by Coverity: > a983d36bd917 gnulib/regexec: Resolve unused variable > > But, it was removed by the gnulib update: > 2b7902459803 Update gnulib version and drop most gnulib patches > > It cau

Re: [PATCH 1/1] tests: Correct netboot and file_filter test failure

2025-06-23 Thread Daniel Kiper via Grub-devel
On Sat, Jun 21, 2025 at 10:50:38AM -0500, Andrew Hamilton wrote: > Correct a test failure in netboot_test and file_filter_test > caused by an issue cleaning up the tmp directory created > for netboot. Netboot creates a subdirectory in the tmp > folder that causes the rmdir to fail - so cleanup the

Re: [PATCH] normal/charset: Fix underflow and overflow in loop init

2025-06-23 Thread Daniel Kiper via Grub-devel
On Wed, Jun 18, 2025 at 07:24:23PM +, Lidong Chen wrote: > In bidi_line_wrap(), "kk - 1" in the for loop init, "i = kk - 1", > underflows when 'kk' (unsigned int) is 0. Assigning the result of > 'kk - 1' to signed int 'i' may cause overflow. To address both > issues, cast 'kk' to a signed type

Re: [PATCH v2 0/2] Correct Build Failures with GCC-15 and CLANG

2025-06-18 Thread Daniel Kiper via Grub-devel
On Tue, Jun 17, 2025 at 08:58:24PM -0500, Andrew Hamilton wrote: > 1. Correct GRUB build with GCC >= 15 due to new GNULIB compile > warning detected by GCC. > > Pull in gnulib fix to allow base64.c to compile using GCC 15 or newer. > > Pulled from: GNULIB commit 25df6dc4253480a343dde3376ce6fd99c316

Re: [PATCH 0/2] Fix resource leaks in gnulib

2025-06-13 Thread Daniel Kiper via Grub-devel
On Tue, Jun 10, 2025 at 03:19:43PM +, Alec Brown wrote: > Coverity found a couple resource leaks in gnulib code that the GRUB is using. > These fixes have been made in the latest version of gnulib and I've backported > these changes to maintain consistency. > > This patch set fixes the followin

Re: [PATCH v2 0/3] Fixes for non-default TPM PCR banks

2025-06-13 Thread Daniel Kiper via Grub-devel
On Fri, Jun 13, 2025 at 03:02:32PM +0800, Gary Lin wrote: > There are two bugs when using the TPM PCR banks other than the default > SHA256 PCR bank: > > 1) Key unsealing failure > 2) Dumping the wrong PCR bank > > This patch set fixes the above two bugs and adds the tests for SHA384 > PCR bank. >

Re: [PATCH 0/2] build: Fixes to Building from dist Archive

2025-06-13 Thread Daniel Kiper via Grub-devel
On Tue, Jun 10, 2025 at 10:15:44PM -0500, Andrew Hamilton wrote: > Fix several issues with attempting to create and build from the > GRUB 'dist' archive. > > 1. extra_deps.lst is now automatically generated so remove this > from the archive to avoid a dependency on running make first. > > 2. Add ad

Re: [PATCH v2] lib/LzmaEnc: Validate 'len' before subtracting

2025-06-13 Thread Daniel Kiper via Grub-devel
On Thu, Jun 12, 2025 at 12:03:58AM +, Lidong Chen wrote: > In LzmaEnc_CodeOneBlock(), both GetOptimumFast() and GetOptimum() > returns a value of greater or equal to 1, which is assigned to > 'len'. But since LZMA_MATCH_LEN_MIN == 2, 'len' should be validated > before performing "len - LZMA_MAT

Re: [PATCH v4 4/4] blsuki: Add uki command to load Unified Kernel Image entries

2025-06-06 Thread Daniel Kiper via Grub-devel
On Wed, May 21, 2025 at 12:51:26PM +, Alec Brown wrote: > A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot > stub, > a Linux kernel image, an initrd, and further resources. The uki command will > locate where the UKI file is and create a GRUB menu entry to load it. > >

Re: [PATCH v4 3/4] blsuki: Check for mounted /boot in emu

2025-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 21, 2025 at 12:51:25PM +, Alec Brown wrote: > From: Robbie Harwood > > Irritatingly, BLS defines paths relative to the mountpoint of the > filesystem which contains its snippets, not / or any other fixed > location. So grub2-emu needs to know whether /boot is a separate > filesyste

Re: [PATCH v4 2/4] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 21, 2025 at 12:51:24PM +, Alec Brown wrote: > From: Peter Jones > > The BootLoaderSpec (BLS) defines a scheme where different bootloaders can > share a format for boot items and a configuration directory that accepts > these common configurations as drop-in files. > > The BLS Speci

Re: [PATCH v4 1/4] kern/vercmp: Add functionality to compare kernel versions

2025-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 21, 2025 at 12:51:23PM +, Alec Brown wrote: > Add functionality to compare alpha and numeric version segments for kernels. I think this code applies not only for kernels. > This can be useful in sorting newer from older kernels. Where this code come from? Or maybe it is written f

Re: [PATCH] unix/hostdisk: Fix signed integer overflow

2025-06-05 Thread Daniel Kiper via Grub-devel
On Thu, Jun 05, 2025 at 05:03:19AM +, Lidong Chen wrote: > The potential overflow issue arises at "size += ret;" because 'size' > is of type ssize_t (signed) while 'len' is size_t (unsigned). Repeatedly > adding read sizes ('ret') to 'size' can potentially exceed the maximum > value of ssize_t,

Re: [PATCH 0/2] commands/efi: Fix sevral memory leaks

2025-05-22 Thread Daniel Kiper via Grub-devel
On Tue, May 20, 2025 at 05:40:17PM +, khaalid cali wrote: > "handles" that "grub_efi_locate_handles" was allocated with "grub_malloc" > wasn't being freed. The "handles" allocated by grub_efi_locate_handle() call are not always freed. Add missing grub_free() calls. > Signed-off-by: Khalid Al

Re: [PATCH v3 0/5] fs: Test failure fixes and fuzzer fixes

2025-05-22 Thread Daniel Kiper via Grub-devel
On Wed, May 21, 2025 at 10:20:36PM -0500, Andrew Hamilton wrote: > Correct some NTFS test failures introduced by previous fixes for CVEs. > With these changes, the NTFS tests run successfully. > > Also correct some fuzzer identified crashes and hangs (in NTFS and one > that may in theory impact HFS

Re: [PATCH v2 4/4] fs/ntfs: Correct possible access violations and hangs

2025-05-20 Thread Daniel Kiper via Grub-devel
I think you should change the order of this patch and patch #3. On Mon, May 19, 2025 at 09:03:18PM -0500, Andrew Hamilton wrote: > Correct several memory access violations and hangs found during fuzzing. > The issues fixed here could occur if certain specific malformed NTFS > file systems were pre

Re: [PATCH v2 3/4] fs/fshelp: Avoid possible NULL pointer deference

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:17PM -0500, Andrew Hamilton wrote: > Avoid attempting to defererence a NULL pointer to call read_symlink when > the given filesystem does not provide a read_symlink function. This could > be triggered if the calling filesystem had a file marked as a symlink. > This app

Re: [PATCH v2 2/4] fs/ntfs: Correct attribute vs attribute list validation

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:16PM -0500, Andrew Hamilton wrote: > Correct ntfs_test test failures around attempting to validate attribute > list entries as attributes. The NTFS code uses common logic in some > places to parse both attributes and attribute_lists which complicates > validation. Attr

Re: [PATCH v2 1/4] fs/ntfs: Correct regression with run list calculation

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:15PM -0500, Andrew Hamilton wrote: > Correct ntfs_test test failures around attempting to validate attribute > run list values. The calculation was incorrect for the 'curr' variable. > With previous calculation, some file systems would fail validation > despite being w

Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Previously, the command line construction function > (grub_create_loader_cmdline) escaped single and double quotes, which is > unnecessary and potentially problematic since the kernel command line > hand

Re: [PATCH v2 1/2] envblk: ignore empty new lines while parsing env files

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 11:49:54PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Environment files may contain empty lines, which should be > ignored during parsing. Currently, these lines are not skipped and > resulting in incorrect behavior. This patch adds a check to skip empty >

Re: [PATCH 1/2] envblk: ignore empty new lines while parsing env files

2025-05-15 Thread Daniel Kiper via Grub-devel
On Thu, May 15, 2025 at 12:44:27PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Signed-off-by: Shreenidhi Shedi Both patches are missing explanations why they are needed and/or what kind of issues they are fixing. I do not mention cover letter... Daniel _

Re: [SECURITY PATCH 00/08] GRUB2 vulnerabilities - 2025/05/08

2025-05-09 Thread Daniel Kiper via Grub-devel
On Fri, May 09, 2025 at 09:47:05AM +0200, Christian Hesse wrote: > Daniel Kiper on Thu, 2025/05/08 19:02: > > [...] Now all the GRUB2 upstream patches are in > > the GRUB2 git repository [2] too. > > > > [...] > > > > [2] https://git.savannah.gnu.org/gitweb/?p=grub.git > > https://git.savannah

[SECURITY PATCH 6/8] disk/cryptodisk: Add the "erase secrets" function

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov This commit adds the grub_cryptodisk_erasesecrets() function to wipe master keys from all cryptodisks. This function is EFI-only. Since there is no easy way to "force unmount" a given encrypted disk, this function renders all mounted cryptodisks unusable. An attempt to read t

[SECURITY PATCH 3/8] disk/diskfilter: Introduce the "cryptocheck" command

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov This command examines a given diskfilter device, e.g., an LVM disk, and checks if underlying disks, physical volumes, are cryptodisks, e.g., LUKS disks, this layout is called "LVM-on-LUKS". The return value is 0 when all underlying disks (of a given device) are cryptodisks (1

[SECURITY PATCH 8/8] cryptocheck: Add --quiet option

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Michael Chang The option can be used to suppress output if we only want to test the return value of the command. Also, mention this option in the documentation. Signed-off-by: Michael Chang Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper --- docs/grub.texi | 4 +++

[SECURITY PATCH 4/8] commands/search: Add the diskfilter support

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov When the --cryptodisk-only argument is given, also check the target device using the "cryptocheck" command, if available. This extends the checks to common layouts like LVM-on-LUKS, so the --cryptodisk-only argument transparently handles such setups. Signed-off-by: Maxim Suh

[SECURITY PATCH 7/8] disk/cryptodisk: Wipe the passphrase from memory

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov Switching to another EFI boot application while there are secrets in RAM is dangerous, because not all firmware is wiping memory on free. To reduce the attack surface, wipe the passphrase acquired when unlocking an encrypted volume. Signed-off-by: Maxim Suhanov Reviewed-by:

[SECURITY PATCH 5/8] docs: Document available crypto disks checks

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov Document the --cryptodisk-only argument. Also, document the "cryptocheck" command invoked when that argument is processed. Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper --- docs/grub.texi | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(

[SECURITY PATCH 00/08] GRUB2 vulnerabilities - 2025/05/08

2025-05-08 Thread Daniel Kiper via Grub-devel
Hi all, This patch set contains a bundle of fixes for various security flaws discovered, as part of a pro-active hardening effort, in the GRUB2 code recently. The most severe one, i.e. potentially exploitable, has CVE assigned and is listed at the end of this email. Details of exactly what needs

[SECURITY PATCH 2/8] commands/search: Introduce the --cryptodisk-only argument

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov This allows users to restrict the "search" command's scope to encrypted disks only. Typically, this command is used to "rebase" $root and $prefix before loading additional configuration files via "source" or "configfile". Unfortunately, this leads to security problems, like C

[SECURITY PATCH 1/8] kern/rescue_reader: Block the rescue mode until the CLI authentication

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov This further mitigates potential misuse of the CLI after the root device has been successfully unlocked via TPM. Fixes: CVE-2025-4382 Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper --- grub-core/kern/rescue_reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[SECURITY PATCH 1/8] kern/rescue_reader: Block the rescue mode until the CLI authentication

2025-05-08 Thread Daniel Kiper via Grub-devel
From: Maxim Suhanov This further mitigates potential misuse of the CLI after the root device has been successfully unlocked via TPM. Fixes: CVE-2025-4382 Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper --- grub-core/kern/rescue_reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v3 3/3] blsuki: Add uki command to load Unified Kernel Image entries

2025-04-18 Thread Daniel Kiper via Grub-devel
On Sat, Apr 12, 2025 at 03:53:11AM +, Alec Brown wrote: > A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot > stub, > a Linux kernel image, an initrd, and further resources. The uki command will > locate where the uki file is and create a GRUB menu entry to load it. Li

Re: [PATCH v3 2/3] blsuki: Check for mounted /boot in emu

2025-04-18 Thread Daniel Kiper via Grub-devel
On Sat, Apr 12, 2025 at 03:53:10AM +, Alec Brown wrote: > Irritatingly, BLS defines paths relatives to the mountpoint of the > filesystem which contains its snippets, not / or any other fixed > location. So grub2-emu needs to know whether /boot is a separate > filesystem from / and conditionall

Re: [PATCH v3 1/3] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-04-18 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 07:54:01PM +0300, Vladimir 'phcoder' Serbinenko wrote: > > +module = { > > +  name = blsuki; > > +  common = commands/blsuki.c; > > +  common = lib/vercmp.c; > > Probably this should be a part of the kernel. > > > +  enable = powerpc_ieee1275; >

Re: [PATCH v3 1/3] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-04-18 Thread Daniel Kiper via Grub-devel
Missing From:... On Sat, Apr 12, 2025 at 03:53:09AM +, Alec Brown wrote: > The BootLoaderSpec (BLS) defines a scheme where different bootloaders can > share a format for boot items and a configuration directory that accepts > these common configurations as drop-in files. Please add links to t

Re: [PATCH v3 0/3] Add commands to load BLS and UKI files

2025-04-17 Thread Daniel Kiper via Grub-devel
On Thu, Apr 17, 2025 at 07:37:13AM -0400, Neal Gompa wrote: > On Fri, Apr 11, 2025 at 11:55 PM Alec Brown via Grub-devel > wrote: > > > > v3: > > - Added --enable-fallback option to check the default directory if the > > --path > >option isn't able to find entries. > > - Added the function

Re: [PATCH v5 11/13] docs: Update NV index mode of TPM2 key protector

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:25PM +0800, Gary Lin wrote: > This commit updates the NV index mode section and the grub-protect > section to reflect the recent changes in TPM2 key protector and > grub-protect. > > Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v5 10/13] tests/tpm2_key_protector_test: Add more NV index mode tests

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:24PM +0800, Gary Lin wrote: > Two more NV index test cases are added to test key sealing and > unsealing with the NV index handle 0x100. > > Signed-off-by: Gary Lin > Reviewed-by: Stefan Berger Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v5 13/13] docs: Document the long options of tpm2_key_protect_init

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:27PM +0800, Gary Lin wrote: > Add the long options of tpm2_key_protect_init along with the short > options. > > Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [PATCH v5 09/13] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 09:26:00AM -0400, Stefan Berger wrote: > On 4/7/25 4:29 AM, Gary Lin wrote: > > Reset 'ret' to 0 when a test case fails so that the other test cases > > could continue. > > > > Also set the exit status to 1 when encountering a failure to reflect the > > test result. > > > >

Re: [PATCH v5 05/13] tpm2_key_protector: Unseal key from a buffer

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:19PM +0800, Gary Lin wrote: > Extract the logic to handle the file buffer from the SRK recover > function to prepare to load the sealed key from the NV index handle, > so the NV index mode can share the same code path in the later patch. > The SRK recover function now

Re: [PATCH 0/5] Fix memory leaks

2025-04-03 Thread Daniel Kiper via Grub-devel
On Thu, Mar 27, 2025 at 05:56:30PM +, Lidong Chen wrote: > These patches address memory leaks identified by Coverity. > > Lidong Chen (5): > disk/ldm: Fix memory leaks > lib/reloacator: Fix memory leaks > loader/i386/linux: Fix resource leak > fs/btrfs: Fix memory leaks > loader/xnu:

Re: [PATCH 3/5] loader/i386/linux: Fix resource leak

2025-03-27 Thread Daniel Kiper via Grub-devel
On Thu, Mar 27, 2025 at 09:19:03PM +0300, Vladimir 'phcoder' Serbinenko wrote: > > +      { > +       grub_errno = err; > +       goto fail; > +      } > grub_errno is already set. No need to set it again  I proposed that assignment to make it explicit but I am not going to ins

Re: [PATCH v4 12/12] INSTALL: Document the packages needed for TPM2 key protector tests

2025-03-26 Thread Daniel Kiper via Grub-devel
On Fri, Mar 21, 2025 at 03:59:08PM +0800, Gary Lin wrote: > The TPM2 key protector tests require two external packages: swtpm-tools > and tpm2-tools. Add those two packages to the INSTALL file to inform > the user to install those packages before starting the TPM2 key protector > tests. > > Signed-

Re: [PATCH v4 08/12] tests/tpm2_key_protector_test: Simplify the NV index mode test

2025-03-26 Thread Daniel Kiper via Grub-devel
On Fri, Mar 21, 2025 at 03:59:04PM +0800, Gary Lin wrote: > Since 'grub-protect' already supports NV index mode, tpm2_seal_nv() is > replaced with one 'grub-protect' command to simplify the test script. > > 'tpm2_evictcontrol' is also replaced with 'grub-protect --tpm2-evict'. > > Signed-off-by: Ga

Re: [PATCH v4 07/12] util/grub-protect: Support NV index mode

2025-03-26 Thread Daniel Kiper via Grub-devel
On Fri, Mar 21, 2025 at 03:59:03PM +0800, Gary Lin wrote: > This commit implements the missing NV index mode support in > 'grub-protect'. NV index mode stores the sealed key in the TPM > non-volatile memory (NVRAM) instead of a file. There are two supported > types of TPM handles. > > 1. Persistent

Re: [PATCH v4 05/12] tpm2_key_protector: Unseal key from a buffer

2025-03-25 Thread Daniel Kiper via Grub-devel
On Fri, Mar 21, 2025 at 03:59:01PM +0800, Gary Lin wrote: > Extract the logic to handle the file buffer from the SRK recover > function to prepare to load the sealed key from the NV index handle, > so the NV index mode can share the same code path in the later patch. > The SRK recover function now

Re: [PATCH v3 05/10] tss2: Add TPM 2.0 NV index commands

2025-03-25 Thread Daniel Kiper via Grub-devel
On Mon, Jan 13, 2025 at 11:07:08AM +0800, Gary Lin wrote: > The following TPM 2.0 commands are introduced to tss2 to access the > TPM non-volatile memory associated with the NV index handles. > > - TPM2_NV_DefineSpace > - TPM2_NV_UndefineSpace > - TPM2_NV_ReadPublic > - TPM2_NV_Read > - TPM2_NV_Wri

Re: [PATCH v4] powerpc: increase MIN RMA size for CAS negotiation

2025-03-14 Thread Daniel Kiper via Grub-devel
On Thu, Mar 13, 2025 at 07:45:50PM +0530, Avnish Chouhan wrote: > Change RMA size from 512 MB to 768 MB which will result > in more memory at boot time for PowerPC. When vTPM, Secure Boot or > FADump are enabled on PowerPC, the 512 MB RMA memory is not sufficient for > booting. With this 512 MB RMA

Re: [PATCH v3] powerpc: increase MIN RMA size for CAS negotiation

2025-03-12 Thread Daniel Kiper via Grub-devel
On Wed, Mar 12, 2025 at 10:06:15PM +0530, Avnish Chouhan wrote: > Change RMA size from 512 MB to 768 MB which will result > in more memory at boot time for PowerPC. When vTPM, Secure Boot or > FADump are enabled on PowerPC, the 512 MB RMA memory is not sufficient for > booting. With this 512 MB RMA

Re: [PATCH 0/2] docs: Update Documentation for Lockdown Changes

2025-03-04 Thread Daniel Kiper via Grub-devel
On Fri, Feb 28, 2025 at 03:55:22PM -0600, Andrew Hamilton wrote: > Make some updates to the GRUB documentation around which file systems > are allowed / disallowed in lockdown, as well as additional Commands > now blocked in lockdown mode. > > Andrew Hamilton (2): > docs: Document Restricted File

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-03-04 Thread Daniel Kiper via Grub-devel
On Mon, Mar 03, 2025 at 08:55:45AM +0100, Christian Hesse wrote: > Daniel Kiper on Fri, 2025/02/28 13:57: > > On Thu, Feb 27, 2025 at 11:03:44AM +0100, Christian Hesse wrote: > > > Daniel Kiper via Grub-devel on Mon, 2025/02/24 > > > 15:34: > > > > > [..

Re: Feedback Request: Implement Fuzzers and Add to OSS-Fuzz

2025-02-28 Thread Daniel Kiper via Grub-devel
Adding Daniel Axtens, Lidong and Nils... On Thu, Feb 27, 2025 at 01:22:15PM -0500, Andrew Hamilton wrote: > Hello, > > I’m looking for feedback on whether there would be project interest / support > on me creating an initial fuzz test suite for some core GRUB functions and > then > integrating th

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-02-28 Thread Daniel Kiper via Grub-devel
&& *at->attr_cur != 0xFF) > > but I don't understand half of what that code actually does, > so I can't vouch for correctness (not sending it as a patch). > > Also filed here https://savannah.gnu.org/bugs/index.php?66855 > > and here > https://gitlab.archlinux

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-02-28 Thread Daniel Kiper via Grub-devel
On Thu, Feb 27, 2025 at 11:03:44AM +0100, Christian Hesse wrote: > Daniel Kiper via Grub-devel on Mon, 2025/02/24 15:34: > > > [...] > > > The current situation is just insane. > > > > I can understand your frustration but I am afraid we are not able to do >

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-02-24 Thread Daniel Kiper via Grub-devel
On Fri, Feb 21, 2025 at 11:06:54AM +0100, Christian Hesse wrote: > Daniel Kiper via Grub-devel on Tue, 2025/02/18 19:00: > > I am posting all the GRUB2 upstream patches which fix all security bugs > > found and reported up until now. Major Linux distros carry or will carry >

Re: [SECURITY PATCH 49/73] fs: Disable many filesystems under lockdown

2025-02-24 Thread Daniel Kiper via Grub-devel
On Wed, Feb 19, 2025 at 09:43:59AM -0600, Andrew Hamilton wrote: > It seems this may impact some users attempting to use secure boot, I think I > understand the reasoning behind this but maybe we should have something on the > roadmap or issue tracker for what it would take to get these file system

Re: [PATCH 1/1] gdb: typo hueristic

2025-02-20 Thread Daniel Kiper via Grub-devel
On Thu, Jan 16, 2025 at 06:45:29AM -0800, ross.philip...@oracle.com wrote: > On 1/16/25 4:25 AM, Heinrich Schuchardt wrote: > > %s/hueristic/heuristic/ > > > > Signed-off-by: Heinrich Schuchardt > > --- > > grub-core/gdb_helper.py.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-02-19 Thread Daniel Kiper via Grub-devel
Hi Didier, On Tue, Feb 18, 2025 at 07:33:03PM +, Didier Spaier wrote: > Hi Daniel and all, > > sorry for top posting but this is a question and a request, not a comment. > > maintaining a distribution alone I can't afford to carry as many patches as > Debian, so: could please mention the commi

[SECURITY PATCH 72/73] loader/i386/linux: Cast left shift to grub_uint32_t

2025-02-18 Thread Daniel Kiper via Grub-devel
From: Alec Brown The Coverity complains that we might overflow into a negative value when setting linux_params.kernel_alignment to (1 << align). We can remedy this by casting it to grub_uint32_t. Fixes: CID 473876 Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper --- grub-core/loader/i386/

[SECURITY PATCH 62/73] net: Prevent overflows when allocating memory for arrays

2025-02-18 Thread Daniel Kiper via Grub-devel
From: Lidong Chen Use grub_calloc() when allocating memory for arrays to ensure proper overflow checks are in place. Signed-off-by: Lidong Chen Reviewed-by: Daniel Kiper --- grub-core/net/dns.c | 4 ++-- grub-core/net/net.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --gi

[SECURITY PATCH 66/73] osdep/unix/getroot: Fix potential underflow

2025-02-18 Thread Daniel Kiper via Grub-devel
From: Lidong Chen The entry_len is initialized in grub_find_root_devices_from_mountinfo() to 0 before the while loop iterates through /proc/self/mountinfo. If the file is empty or contains only invalid entries entry_len remains 0 causing entry_len - 1 in the subsequent for loop initialization to

[SECURITY PATCH 46/73] commands/memrw: Disable memory reading in lockdown mode

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn With the rest of module being blocked in lockdown mode it does not make a lot of sense to leave memory reading enabled. This also goes in par with disabling the dump command. Reported-by: B Horn Signed-off-by: B Horn Reviewed-by: Daniel Kiper --- grub-core/commands/memrw.c | 21

[SECURITY PATCH 25/73] kern/disk: Limit recursion depth

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn The grub_disk_read() may trigger other disk reads, e.g. via loopbacks. This may lead to very deep recursion which can corrupt the heap. So, fix the issue by limiting reads depth. Reported-by: B Horn Signed-off-by: B Horn Reviewed-by: Daniel Kiper --- grub-core/kern/disk.c | 27 +

[SECURITY PATCH 59/73] fs/zfs: Check if returned pointer for allocated memory is NULL

2025-02-18 Thread Daniel Kiper via Grub-devel
From: Lidong Chen When using grub_malloc() or grub_zalloc(), these functions can fail if we are out of memory. After allocating memory we should check if these functions returned NULL and handle this error if they did. Signed-off-by: Lidong Chen Reviewed-by: Daniel Kiper --- grub-core/fs/zfs/

[SECURITY PATCH 08/73] fs/iso9660: Set a grub_errno if mount fails

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn It was possible for a grub_errno to not be set if mount of an ISO 9660 filesystem failed when set_rockridge() returned 0. This isn't known to be exploitable as the other filesystems due to filesystem helper checking the requested file type. Though fixing as a precaution. Reported-b

[SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn It was possible to read OOB when an attribute had a size that exceeded the allocated buffer. This resolves that by making sure all attributes that get read are fully in the allocated space by implementing a function to validate them. Defining the offsets in include/grub/ntfs.h but t

[SECURITY PATCH 20/73] fs/xfs: Ensuring failing to mount sets a grub_errno

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn It was previously possible for grub_xfs_mount() to return NULL without setting grub_errno if the XFS version was invalid. This resulted in it being possible for grub_dl_unref() to be called twice allowing the XFS module to be unloaded while there were still references to it. Fixing

[SECURITY PATCH 09/73] fs/iso9660: Fix invalid free

2025-02-18 Thread Daniel Kiper via Grub-devel
From: Michael Chang The ctx->filename can point to either a string literal or a dynamically allocated string. The ctx->filename_alloc field is used to indicate the type of allocation. An issue has been identified where ctx->filename is reassigned to a string literal in susp_iterate_dir() but ctx

[SECURITY PATCH 21/73] kern/file: Ensure file->data is set

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn This is to avoid a generic issue were some filesystems would not set data and also not set a grub_errno. This meant it was possible for many filesystems to grub_dl_unref() themselves multiple times resulting in it being possible to unload the filesystems while there were still refere

  1   2   3   >