On Thu, Jan 16, 2025 at 06:45:29AM -0800, ross.philip...@oracle.com wrote: > On 1/16/25 4:25 AM, Heinrich Schuchardt wrote: > > %s/hueristic/heuristic/ > > > > Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com> > > --- > > grub-core/gdb_helper.py.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/grub-core/gdb_helper.py.in b/grub-core/gdb_helper.py.in > > index 5ed9eab0f..a2cab416a 100644 > > --- a/grub-core/gdb_helper.py.in > > +++ b/grub-core/gdb_helper.py.in > > @@ -10,7 +10,7 @@ gdb.prompt_hook = prompt_hook > > class IsGrubLoaded (gdb.Function): > > """Return 1 if GRUB has been loaded in memory, otherwise 0. > > -The hueristic used is checking if the first 4 bytes of the memory pointed > > +The heuristic used is checking if the first 4 bytes of the memory pointed > > to by the _start symbol are not 0. This is true for QEMU on the first run > > of GRUB. This may not be true on physical hardware, where memory is not > > necessarily cleared on soft reset. This may not also be true in QEMU on > > Good catch > > Reviewed-by: Ross Philipson <ross.philip...@oracle.com>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
