Re: [PATCH] BugFix: grub menu gets stuck due to unserialized rdtsc

2025-02-24 Thread 段亚勇 via Grub-devel
Hello Daniel, May I know the *Merge Plan* of Grub Master branch? >From this time, we almost check grub master changes every day and take enough patience to wait for the bugfix to be merged. But we found the recent update of master branch has no our two bugfix patches. If there are any extra problem

Re: [PATCH 3/3] blsuki: Add uki command to load Unified Kernel Image entries

2025-02-24 Thread Ross Philipson via Grub-devel
On 2/14/25 8:40 AM, Alec Brown wrote: A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot stub, a Linux kernel image, an initrd, and further resources. The uki command will locate where the uki file is and create a GRUB menu entry to load it. Signed-off-by: Alec Brown ---

Re: [SECURITY PATCH 49/73] fs: Disable many filesystems under lockdown

2025-02-24 Thread Andrew Hamilton
Thanks I will submit a GRUB documentation patch when I get back from vacation. Thanks! Andrew On Mon, Feb 24, 2025 at 9:18 AM Daniel Kiper wrote: > On Wed, Feb 19, 2025 at 09:43:59AM -0600, Andrew Hamilton wrote: > > It seems this may impact some users attempting to use secure boot, I > think I

Re: [PATCH 2/3] blsuki: Check for mounted /boot in emu

2025-02-24 Thread Ross Philipson via Grub-devel
On 2/14/25 8:40 AM, Alec Brown wrote: Irritatingly, BLS defines paths relatives to the mountpoint of the filesystem which contains its snippets, not / or any other fixed location. So grub2-emu needs to know whether /boot is a separate filesysem from / and conditionally prepend a path. Signed-of

Re: [PATCH 1/3] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-02-24 Thread Ross Philipson via Grub-devel
On 2/14/25 8:40 AM, Alec Brown wrote: The BootLoaderSpec (BLS) defines a scheme where different bootloaders can share a format for boot items and a configuration directory that accepts these common configurations as drop-in files. I have looked over this patch carefully (esp. the parsing routin

Re: [PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM VG

2025-02-24 Thread Daniel Kiper
On Thu, Feb 20, 2025 at 06:52:36PM -0500, Patrick Plenefisch wrote: > Awesome! What do I do now? Wait for push... :-) Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs: Do not reference non-existent "--dumb" option

2025-02-24 Thread Daniel Kiper
On Sat, Jan 04, 2025 at 01:50:32AM -0600, Glenn Washburn wrote: > This appears to be a relic from GRUB legacy that used a --dumb option for > its terminal command. The proper way to do this in GRUB2 is to set the > temrinal to "dumb" via the terminfo command. > > Fixes: https://savannah.gnu.org/bug

Re: [PATCH] docs: Replace @lbracechar{} and @rbracechar{} with @{ and @}

2025-02-24 Thread Daniel Kiper
On Sat, Jan 04, 2025 at 01:41:15AM -0600, Glenn Washburn wrote: > Support for @lbracechar{} and @rbracechar{} was added in GNU Texinfo 5.0, > but many older systems may have versions lower than this. Use @{ and @} > to support a wider range of GNU Texinfo versions. > > Signed-off-by: Glenn Washburn

Re: [PATCH v4 5/6] commands/ls: Print full paths for file args

2025-02-24 Thread Daniel Kiper
On Mon, Jan 06, 2025 at 01:02:43AM -0600, Glenn Washburn wrote: > For arguments that are paths to files, print the full path of the file. > > Signed-off-by: Glenn Washburn > --- > grub-core/commands/ls.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/grub-core/co

[PATCH v2 RESEND] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

2025-02-24 Thread Pascal Hambourg
On systems which support multiple boot platforms such as BIOS and EFI, it makes no sense to show menu entries which are not supported by the current boot platform. Menu entries generated from os-prober 'chain' boot type use boot sector chainloading which is supported by PC BIOS platform only. Show

Re: [PATCH 3/3] fs/xfs: Propagate incorrect inode error from grub_xfs_read_inode

2025-02-24 Thread Daniel Kiper
On Thu, Jan 23, 2025 at 08:44:15PM +0300, Egor Ignatov wrote: > The incorrect inode error from grub_xfs_read_inode did not propagate because Something is off here. You drop two grub_print_error() calls but mention one after grub_xfs_read_inode() call only. So? > grub_print_error() resetted grub_e

Re: [PATCH] fs/xfs: add new superblock features added in Linux 6.12/6.13

2025-02-24 Thread Darrick J. Wong via Grub-devel
On Mon, Feb 24, 2025 at 05:28:30PM +0100, Daniel Kiper wrote: > On Mon, Feb 03, 2025 at 03:41:22PM -0800, Darrick J. Wong via Grub-devel > wrote: > > From: Darrick J. Wong > > > > The Linux port of XFS added a few new features in 2024. The existing > > grub driver doesn't attempt to read or writ

Re: [PATCH 2/3] fs/xfs: Fix grub_xfs_iterate_dir return value in case of failure

2025-02-24 Thread Daniel Kiper
On Thu, Jan 23, 2025 at 08:44:14PM +0300, Egor Ignatov wrote: > Commit ef7850c757 introduced multiple boundary checks in > grub_xfs_iterate_dir() > but handled the error incorrectly returning error code instead of 0. > > Also change the error message so that it doesn't match the message > in grub_

Re: [PATCH 1/3] fs/xfs: Handle root inode read failure in grub_xfs_mount

2025-02-24 Thread Daniel Kiper
On Thu, Jan 23, 2025 at 08:44:13PM +0300, Egor Ignatov wrote: I think you should explain in the commit message why this patch is needed. > Signed-off-by: Egor Ignatov > --- > grub-core/fs/xfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c >

Re: [PATCH] fs/xfs: add new superblock features added in Linux 6.12/6.13

2025-02-24 Thread Daniel Kiper
On Mon, Feb 03, 2025 at 03:41:22PM -0800, Darrick J. Wong via Grub-devel wrote: > From: Darrick J. Wong > > The Linux port of XFS added a few new features in 2024. The existing > grub driver doesn't attempt to read or write any of the new metadata, so > all three can be added to the incompat allo

Re: [PATCH v2 RESEND] util/grub.d/30_os-prober.in: Fix GRUB_OS_PROBER_SKIP_LIST for non-EFI

2025-02-24 Thread Daniel Kiper
On Fri, Feb 21, 2025 at 12:20:28PM +0100, Pascal Hambourg wrote: > GRUB documentation states: > > ‘GRUB_OS_PROBER_SKIP_LIST’ > List of space-separated FS UUIDs of filesystems to be ignored from > os-prober output. For efi chainloaders it’s @ > > But the actual behaviour does not match this desc

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-02-24 Thread Daniel Kiper
On Tue, Feb 18, 2025 at 07:26:57PM +0100, Tobias Powalowski via Grub-devel wrote: > Am 18.02.25 um 19:00 schrieb Daniel Kiper via Grub-devel: > I am posting all the GRUB2 upstream patches which fix all security bugs > found > and reported up until now. Major Linux distros carry or will

Re: [PATCH] fs/ext2: Rework out-of-bounds read for inline and external extents

2025-02-24 Thread Daniel Kiper
On Fri, Feb 21, 2025 at 10:02:54AM +0100, Christian Hesse wrote: > Michael Chang via Grub-devel on Fri, 2025/02/21 09:06: > > Previously, the number of extent entries was not properly capped based > > on the actual available space. This could lead to insufficient reads for > > external extents, si

Re: [SECURITY PATCH 00/73] GRUB2 vulnerabilities - 2025/02/18

2025-02-24 Thread Daniel Kiper via Grub-devel
On Fri, Feb 21, 2025 at 11:06:54AM +0100, Christian Hesse wrote: > Daniel Kiper via Grub-devel on Tue, 2025/02/18 19:00: > > I am posting all the GRUB2 upstream patches which fix all security bugs > > found and reported up until now. Major Linux distros carry or will carry > > soon one form or ano

Re: [SECURITY PATCH 49/73] fs: Disable many filesystems under lockdown

2025-02-24 Thread Daniel Kiper via Grub-devel
On Wed, Feb 19, 2025 at 09:43:59AM -0600, Andrew Hamilton wrote: > It seems this may impact some users attempting to use secure boot, I think I > understand the reasoning behind this but maybe we should have something on the > roadmap or issue tracker for what it would take to get these file system

Re: [SECURITY PATCH 49/73] fs: Disable many filesystems under lockdown

2025-02-24 Thread Daniel Kiper
On Fri, Feb 21, 2025 at 12:20:39PM +0100, Pascal Hambourg wrote: > On 20/02/2025 at 17:43, Daniel Kiper wrote: > > On Wed, Feb 19, 2025 at 09:15:50AM +0100, Petr Řehák wrote: > >> > >> why is there a lockdown for the NTFS file system, please? Is it vulnerable > >> as well when no CVE exists for it?