On Thu, Jan 23, 2025 at 08:44:13PM +0300, Egor Ignatov wrote:

I think you should explain in the commit message why this
patch is needed.

> Signed-off-by: Egor Ignatov <eg...@altlinux.org>
> ---
>  grub-core/fs/xfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c
> index 8e02ab4a30..7c903f01a3 100644
> --- a/grub-core/fs/xfs.c
> +++ b/grub-core/fs/xfs.c
> @@ -1053,6 +1053,8 @@ grub_xfs_mount (grub_disk_t disk)
>              grub_cpu_to_be64(data->sblock.rootino));
>
>    grub_xfs_read_inode (data, data->diropen.ino, &data->diropen.inode);
> +  if (grub_errno)

if (grub_errno != GRUB_ERR_NONE)

> +    goto fail;
>
>    return data;
>   fail:

If you fix these two issues you can add my RB.

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to