Re: [PATCH v19 21/33] tss2: Add TPM2 Software Stack (TSS2) support

On Tue, Oct 01, 2024 at 04:48:34PM +0200, Daniel Kiper wrote: > On Wed, Sep 18, 2024 at 03:28:44PM +0800, Gary Lin via Grub-devel wrote: > > On Tue, Sep 17, 2024 at 11:14:33PM -0400, Stefan Berger wrote: > > > On 9/6/24 5:11 AM, Gary Lin wrote: > > > > A Trusted Platform Module (TPM) Software Stack

[PATCH v4 0/6] i386: memory/MSR/CR code updates

Hi, These are generally useful x86-related changes which were originally posted as part of DRTM patchset [0]. The changes can also be viewed on GitHub [1]. Best regards, Sergii Changes in v2: - updated commit messages - added missing Signed-off-by Changes in v3: - patches 1-3: added reviewe

[PATCH v4 6/6] i386/memory: Define GRUB_PAGE_MASK and GRUB_PAGE_{UP, DOWN} macros

From: Krystian Hebel GRUB_PAGE_MASK is intentionally signed to make use of sign extension. Subsequent patches will use them. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- include/grub/i386/memory.h | 5 + 1 file changed, 5 insertions(+) dif

[PATCH v4 2/6] i386/msr: Rename grub_msr_read() and grub_msr_write()

From: Daniel Kiper Use more obvious names which match corresponding instructions: * grub_msr_read() => grub_rdmsr() * grub_msr_write() => grub_wrmsr() Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson Reviewed-by: Daniel Kiper --- grub-core/commands/i3

[PATCH v4 1/6] i386/msr: Merge rdmsr.h and wrmsr.h into msr.h

From: Daniel Kiper It does not make sense to have separate headers for individual static functions. So, make one common place to store them. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson Reviewed-by: Daniel Kiper --- grub-core/commands/i386/rdmsr.c

[PATCH v4 4/6] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

From: Daniel Kiper This fixes naming inconsistency that goes against coding style as well as helps to avoid potential conflicts and confusion as this constant is used in multiple places. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson Reviewed-by: Daniel

[PATCH v4 3/6] i386/msr: Extract and improve MSR support detection code

From: Daniel Kiper Currently rdmsr and wrmsr commands have own MSR support detection code. This code is the same. So, it is duplicated. Additionally, this code cannot be reused by others. Hence, extract this code to a function and make it public. By the way, improve a code a bit. Additionally, u

[PATCH v4 5/6] i386/memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

From: Daniel Kiper This is an x86-specific thing and should be available globally. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson Reviewed-by: Daniel Kiper --- grub-core/loader/i386/xen.c | 35 +-- include/grub/i386/memo