Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting

2024-09-05 Thread Vladimir 'phcoder' Serbinenko
Reviewed-by: phco...@gmail.com Le ven. 6 sept. 2024, 04:38, Glenn Washburn a écrit : > Signed-off-by: Glenn Washburn > --- > docs/grub.texi | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/docs/grub.texi b/docs/grub.texi > index 63e796a3a738..e6e5efa05e6

Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting

2024-09-05 Thread Andrew Hamilton
Thanks for fixing these, I’m not an official maintainer but looks good to me! Sincerely, Andrew Hamilton On Thu, Sep 5, 2024 at 8:37 PM Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > docs/grub.texi | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff

[PATCH] docs: Fix incorrect and potentially confusing language and minor formatting

2024-09-05 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 63e796a3a738..e6e5efa05e6c 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4538,11 +4538,12 @@ files. @node emunet_mod

Re: [PATCH v2 1/2] loader/efi: Reuse len variable

2024-09-05 Thread Daniel Kiper
On Tue, Sep 03, 2024 at 04:15:46PM +0100, Frediano Ziglio via Grub-devel wrote: > Signed-off-by: Frediano Ziglio For both patches Reviewed-by: Daniel Kiper ... Next time please add a cover letter to a bundle of patches. Thank you for fixing these issues! Daniel ___

Re: [PATCH] loader/efi: Update comment

2024-09-05 Thread Daniel Kiper
On Tue, Sep 03, 2024 at 09:00:27AM +0100, Frediano Ziglio via Grub-devel wrote: > The function called is grub_utf8_to_utf16. > > Signed-off-by: Frediano Ziglio For all patches except "loader/efi: Reuse len variable" Reviewed-by: Daniel Kiper ... Daniel __

Re: [PATCH v2 0/7] Fix Yeeloong 2F support

2024-09-05 Thread Daniel Kiper
On Tue, Sep 03, 2024 at 09:01:08PM +0300, Vladimir 'phcoder' Serbinenko wrote: > v2: Changed how I fix module search: instead of matching alignment, > compute the module position explicitly For all patches Reviewed-by: Daniel Kiper ... Daniel ___ Grub-

Re: [PATCH v5 1/5] Import libgcrypt 1.10.3

2024-09-05 Thread Daniel Kiper
On Tue, Sep 03, 2024 at 08:29:30PM +0300, Vladimir Serbinenko wrote: > We currently use an old version of libcrypt which > results in us having fewer ciphers and missing on many > other improvements. > > Signed-off-by: Vladimir Serbinenko Now at least it builds but... Could you update libgcrypt