On Tue, Sep 03, 2024 at 08:29:30PM +0300, Vladimir Serbinenko wrote:
> We currently use an old version of libcrypt which
> results in us having fewer ciphers and missing on many
> other improvements.
>
> Signed-off-by: Vladimir Serbinenko <[email protected]>
Now at least it builds but...
Could you update libgcrypt to the latest version, 1.11.0?
When I apply the patches git complains in the following way:
Applying: Import libgcrypt 1.10.3
.git/rebase-apply/patch:164629: space before tab in indent.
if test "$cross_compiling" = yes; then :
.git/rebase-apply/patch:164736: space before tab in indent.
if test "$cross_compiling" = yes; then :
.git/rebase-apply/patch:185953: trailing whitespace.
* Copyright (C) 1994, 1996, 1997, 1998,
.git/rebase-apply/patch:185962: trailing whitespace.
do
.git/rebase-apply/patch:185971: trailing whitespace.
}
warning: squelched 15 whitespace errors
warning: 20 lines add whitespace errors.
Applying: Import b64dec from gpg-error
Applying: Adjust import script, definitions and API users for libgcrypt 1.10
.git/rebase-apply/patch:868: trailing whitespace.
.git/rebase-apply/patch:869: trailing whitespace.
.git/rebase-apply/patch:872: trailing whitespace.
.git/rebase-apply/patch:882: trailing whitespace.
.git/rebase-apply/patch:894: trailing whitespace.
warning: squelched 15 whitespace errors
warning: 20 lines add whitespace errors.
Applying: Add DSA and RSA SEXP tests
Applying: keccak: Disable acceleration with SSE asm
.git/rebase-apply/patch:29: trailing whitespace.
.git/rebase-apply/patch:32: trailing whitespace.
warning: 2 lines add whitespace errors.
I am OK with warnings from original libgcrypt import but our patches
should be clean.
When I run bootstrap I can see this:
Importing libgcrypt...
WARNING: C file isn't a module: blake2.c
WARNING: C file isn't a module: ecc-curves.c
WARNING: C file isn't a module: ecc-ecdh.c
WARNING: C file isn't a module: ecc-ecdsa.c
WARNING: C file isn't a module: ecc-eddsa.c
WARNING: C file isn't a module: ecc-gost.c
WARNING: C file isn't a module: ecc-misc.c
WARNING: C file isn't a module: ecc-sm2.c
WARNING: C file isn't a module: gost-s-box.c
WARNING: C file isn't a module: poly1305.c
WARNING: C file isn't a module: primegen.c
patching file grub-core/lib/libgcrypt-grub/cipher/md.c
patching file grub-core/lib/libgcrypt-grub/cipher/keccak.c
Hunk #1 succeeded at 253 (offset 2 lines).
Please fix the warnings and hunk complaint.
I do not mention that Coverity complains too. Though I do not send more
details because they may not apply to newer libgcrypt.
Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
