Re: [PATCH v16 03/20] libtasn1: disable code not needed in grub

2024-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 15, 2024 at 01:06:55PM +0800, Gary Lin wrote: > From: Daniel Axtens > > We don't expect to be able to write ASN.1, only read it, > so we can disable some code. > > Do that with #if 0/#endif, rather than deletion. This means > that the difference between upstream and grub is smaller, >

Re: [PATCH v16 02/20] libtasn1: import libtasn1-4.19.0

2024-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 15, 2024 at 01:06:54PM +0800, Gary Lin wrote: > From: Daniel Axtens > > Import a very trimmed-down set of libtasn1 files: I hope you merge the latest one... > pushd /tmp I would create tmp dir in the GRUB source code and extract libtasn1 there. Then I would remove the tmp dir. > wg

Re: [PATCH v1 1/1] Fix missing measurements on confidential computing enabled platform

2024-06-05 Thread Kuppuswamy Sathyanarayanan
On Mon, Jun 3, 2024 at 2:37 PM Hector Cao wrote: > > The measurements for confidential computing has been introduced in the commit > 4c76565b6 (efi/tpm: Add EFI_CC_MEASUREMENT_PROTOCOL support). Recently > this patch 30708dfe3 (tpm: Disable the tpm verifier if the TPM device > is not present) has

Re: [PATCH v16 01/20] posix_wrap: tweaks in preparation for libtasn1

2024-06-05 Thread Daniel Kiper via Grub-devel
On Wed, May 15, 2024 at 01:06:53PM +0800, Gary Lin wrote: > From: Daniel Axtens > > - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as >SIZEOF_UNSIGNED_LONG. > > - Define WORD_BIT, the size in bits of an int. This is a defined >in the Single Unix Specification and in gnulib's limits.h.

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-06-05 Thread Daniel Kiper via Grub-devel
On Wed, Jan 24, 2024 at 06:26:37AM +, Alec Brown wrote: > Added functionality to disable command line interface access and editing of > GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-06-05 Thread Vladimir 'phcoder' Serbinenko
Reviewed-By: Vladimir Serbinenko On Wed, Jan 24, 2024 at 9:27 AM Alec Brown wrote: > > Added functionality to disable command line interface access and editing of > GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off-by: Alec Brown > --- > docs/grub.texi

Re: [PATCH v1 1/1] Fix missing measurements on confidential computing enabled platform

2024-06-05 Thread Daniel Kiper
On Mon, Jun 03, 2024 at 11:36:25PM +0200, Hector Cao wrote: > The measurements for confidential computing has been introduced in the commit > 4c76565b6 (efi/tpm: Add EFI_CC_MEASUREMENT_PROTOCOL support). Recently > this patch 30708dfe3 (tpm: Disable the tpm verifier if the TPM device > is not prese