On Wed, May 15, 2024 at 01:06:54PM +0800, Gary Lin wrote: > From: Daniel Axtens <d...@axtens.net> > > Import a very trimmed-down set of libtasn1 files:
I hope you merge the latest one... > pushd /tmp I would create tmp dir in the GRUB source code and extract libtasn1 there. Then I would remove the tmp dir. > wget https://ftp.gnu.org/gnu/libtasn1/libtasn1-4.19.0.tar.gz > tar -xf libtasn1-4.19.0.tar.gz The "-" is not needed. Please drop it. > popd > pushd grub-core/lib > rm -rf libtasn1 > mkdir libtasn1 > cp /tmp/libtasn1-4.19.0/{README.md,COPYING} libtasn1/ > mkdir libtasn1/lib > cp > /tmp/libtasn1-4.19.0/lib/{coding.c,decoding.c,element.c,element.h,errors.c,gstr.c,gstr.h,int.h,parser_aux.c,parser_aux.h,structure.c,structure.h} > libtasn1/lib > cp /tmp/libtasn1-4.19.0/lib/includes/libtasn1.h ../../include/grub/ > git add libtasn1/ ../../include/grub/libtasn1.h I am not OK with adding libtasn1.h to the include/grub. Please do not do that. I think good example how it should be done is in miniLZO lib. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
