Re: [PATCH v4] cryptodisk: allow user to retry failed passphrase

2024-04-30 Thread Glenn Washburn
On Sat, 27 Apr 2024 17:48:31 -0700 Forest wrote: > Give the user a chance to re-enter their cryptodisk passphrase after a typo, > rather than immediately failing (and likely dumping them into a grub shell). > > By default, we allow 3 tries before giving up. A value in the > cryptodisk_passphrase

Re: [PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-04-30 Thread Yifan Zhao
+ err = grub_disk_read (disk, EROFS_SUPER_OFFSET >> GRUB_DISK_SECTOR_BITS, 0, +                       sizeof (sb), &sb); +  if (grub_errno == GRUB_ERR_OUT_OF_RANGE) +    grub_error (GRUB_ERR_BAD_FS, "not a valid erofs filesystem"); OUT_OF_RANGE is already treated the same as

Re: [PATCH v13 04/20] libtasn1: changes for grub compatibility

2024-04-30 Thread Stefan Berger
On 4/25/24 04:01, Gary Lin via Grub-devel wrote: From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - remove _asn1_strcat and replace strcat with the bound-checked _asn1_str_cat except the one inside _asn1_str_cat. That strcat is replaced with strcpy.

Re: [PATCH v13 20/20] tests: Add tpm2_test

2024-04-30 Thread Gary Lin via Grub-devel
On Mon, Apr 29, 2024 at 04:10:05PM +0800, Gary Lin wrote: > On Fri, Apr 26, 2024 at 05:18:04PM -0500, Glenn Washburn wrote: > > On Thu, 25 Apr 2024 16:02:06 +0800 > > Gary Lin wrote: > > > > > For the tpm2 module, the TCG2 command submission function is the only > > > difference between the a QEM