grub-mkimage ignores compression option

2022-06-14 Thread Eugene Bright via Grub-devel
Hello! Option --compression doesn't affect the core image size. Does it work at all? Running grub-mkimage with compression `none` > # grub-mkimage -v -O i386-pc -p /boot btrfs -C none | wc -c > grub-mkimage: info: the total module size is 0x1a380. > grub-mkimage: info: reading /usr/lib/grub/i386-

Re: [PATCH v4 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2022-06-14 Thread Michael Chang via Grub-devel
On Tue, Jun 14, 2022 at 03:47:30PM +0200, The development of GNU GRUB wrote: > This lets a LUKS2 cryptodisk have its cipher and hash filled out, > otherwise they wouldn't be initialized if cheat mounted. > --- > grub-core/osdep/devmapper/getroot.c | 91 - > 1 file chang

[PATCH v3] grub-fs-tester: Add luks1 and luks2 support

2022-06-14 Thread Glenn Washburn
From: Pierre-Louis Bonicoli The logical sector size used by LUKS1 is 512 bytes and LUKS2 uses 512 to 4069 bytes. The deafualt password used is "pass", but can be overridden by setting the PASS environment variable. The device mapper name is set to the name of the temp directory so that its easy t

grub-mkimage ignores compression option

2022-06-14 Thread Eugene Bright via Grub-devel
Option --compression doesn't affect the core image size. Does it work at all? Running it without compression `none` > # grub-mkimage -v -O i386-pc -p /boot btrfs -C none | wc -c > grub-mkimage: info: the total module size is 0x1a380. > grub-mkimage: info: reading /usr/lib/grub/i386-pc/kernel.img.

[PATCH] configure.ac: warn if stack-protector not allowed

2022-06-14 Thread Nicholas Vinson
Previous version of configure.ac would error out when --enable-stack-protector was given and a selected GRUB platform did not support the flag. The new behavior is to warn that the flag is not supported and force disable it for that platform. Signed-off-by: Nicholas Vinson --- configure.ac | 3

Re: [PATCH v4 0/2] Have LUKS2 cryptomounts be useable with grub-probe

2022-06-14 Thread Glenn Washburn
On Tue, 14 Jun 2022 15:47:28 +0200 Josselin Poiret wrote: > Hello Glenn, > > I took the time to rebase all the patches on the latest master, then > remove the problematic parsing, keeping only the cipher part, as well > as add some additional error checking for grub_cryptodisk_setcipher > and gr

Re: [PATCH v4 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2022-06-14 Thread Glenn Washburn
On Tue, 14 Jun 2022 15:47:30 +0200 Josselin Poiret wrote: > This lets a LUKS2 cryptodisk have its cipher and hash filled out, > otherwise they wouldn't be initialized if cheat mounted. > --- > grub-core/osdep/devmapper/getroot.c | 91 - > 1 file changed, 90 insertions

Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Glenn Washburn
On Tue, 14 Jun 2022 18:55:18 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > Correct solution is to provide __builtin_trap ourselves. Likely it would be > a wrapper around grub_abort This seems like tacit support for at least the direction of my patch removing the use of __builtin_trap[1] which w

Re: [PATCH v3] disk/cryptodisk: When cheatmounting, use the sector info of the cheat device

2022-06-14 Thread Glenn Washburn
On Tue, 14 Jun 2022 15:55:21 +0200 Fabian Vogt wrote: > When using grub-probe with cryptodisk, the mapped block device from the host > is used directly instead of decrypting the source device in GRUB code. > In that case, the sector size and count of the host device needs to be used. > This is es

Re: GRUB 2.12 release, etc.

2022-06-14 Thread John Paul Adrian Glaubitz
Hello! > On Jun 14, 2022, at 11:52 AM, Xiaotian Wu wrote: > > I would like to ask, can GRUB-2.12 add a new LoongArch architecture support? It would also be great if the patches that add support for 64-bit MIPS EFI could be added as well. See: https://github.com/AOSC-Dev/grub-loongson3 I hav

Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Vladimir 'phcoder' Serbinenko
Correct solution is to provide __builtin_trap ourselves. Likely it would be a wrapper around grub_abort Le mar. 14 juin 2022, 15:37, Darren Kenny a écrit : > clang expands the abort function to __builtin_trap, but that cannot be > exported. > > The script that generates the symlist.c file should

Re: GRUB 2.12 release, etc.

2022-06-14 Thread Glenn Washburn
On Tue, 14 Jun 2022 17:48:39 +0800 Xiaotian Wu wrote: > Hi Daniel. > > Thank you for your release plan. > > I would like to ask, can GRUB-2.12 add a new LoongArch architecture support? > > LoongArch is a RISC instruction set from China. Currently, Linux-5.19 > adds LoongArch CPU support and w

Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 14, 2022 at 3:37 PM Darren Kenny wrote: > > clang expands the abort function to __builtin_trap, but that cannot be > exported. > > The script that generates the symlist.c file should also exclude any > symbols that start with __builtin_. This patch will break many platforms including P

[PATCH v3] disk/cryptodisk: When cheatmounting, use the sector info of the cheat device

2022-06-14 Thread Fabian Vogt
When using grub-probe with cryptodisk, the mapped block device from the host is used directly instead of decrypting the source device in GRUB code. In that case, the sector size and count of the host device needs to be used. This is especially important when using luks2, which does not assign total

[PATCH v4 0/2] Have LUKS2 cryptomounts be useable with grub-probe

2022-06-14 Thread Josselin Poiret via Grub-devel
Hello Glenn, I took the time to rebase all the patches on the latest master, then remove the problematic parsing, keeping only the cipher part, as well as add some additional error checking for grub_cryptodisk_setcipher and grub_crypto_lookup_md_by_name. I also took note of another mail saying th

[PATCH v4 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2022-06-14 Thread Josselin Poiret via Grub-devel
This lets a LUKS2 cryptodisk have its cipher and hash filled out, otherwise they wouldn't be initialized if cheat mounted. --- grub-core/osdep/devmapper/getroot.c | 91 - 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/grub-core/osdep/devmapper/getroot.c

[PATCH v4 1/2] devmapper/getroot: Have devmapper recognize LUKS2

2022-06-14 Thread Josselin Poiret via Grub-devel
Changes UUID comparisons so that LUKS1 and LUKS2 are both recognized as being LUKS cryptodisks. --- grub-core/osdep/devmapper/getroot.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/grub-core/osdep/devmapper/getroot.c b/grub-core/osdep/devmapper/getroot.c index 9

[PATCH 0/1] Fix clang build, partially

2022-06-14 Thread Darren Kenny
To fix the build with clang, there are 2 parts needed, the first is to get a fix back into gnulib to ensure that the regex code can build, that has been submitted upstream and can be pulled in later since there is now a preference not to have patches held in GRUB's own sources but fix upstream. Bu

[PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Darren Kenny
clang expands the abort function to __builtin_trap, but that cannot be exported. The script that generates the symlist.c file should also exclude any symbols that start with __builtin_. Signed-off-by: Darren Kenny --- grub-core/gensymlist.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/g

Re: [PATCH] Add some randomness to TCP source port selection.

2022-06-14 Thread Robert LeBlanc
Thanks. I had trouble using the clock to seed the random number generator due to some dependency issues. I'm not strong enough in C to figure that out with the limited GRUB libraries (since standard libraries are not used), so I did what I could to show the intended behavior. Please feel free to s

Re: GRUB 2.12 release, etc.

2022-06-14 Thread Xiaotian Wu
Hi Daniel. Thank you for your release plan. I would like to ask, can GRUB-2.12 add a new LoongArch architecture support? LoongArch is a RISC instruction set from China. Currently, Linux-5.19 adds LoongArch CPU support and will support complete EFIStub in version 5.20. On GRUB, including 2 p