On Tue, 14 Jun 2022 15:47:28 +0200 Josselin Poiret <d...@jpoiret.xyz> wrote:
> Hello Glenn, > > I took the time to rebase all the patches on the latest master, then > remove the problematic parsing, keeping only the cipher part, as well > as add some additional error checking for grub_cryptodisk_setcipher > and grub_crypto_lookup_md_by_name. I also took note of another mail > saying that we shouldn't pretend to support LUKS3 if it ever comes > out, so I've modified the first patch to only recognize LUKS1 and > LUKS2. With Fabian's patch [1] applied, this made grub-install > install fine on a LUKS2 drive with a 4096 sector size. > > I hope all the logic errors were corrected (removing the complicated > part should have helped). Great, thanks for the update! Except for a couple minor nits, it all looks good to me. Adding Patrick and Daniel. For the whole series: Reviewed-by: Glenn Washburn <developm...@efficientek.com> Glenn > > [1] 8075647.t7z3s40...@linux-e202.suse.de > (https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00097.html) > > Best, > Josselin Poiret (2): > devmapper/getroot: Have devmapper recognize LUKS2 > devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM > parameters > > grub-core/osdep/devmapper/getroot.c | 102 ++++++++++++++++++++++++++-- > 1 file changed, 97 insertions(+), 5 deletions(-) > _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
