Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
Dear Fāng-ruì, Am 24.08.21 um 08:18 schrieb Fangrui Song via Grub-devel: Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jump

Re: [PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}

2021-08-23 Thread Paul Menzel
Dear Fāng-ruì, Am 24.08.21 um 08:18 schrieb Fangrui Song via Grub-devel: GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`. Clang silently ignores -malign-{jumps,loops,functions}. The preferred -falign-* forms have been supported since GCC 3.2, so just remove -malign-{

[PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Fangrui Song via Grub-devel
Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] When compile

[PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}

2021-08-23 Thread Fangrui Song via Grub-devel
GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`. Clang silently ignores -malign-{jumps,loops,functions}. The preferred -falign-* forms have been supported since GCC 3.2, so just remove -malign-{jumps,loops,functions}. Signed-off-by: Fangrui Song --- configure.ac | 9 -

[PATCH 0/2] configure: Remove -malign-* and fix Clang 14 breakage

2021-08-23 Thread Fangrui Song via Grub-devel
This replaces https://lists.gnu.org/archive/html/grub-devel/2021-08/threads.html ("[PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -") Fangrui Song (2): configure: Remove obsoleted -malign-{jumps,loops,functions} configure: Check -falign-jumps=1 -falign-functions=1 besid

Re: [PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
Dear Fāng-ruì, Am 24.08.21 um 07:53 schrieb Fangrui Song via Grub-devel: Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jump

Re: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Fangrui Song via Grub-devel
Hi Paul, Thank you for your suggestions. I just sent v2 https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00091.html with a further cleanup. On 2021-08-24, Paul Menzel wrote: Dear Fangrui, Am 16.08.21 um 21:06 schrieb Fangrui Song via Grub-devel: Clang 14.0.0 has implemented -falign-

[PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Fangrui Song via Grub-devel
Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] When compile

Re: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Paul Menzel
Dear Fangrui, Am 16.08.21 um 21:06 schrieb Fangrui Song via Grub-devel: Clang 14.0.0 has implemented -falign-loops=1 but -falign-jumps=1 is still unsupported. The check should test all flags which may be added “alignment” flags? into CFLAGS. Signed-off-by: Fangrui Song --- configure.ac

Re: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-23 Thread Fāng-ruì Sòng via Grub-devel
Ping. This is needed to allow Clang 14.0.0 to build grub. On Mon, Aug 16, 2021 at 12:06 PM Fangrui Song wrote: > > Clang 14.0.0 has implemented -falign-loops=1 but -falign-jumps=1 is > still unsupported. The check should test all flags which may be added > into CFLAGS. > > Signed-off-by: Fangrui