Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Michael Chang via Grub-devel
On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > On Thu, Mar 18, 2021 at 07:30:26PM +0800, Michael Chang via Grub-devel wrote: [snip] > NAK for this patch and others "fixing" small MBR gaps. I am not going to > deal with this kind of issues any longer because a few folks in the > w

Re: [PATCH] Fix user-facing typo with an incorrect use of "it's"

2021-03-22 Thread Mihai Moldovan
* On 3/23/21 2:30 AM, Aru Sahni wrote: > This is my first attempted contribution to Grub. Please let me know if I need > to > make any revisions or updates. SOB, git-patch format, correct list and the bug is still around on the master branch... everything looks good. :) Mihai OpenPGP_signat

[PATCH] Fix user-facing typo with an incorrect use of "it's"

2021-03-22 Thread Aru Sahni
This is my first attempted contribution to Grub. Please let me know if I need to make any revisions or updates. This patch does the following: - Since the possessive form of "it" is being used, the apostrophe must be omitted. Signed-off-by: Aru Sahni --- util/grub.d/30_os-prober.in | 2 +-

Re: [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2021-03-22 Thread Mihai Moldovan
* On 3/21/21 9:06 PM, Glenn Washburn wrote: > I have another version of grub_uuidcasecmp which is more efficient by not > copying the UUID bytes to another buffer to strip out the dashes. [...] At first, I didn't understand why you would need to copy the original UUIDs in the first place, but then

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread James Bottomley
On Mon, 2021-03-22 at 15:19 -0500, Glenn Washburn wrote: > On Mon, 22 Mar 2021 16:16:26 + > Colin Watson wrote: > > > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > > NAK for this patch and others "fixing" small MBR gaps. I am not > > > going to deal with this kind of issue

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Colin Watson
On Mon, Mar 22, 2021 at 03:19:06PM -0500, Glenn Washburn wrote: > On Mon, 22 Mar 2021 16:16:26 + > Colin Watson wrote: > > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > > NAK for this patch and others "fixing" small MBR gaps. I am not > > > going to deal with this kind of i

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Glenn Washburn
On Mon, 22 Mar 2021 16:16:26 + Colin Watson wrote: > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > NAK for this patch and others "fixing" small MBR gaps. I am not > > going to deal with this kind of issues any longer because a few > > folks in the world cannot/do not want/

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Colin Watson
On Mon, Mar 22, 2021 at 04:16:26PM +, Colin Watson wrote: > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > NAK for this patch and others "fixing" small MBR gaps. I am not going to > > deal with this kind of issues any longer because a few folks in the > > world cannot/do not

Re: [PATCH] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2021-03-22 Thread Glenn Washburn
On Mon, 22 Mar 2021 18:54:53 + Maksim Fomin wrote: > ‐‐‐ Original Message ‐‐‐ > On Sunday, March 21, 2021 6:36 PM, Glenn Washburn > wrote: > > > A user can now specify UUID strings with dashes, instead of having > > to remove dashes. This is backwards-compatability preserving and >

[PATCH] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2021-03-22 Thread Maksim Fomin
‐‐‐ Original Message ‐‐‐ On Sunday, March 21, 2021 6:36 PM, Glenn Washburn wrote: > A user can now specify UUID strings with dashes, instead of having to remove > dashes. This is backwards-compatability preserving and also fixes a source > of user confusion over the inconsistency with ho

Re: [PATCH] arm/efi: fix ram base detection

2021-03-22 Thread Leif Lindholm
On Mon, Mar 22, 2021 at 17:00:15 +0100, Daniel Kiper wrote: > On Fri, Mar 12, 2021 at 05:54:55PM +0100, Vincent Stehlé via Grub-devel wrote: > > On 32b Arm platforms, grub allocates memory for the initrd in the first > > 512MB of DRAM. To do so, the grub_efi_get_ram_base() function will be > > call

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Colin Watson
On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > NAK for this patch and others "fixing" small MBR gaps. I am not going to > deal with this kind of issues any longer because a few folks in the > world cannot/do not want/... reinstall their systems. Sorry guys. I'd just like to say th

Re: [PATCH] minix: avoid mistakenly probing ext2 filesystems

2021-03-22 Thread Daniel Kiper
On Fri, Mar 12, 2021 at 12:05:08PM -0600, Derek Foreman wrote: > From: Daniel Drake > > ext2 (and ext3, ext4) filesystems write the number of free inodes to > location 0x410. > > On a minix filesystem, that same location is used for the minix superblock > magic number. > > If the number of free in

Re: [SECURITY PATCH 000/117] Multiple GRUB2 vulnerabilities - 2021/03/02 round

2021-03-22 Thread Daniel Kiper
On Thu, Mar 18, 2021 at 09:58:23AM +0100, Paul Menzel wrote: > Dear Darren, dear Darren, > > Am 02.03.21 um 19:00 schrieb Daniel Kiper: > > Thank you very much for finding and fixing all these issues, and > coordinating the publication. > > […] > > > .../lib/gnulib-patches/fix-null-state-deref.pa

Re: [PATCH] arm/efi: fix ram base detection

2021-03-22 Thread Daniel Kiper
On Fri, Mar 12, 2021 at 05:54:55PM +0100, Vincent Stehlé via Grub-devel wrote: > On 32b Arm platforms, grub allocates memory for the initrd in the first > 512MB of DRAM. To do so, the grub_efi_get_ram_base() function will be > called to compute the DRAM base. Currently this function returns the low

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-22 Thread Daniel Kiper
On Thu, Mar 18, 2021 at 07:30:26PM +0800, Michael Chang via Grub-devel wrote: > Given no core functions on i386-pc would require verifiers to work and > the only consumer of the verifier API is the pgp module, it looks good > to me that we can move the verifiers out of the kernel image and let > mo

Re: GRUB 2.06~rc1 released

2021-03-22 Thread Miguel Ángel Arruga Vivas
Hi, Daniel Kiper writes: > Translators can use http://alpha.gnu.org/pub/gnu/grub/grub-2.06~rc1.pot for > translation. > The pot signature is available at > http://alpha.gnu.org/pub/gnu/grub/grub-2.06~rc1.pot.sig Sorry for the delay to report, but during translation I noticed that two messages

Re: [PATCH] kern/misc: Move grub_printf_fmt_check to gfxmenu

2021-03-22 Thread Thomas Frauendorfer
On Sat, Mar 20, 2021 at 1:22 AM Colin Watson wrote: > > This function is only used by gfxmenu. Moving it there is unfortunately > a bit messy, but it frees up a fairly substantial amount (in relative > terms) of precious core image space on i386-pc. > > DOWN: obj/i386-pc/grub-core/kernel.img (3